From: Sam Ravnborg <sam@ravnborg.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes
Date: Wed, 6 May 2020 21:02:29 +0200 [thread overview]
Message-ID: <20200506190229.GC8227@ravnborg.org> (raw)
In-Reply-To: <20200429104234.18910-1-tomi.valkeinen@ti.com>
On Wed, Apr 29, 2020 at 01:42:32PM +0300, Tomi Valkeinen wrote:
> If videomode_from_timings() returns true, the mode allocated with
> drm_mode_create will be leaked.
>
> Also, the return value of drm_mode_create() is never checked, and thus
> could cause NULL deref.
>
> Fix these two issues.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
One nit
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 5584e656b857..f66e2f2a1a35 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -143,12 +143,16 @@ static int panel_connector_get_modes(struct drm_connector *connector)
> int i;
>
> for (i = 0; i < timings->num_timings; i++) {
> - struct drm_display_mode *mode = drm_mode_create(dev);
> + struct drm_display_mode *mode;
> struct videomode vm;
>
> if (videomode_from_timings(timings, &vm, i))
> break;
>
> + mode = drm_mode_create(dev);
extra space ^
> + if (!mode)
> + break;
> +
> drm_display_mode_from_videomode(&vm, mode);
>
> mode->type = DRM_MODE_TYPE_DRIVER;
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-06 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 10:42 [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes Tomi Valkeinen
2020-04-29 10:42 ` [PATCH 2/3] drm/tilcdc: remove unnecessary state->fb check Tomi Valkeinen
2020-05-19 6:06 ` Jyri Sarha
2020-04-29 10:42 ` [PATCH 3/3] drm/tilcdc: add missing static for panel_driver Tomi Valkeinen
2020-05-06 19:04 ` Sam Ravnborg
2020-05-19 6:07 ` Jyri Sarha
2020-05-06 19:02 ` Sam Ravnborg [this message]
2020-05-19 6:57 ` [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes Tomi Valkeinen
2020-05-19 6:06 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506190229.GC8227@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.