From: Sam Ravnborg <sam@ravnborg.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/tilcdc: add missing static for panel_driver
Date: Wed, 6 May 2020 21:04:02 +0200 [thread overview]
Message-ID: <20200506190402.GD8227@ravnborg.org> (raw)
In-Reply-To: <20200429104234.18910-3-tomi.valkeinen@ti.com>
On Wed, Apr 29, 2020 at 01:42:34PM +0300, Tomi Valkeinen wrote:
> struct platform_driver panel_driver is only used from tilcdc_panel.c, so
> it can be static.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index f66e2f2a1a35..cdc93a81b552 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -404,7 +404,7 @@ static const struct of_device_id panel_of_match[] = {
> { },
> };
>
> -struct platform_driver panel_driver = {
> +static struct platform_driver panel_driver = {
> .probe = panel_probe,
> .remove = panel_remove,
> .driver = {
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-06 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 10:42 [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes Tomi Valkeinen
2020-04-29 10:42 ` [PATCH 2/3] drm/tilcdc: remove unnecessary state->fb check Tomi Valkeinen
2020-05-19 6:06 ` Jyri Sarha
2020-04-29 10:42 ` [PATCH 3/3] drm/tilcdc: add missing static for panel_driver Tomi Valkeinen
2020-05-06 19:04 ` Sam Ravnborg [this message]
2020-05-19 6:07 ` Jyri Sarha
2020-05-06 19:02 ` [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes Sam Ravnborg
2020-05-19 6:57 ` Tomi Valkeinen
2020-05-19 6:06 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506190402.GD8227@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.