Re: [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Pavel Machek <pavel@ucw.cz>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Rob Herring <robh+dt@kernel.org>,
	Andrew Murray <amurray@thegoodpenguin.co.uk>,
	Tom Joseph <tjoseph@cadence.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Lad Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller
Date: Thu, 7 May 2020 19:44:46 +0200	[thread overview]
Message-ID: <20200507174446.GC1216@bug> (raw)
In-Reply-To: <1587666159-6035-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi!


> R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple windows
> supported by the controller for mapping PCI address locally.
> 
> Note:
> The cadence/rockchip/designware endpoint drivers are build tested only.
> 
> Changes for v9 (Re-spun this series as there were minimal changes requested):
...
> * Replaced mdelay(1) with usleep_range(1000, 1001) in rcar_pcie_ep_assert_intx()

Are you sure that is good idea? You are requesting 1ms sleep time with 1us tolerance,
I dont believe common systems can do that.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)

From: Pavel Machek <pavel@ucw.cz>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Rob Herring <robh+dt@kernel.org>,
	Andrew Murray <amurray@thegoodpenguin.co.uk>,
	Tom Joseph <tjoseph@cadence.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Lad Prabhakar <prabhakar.csen>
Subject: Re: [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller
Date: Thu, 7 May 2020 19:44:46 +0200	[thread overview]
Message-ID: <20200507174446.GC1216@bug> (raw)
In-Reply-To: <1587666159-6035-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi!


> R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple windows
> supported by the controller for mapping PCI address locally.
> 
> Note:
> The cadence/rockchip/designware endpoint drivers are build tested only.
> 
> Changes for v9 (Re-spun this series as there were minimal changes requested):
...
> * Replaced mdelay(1) with usleep_range(1000, 1001) in rcar_pcie_ep_assert_intx()

Are you sure that is good idea? You are requesting 1ms sleep time with 1us tolerance,
I dont believe common systems can do that.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)

From: Pavel Machek <pavel@ucw.cz>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: devicetree@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Jingoo Han <jingoohan1@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	Tom Joseph <tjoseph@cadence.com>,
	Rob Herring <robh+dt@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Lad Prabhakar <prabhakar.csengg@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org,
	Andrew Murray <amurray@thegoodpenguin.co.uk>
Subject: Re: [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller
Date: Thu, 7 May 2020 19:44:46 +0200	[thread overview]
Message-ID: <20200507174446.GC1216@bug> (raw)
In-Reply-To: <1587666159-6035-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi!


> R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple windows
> supported by the controller for mapping PCI address locally.
> 
> Note:
> The cadence/rockchip/designware endpoint drivers are build tested only.
> 
> Changes for v9 (Re-spun this series as there were minimal changes requested):
...
> * Replaced mdelay(1) with usleep_range(1000, 1001) in rcar_pcie_ep_assert_intx()

Are you sure that is good idea? You are requesting 1ms sleep time with 1us tolerance,
I dont believe common systems can do that.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2020-05-07 17:44 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 18:22 [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller Lad Prabhakar
2020-04-23 18:22 ` Lad Prabhakar
2020-04-23 18:22 ` [PATCH v9 1/8] PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-23 18:22 ` [PATCH v9 2/8] PCI: rcar: Move shareable code to a common file Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-23 18:22 ` [PATCH v9 3/8] PCI: rcar: Fix calculating mask for PCIEPAMR register Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-23 18:22 ` [PATCH v9 4/8] PCI: endpoint: Pass page size as argument to pci_epc_mem_init() Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-24  5:59   ` Yoshihiro Shimoda
2020-04-24  5:59     ` Yoshihiro Shimoda
2020-04-24  5:59     ` Yoshihiro Shimoda
2020-05-07  2:52   ` Kishon Vijay Abraham I
2020-05-07  2:52     ` Kishon Vijay Abraham I
2020-05-07  2:52     ` Kishon Vijay Abraham I
2020-04-23 18:22 ` [PATCH v9 5/8] PCI: endpoint: Add support to handle multiple base for mapping outbound memory Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-24  6:00   ` Yoshihiro Shimoda
2020-04-24  6:00     ` Yoshihiro Shimoda
2020-04-24  6:00     ` Yoshihiro Shimoda
2020-04-24  6:13   ` Kishon Vijay Abraham I
2020-04-24  6:13     ` Kishon Vijay Abraham I
2020-04-24  6:13     ` Kishon Vijay Abraham I
2020-04-24  7:46     ` Lad, Prabhakar
2020-04-24  7:46       ` Lad, Prabhakar
2020-04-24  7:46       ` Lad, Prabhakar
2020-04-24  8:00       ` Kishon Vijay Abraham I
2020-04-24  8:00         ` Kishon Vijay Abraham I
2020-04-24  8:00         ` Kishon Vijay Abraham I
2020-05-07  2:52   ` Kishon Vijay Abraham I
2020-05-07  2:52     ` Kishon Vijay Abraham I
2020-05-07  2:52     ` Kishon Vijay Abraham I
2020-04-23 18:22 ` [PATCH v9 6/8] dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-23 18:22 ` [PATCH v9 7/8] PCI: rcar: Add endpoint mode support Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-24  6:01   ` Yoshihiro Shimoda
2020-04-24  6:01     ` Yoshihiro Shimoda
2020-04-24  6:01     ` Yoshihiro Shimoda
2020-04-23 18:22 ` [PATCH v9 8/8] MAINTAINERS: Add file patterns for rcar PCI device tree bindings Lad Prabhakar
2020-04-23 18:22   ` Lad Prabhakar
2020-04-30  8:43 ` [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller Lad, Prabhakar
2020-04-30  8:43   ` Lad, Prabhakar
2020-04-30  8:43   ` Lad, Prabhakar
2020-05-05  9:44   ` Lorenzo Pieralisi
2020-05-05  9:44     ` Lorenzo Pieralisi
2020-05-05  9:44     ` Lorenzo Pieralisi
2020-05-05  9:47     ` Lad, Prabhakar
2020-05-05  9:47       ` Lad, Prabhakar
2020-05-05  9:47       ` Lad, Prabhakar
2020-05-07  3:12       ` Kishon Vijay Abraham I
2020-05-07  3:12         ` Kishon Vijay Abraham I
2020-05-07  3:12         ` Kishon Vijay Abraham I
2020-05-07  7:34         ` Lad, Prabhakar
2020-05-07  7:34           ` Lad, Prabhakar
2020-05-07  7:34           ` Lad, Prabhakar
2020-05-07 17:44 ` Pavel Machek [this message]
2020-05-07 17:44   ` Pavel Machek
2020-05-07 17:44   ` Pavel Machek
2020-05-07 17:53   ` Lad, Prabhakar
2020-05-07 17:53     ` Lad, Prabhakar
2020-05-07 17:53     ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200507174446.GC1216@bug \
    --to=pavel@ucw.cz \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=heiko@sntech.de \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=tjoseph@cadence.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.