From: Thierry Reding <thierry.reding@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Joseph Lo <josephl@nvidia.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] memory: tegra: EMC scaling is not a clock provider
Date: Thu, 7 May 2020 22:07:18 +0200 [thread overview]
Message-ID: <20200507200718.GD2981633@ulmo> (raw)
In-Reply-To: <20200506123236.7463-1-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
On Wed, May 06, 2020 at 02:32:34PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> The Tegra EMC scaling support code is not a clock provider, but merely a
> clock consumer, and thus does not need to include
> <linux/clk-provider.h>.
>
> However, drivers/memory/tegra/tegra210-emc-table.c relies on
> tegra210-emc.h to include <linux/of.h> through <linux/clk-provider.h>.
> Hence the first patch makes <linux/of_reserved_mem.h> self-contained
> first.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (2):
> of: Make <linux/of_reserved_mem.h> self-contained
> memory: tegra: Drop <linux/clk-provider.h>
>
> drivers/memory/tegra/tegra210-emc-core.c | 1 -
> drivers/memory/tegra/tegra210-emc.h | 1 -
> include/linux/of_reserved_mem.h | 1 +
> 3 files changed, 1 insertion(+), 2 deletions(-)
Ah... I should've read the cover letter first. Looks like I need to take
that first patch through the Tegra tree as well to avoid introducing the
build error in the second patch.
Rob, do you mind if I pick up patch 1 of this into the same OF branch
that I already carry the memory-region-names patches on?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Cc: Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/2] memory: tegra: EMC scaling is not a clock provider
Date: Thu, 7 May 2020 22:07:18 +0200 [thread overview]
Message-ID: <20200507200718.GD2981633@ulmo> (raw)
In-Reply-To: <20200506123236.7463-1-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
On Wed, May 06, 2020 at 02:32:34PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> The Tegra EMC scaling support code is not a clock provider, but merely a
> clock consumer, and thus does not need to include
> <linux/clk-provider.h>.
>
> However, drivers/memory/tegra/tegra210-emc-table.c relies on
> tegra210-emc.h to include <linux/of.h> through <linux/clk-provider.h>.
> Hence the first patch makes <linux/of_reserved_mem.h> self-contained
> first.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (2):
> of: Make <linux/of_reserved_mem.h> self-contained
> memory: tegra: Drop <linux/clk-provider.h>
>
> drivers/memory/tegra/tegra210-emc-core.c | 1 -
> drivers/memory/tegra/tegra210-emc.h | 1 -
> include/linux/of_reserved_mem.h | 1 +
> 3 files changed, 1 insertion(+), 2 deletions(-)
Ah... I should've read the cover letter first. Looks like I need to take
that first patch through the Tegra tree as well to avoid introducing the
build error in the second patch.
Rob, do you mind if I pick up patch 1 of this into the same OF branch
that I already carry the memory-region-names patches on?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-07 20:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 12:32 [PATCH 0/2] memory: tegra: EMC scaling is not a clock provider Geert Uytterhoeven
2020-05-06 12:32 ` [PATCH 1/2] of: Make <linux/of_reserved_mem.h> self-contained Geert Uytterhoeven
2020-05-07 20:04 ` Thierry Reding
2020-05-07 20:04 ` Thierry Reding
2020-05-12 21:15 ` Stephen Boyd
2020-05-12 21:15 ` Stephen Boyd
2020-05-06 12:32 ` [PATCH 2/2] memory: tegra: Drop <linux/clk-provider.h> Geert Uytterhoeven
2020-05-06 12:32 ` Geert Uytterhoeven
2020-05-07 20:04 ` Thierry Reding
2020-06-15 8:39 ` Geert Uytterhoeven
2020-06-15 8:39 ` Geert Uytterhoeven
2020-05-12 21:15 ` Stephen Boyd
2020-05-12 21:15 ` Stephen Boyd
2020-05-07 20:07 ` Thierry Reding [this message]
2020-05-07 20:07 ` [PATCH 0/2] memory: tegra: EMC scaling is not a clock provider Thierry Reding
2020-05-11 17:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507200718.GD2981633@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.