From: Dan Carpenter <dan.carpenter@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Yunfeng Ye <yeyunfeng@huawei.com>,
Markus Elfring <Markus.Elfring@web.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [v3] tools/bootconfig: fix resource leak in apply_xbc()
Date: Fri, 08 May 2020 14:45:27 +0000 [thread overview]
Message-ID: <20200508144527.GR1992@kadam> (raw)
In-Reply-To: <20200508090053.430d28d7@gandalf.local.home>
On Fri, May 08, 2020 at 09:00:53AM -0400, Steven Rostedt wrote:
> On Fri, 8 May 2020 19:42:56 +0800
> Yunfeng Ye <yeyunfeng@huawei.com> wrote:
>
> > On 2020/5/8 19:30, Markus Elfring wrote:
> > >> this change can fix the warning of tools.
> > >
> > > Would you like to point any specific source code analysis tools out
> > > for this issue?
> > > (Can a corresponding attribution become relevant for a clearer
> > > change description?)
> > >
> > The tools we used is not for open source. it point out some error description like
> > "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c.
> >
> > Can I only description:
> > "Memory and resource leak is found by a static code analysis tools" ? thanks.
>
> Markus please stop! Your suggestions are just your preferences that are not
> required for the kernel.
>
> Yunfeng, your v2 was fine and has already landed in Linus's tree. Feel free
> to ignore Markus's suggestions in the future.
There was actually a bug in v2. It exits with a non-zero instead of
zero on success so it will mess up people's scripts.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Yunfeng Ye <yeyunfeng@huawei.com>,
Markus Elfring <Markus.Elfring@web.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [v3] tools/bootconfig: fix resource leak in apply_xbc()
Date: Fri, 8 May 2020 17:45:27 +0300 [thread overview]
Message-ID: <20200508144527.GR1992@kadam> (raw)
In-Reply-To: <20200508090053.430d28d7@gandalf.local.home>
On Fri, May 08, 2020 at 09:00:53AM -0400, Steven Rostedt wrote:
> On Fri, 8 May 2020 19:42:56 +0800
> Yunfeng Ye <yeyunfeng@huawei.com> wrote:
>
> > On 2020/5/8 19:30, Markus Elfring wrote:
> > >> this change can fix the warning of tools.
> > >
> > > Would you like to point any specific source code analysis tools out
> > > for this issue?
> > > (Can a corresponding attribution become relevant for a clearer
> > > change description?)
> > >
> > The tools we used is not for open source. it point out some error description like
> > "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c.
> >
> > Can I only description:
> > "Memory and resource leak is found by a static code analysis tools" ? thanks.
>
> Markus please stop! Your suggestions are just your preferences that are not
> required for the kernel.
>
> Yunfeng, your v2 was fine and has already landed in Linus's tree. Feel free
> to ignore Markus's suggestions in the future.
There was actually a bug in v2. It exits with a non-zero instead of
zero on success so it will mess up people's scripts.
regards,
dan carpenter
next prev parent reply other threads:[~2020-05-08 14:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 10:52 [PATCH v3] tools/bootconfig: fix resource leak in apply_xbc() Yunfeng Ye
2020-05-08 10:52 ` Yunfeng Ye
2020-05-08 11:03 ` Markus Elfring
2020-05-08 11:03 ` Markus Elfring
2020-05-08 11:18 ` Yunfeng Ye
2020-05-08 11:18 ` Yunfeng Ye
2020-05-08 11:30 ` [v3] " Markus Elfring
2020-05-08 11:30 ` Markus Elfring
2020-05-08 11:42 ` Yunfeng Ye
2020-05-08 11:42 ` Yunfeng Ye
2020-05-08 13:00 ` Steven Rostedt
2020-05-08 13:00 ` Steven Rostedt
2020-05-08 13:06 ` Markus Elfring
2020-05-08 13:06 ` Markus Elfring
2020-05-08 14:45 ` Dan Carpenter [this message]
2020-05-08 14:45 ` Dan Carpenter
2020-05-08 15:14 ` Steven Rostedt
2020-05-08 15:14 ` Steven Rostedt
2020-05-08 16:42 ` Markus Elfring
2020-05-08 16:42 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508144527.GR1992@kadam \
--to=dan.carpenter@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.