From: Joerg Roedel <joro@8bytes.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: eugene.volanschi@inria.fr,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/virtio: reverse arguments to list_add
Date: Fri, 08 May 2020 15:31:49 +0000 [thread overview]
Message-ID: <20200508153149.GA10908@8bytes.org> (raw)
In-Reply-To: <1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr>
On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote:
> Elsewhere in the file, there is a list_for_each_entry with
> &vdev->resv_regions as the second argument, suggesting that
> &vdev->resv_regions is the list head. So exchange the
> arguments on the list_add call to put the list head in the
> second argument.
>
> Fixes: 2a5a31487445 ("iommu/virtio: Add probe request")
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied for v5.7, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: eugene.volanschi@inria.fr,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/virtio: reverse arguments to list_add
Date: Fri, 8 May 2020 17:31:49 +0200 [thread overview]
Message-ID: <20200508153149.GA10908@8bytes.org> (raw)
In-Reply-To: <1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr>
On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote:
> Elsewhere in the file, there is a list_for_each_entry with
> &vdev->resv_regions as the second argument, suggesting that
> &vdev->resv_regions is the list head. So exchange the
> arguments on the list_add call to put the list head in the
> second argument.
>
> Fixes: 2a5a31487445 ("iommu/virtio: Add probe request")
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied for v5.7, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
kernel-janitors@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
eugene.volanschi@inria.fr
Subject: Re: [PATCH] iommu/virtio: reverse arguments to list_add
Date: Fri, 8 May 2020 17:31:49 +0200 [thread overview]
Message-ID: <20200508153149.GA10908@8bytes.org> (raw)
In-Reply-To: <1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr>
On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote:
> Elsewhere in the file, there is a list_for_each_entry with
> &vdev->resv_regions as the second argument, suggesting that
> &vdev->resv_regions is the list head. So exchange the
> arguments on the list_add call to put the list head in the
> second argument.
>
> Fixes: 2a5a31487445 ("iommu/virtio: Add probe request")
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied for v5.7, thanks.
next prev parent reply other threads:[~2020-05-08 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:47 [PATCH] iommu/virtio: reverse arguments to list_add Julia Lawall
2020-05-05 18:47 ` Julia Lawall
2020-05-05 18:47 ` Julia Lawall
2020-05-06 9:35 ` Jean-Philippe Brucker
2020-05-06 9:35 ` Jean-Philippe Brucker
2020-05-06 9:35 ` Jean-Philippe Brucker
2020-05-08 15:31 ` Joerg Roedel [this message]
2020-05-08 15:31 ` Joerg Roedel
2020-05-08 15:31 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508153149.GA10908@8bytes.org \
--to=joro@8bytes.org \
--cc=Julia.Lawall@inria.fr \
--cc=eugene.volanschi@inria.fr \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.