All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] firmware: arm_scmi/mailbox: ignore notification for tx done using irq
@ 2020-05-09  8:54 ` joe_zhuchg
  0 siblings, 0 replies; 7+ messages in thread
From: joe_zhuchg @ 2020-05-09  8:54 UTC (permalink / raw)
  To: sudeep.holla; +Cc: Joe Zhu, linux-kernel, linux-arm-kernel

From: Joe Zhu <Chunguang.Zhu@verisilicon.com>

If mailbox uses IRQ method, it already notified framework with
mbox_chan_txdone() in ISR.

Signed-off-by: Joe Zhu <Chunguang.Zhu@verisilicon.com>
---
 drivers/firmware/arm_scmi/mailbox.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/mailbox.c b/drivers/firmware/arm_scmi/mailbox.c
index 73077bbc4ad9..303a5dc42429 100644
--- a/drivers/firmware/arm_scmi/mailbox.c
+++ b/drivers/firmware/arm_scmi/mailbox.c
@@ -9,6 +9,7 @@
 #include <linux/err.h>
 #include <linux/device.h>
 #include <linux/mailbox_client.h>
+#include <linux/mailbox_controller.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/slab.h>
@@ -147,7 +148,8 @@ static void mailbox_mark_txdone(struct scmi_chan_info *cinfo, int ret)
 	 * Unfortunately, we have to kick the mailbox framework after we have
 	 * received our message.
 	 */
-	mbox_client_txdone(smbox->chan, ret);
+	if (!smbox->chan->mbox->txdone_irq)
+		mbox_client_txdone(smbox->chan, ret);
 }
 
 static void mailbox_fetch_response(struct scmi_chan_info *cinfo,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-05-13  8:51 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-09  8:54 [PATCH 1/1] firmware: arm_scmi/mailbox: ignore notification for tx done using irq joe_zhuchg
2020-05-09  8:54 ` joe_zhuchg
2020-05-09 15:20 ` Sudeep Holla
2020-05-09 15:20   ` Sudeep Holla
2020-05-11  0:52   ` 答复: " Zhu, Joe
2020-05-11  0:52     ` Zhu, Joe
2020-05-13  8:51 ` [firmware] 88a5883981: will-it-scale.per_thread_ops -66.8% regression kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.