From: Jonathan Cameron <jic23@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()
Date: Sun, 10 May 2020 09:55:57 +0000 [thread overview]
Message-ID: <20200510105557.716fa742@archlinux> (raw)
In-Reply-To: <6e972e9b-c799-f0ad-91ac-144640b463f6@web.de>
On Wed, 6 May 2020 17:30:06 +0200
Markus Elfring <Markus.Elfring@web.de> wrote:
> > This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.
>
> Is there a need to prevent similar function calls by the means of
> advanced source code analysis?
It's a seriously stupid bug so I'd have thought unlikely to
occur often enough to be worth it.
Jonathan
>
> Regards,
> Markus
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()
Date: Sun, 10 May 2020 10:55:57 +0100 [thread overview]
Message-ID: <20200510105557.716fa742@archlinux> (raw)
In-Reply-To: <6e972e9b-c799-f0ad-91ac-144640b463f6@web.de>
On Wed, 6 May 2020 17:30:06 +0200
Markus Elfring <Markus.Elfring@web.de> wrote:
> > This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.
>
> Is there a need to prevent similar function calls by the means of
> advanced source code analysis?
It's a seriously stupid bug so I'd have thought unlikely to
occur often enough to be worth it.
Jonathan
>
> Regards,
> Markus
next prev parent reply other threads:[~2020-05-10 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 3:52 [PATCH] iio: sca3000: Remove an erroneous 'get_device()' Christophe JAILLET
2020-05-06 3:52 ` Christophe JAILLET
2020-05-06 10:38 ` Andy Shevchenko
2020-05-06 10:38 ` Andy Shevchenko
2020-05-06 17:31 ` Marion & Christophe JAILLET
2020-05-06 17:31 ` Marion & Christophe JAILLET
2020-05-08 13:02 ` Jonathan Cameron
2020-05-08 13:02 ` Jonathan Cameron
2020-05-10 9:54 ` Jonathan Cameron
2020-05-10 9:54 ` Jonathan Cameron
2020-05-06 15:30 ` [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data() Markus Elfring
2020-05-06 15:30 ` Markus Elfring
2020-05-10 9:55 ` Jonathan Cameron [this message]
2020-05-10 9:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510105557.716fa742@archlinux \
--to=jic23@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.