From: Dan Carpenter <dan.carpenter@oracle.com>
To: Walter Harms <wharms@bfs.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
Hemant Kumar <hemantk@codeaurora.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sujeev Dias <sdias@codeaurora.org>,
Siddartha Mohanadoss <smohanad@codeaurora.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] bus: mhi: core: Fix some error return code
Date: Mon, 11 May 2020 18:43:06 +0000 [thread overview]
Message-ID: <20200511184306.GI9365@kadam> (raw)
In-Reply-To: <78d3f7d7be1849138df7dcf9d49177b5@bfs.de>
On Mon, May 11, 2020 at 02:26:10PM +0000, Walter Harms wrote:
> Hello guys,
> some nitpicking ...
> the prefered kernalstyle is:
>
> if (condition)
> set error_code
> do something
>
> from what i can see it is
>
> set error_code
> if (condition)
There isn't a prefered style. Both are accepted. Most people have a
personal preference, but there isn't an official preference.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Walter Harms <wharms@bfs.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
Hemant Kumar <hemantk@codeaurora.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sujeev Dias <sdias@codeaurora.org>,
Siddartha Mohanadoss <smohanad@codeaurora.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] bus: mhi: core: Fix some error return code
Date: Mon, 11 May 2020 21:43:06 +0300 [thread overview]
Message-ID: <20200511184306.GI9365@kadam> (raw)
In-Reply-To: <78d3f7d7be1849138df7dcf9d49177b5@bfs.de>
On Mon, May 11, 2020 at 02:26:10PM +0000, Walter Harms wrote:
> Hello guys,
> some nitpicking ...
> the prefered kernalstyle is:
>
> if (condition)
> set error_code
> do something
>
> from what i can see it is
>
> set error_code
> if (condition)
There isn't a prefered style. Both are accepted. Most people have a
personal preference, but there isn't an official preference.
regards,
dan carpenter
next prev parent reply other threads:[~2020-05-11 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 7:56 [PATCH -next] bus: mhi: core: Fix some error return code Wei Yongjun
2020-05-09 7:56 ` Wei Yongjun
2020-05-11 10:31 ` Manivannan Sadhasivam
2020-05-11 10:43 ` Manivannan Sadhasivam
2020-05-11 14:26 ` AW: " Walter Harms
2020-05-11 14:56 ` Manivannan Sadhasivam
2020-05-11 14:56 ` Manivannan Sadhasivam
2020-05-11 18:43 ` Dan Carpenter [this message]
2020-05-11 18:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511184306.GI9365@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=hulkci@huawei.com \
--cc=jhugo@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=sdias@codeaurora.org \
--cc=smohanad@codeaurora.org \
--cc=weiyongjun1@huawei.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.