All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	atish.patra@wdc.com, palmer@dabbelt.com,
	paul.walmsley@sifive.com, linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH 4/4] dt-bindings: net: phy: extend dt binding for VSC8541 ethernet-phy
Date: Mon, 11 May 2020 21:12:04 -0500	[thread overview]
Message-ID: <20200512021204.GA12999@bogus> (raw)
In-Reply-To: <1588072608-7747-5-git-send-email-sagar.kadam@sifive.com>

On Tue, Apr 28, 2020 at 04:16:48AM -0700, Sagar Shrikant Kadam wrote:
> Adding a OUI (Organizationally Unique Identifier) for VSC8541-01
> device to dt node requires a corresponding dt-binding entry as well
> so that checkpatch doesn't complain with a warning:
> 
> DT compatible string "ethernet-phy-id0007.0771" appears un-documented
> 
> Here extend the existing dt binding of VSC8531 device to include
> VSC8541 device example.

Checkpatch.pl is just dumb here and can be ignored. We have the regex 
that documents this compatible. We don't need every VID/PID listed.

> 
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
>  Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 5ff37c6..774448a 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -68,3 +68,6 @@ Example:
>                  vsc8531,led-0-mode	= <LINK_1000_ACTIVITY>;
>                  vsc8531,led-1-mode	= <LINK_100_ACTIVITY>;
>          };
> +        vsc8541_0: ethernet-phy@0 {
> +                compatible = "ethernet-phy-id0007.0771";
> +	};
> -- 
> 2.7.4
> 


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	atish.patra@wdc.com, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 4/4] dt-bindings: net: phy: extend dt binding for VSC8541 ethernet-phy
Date: Mon, 11 May 2020 21:12:04 -0500	[thread overview]
Message-ID: <20200512021204.GA12999@bogus> (raw)
In-Reply-To: <1588072608-7747-5-git-send-email-sagar.kadam@sifive.com>

On Tue, Apr 28, 2020 at 04:16:48AM -0700, Sagar Shrikant Kadam wrote:
> Adding a OUI (Organizationally Unique Identifier) for VSC8541-01
> device to dt node requires a corresponding dt-binding entry as well
> so that checkpatch doesn't complain with a warning:
> 
> DT compatible string "ethernet-phy-id0007.0771" appears un-documented
> 
> Here extend the existing dt binding of VSC8531 device to include
> VSC8541 device example.

Checkpatch.pl is just dumb here and can be ignored. We have the regex 
that documents this compatible. We don't need every VID/PID listed.

> 
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
>  Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 5ff37c6..774448a 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -68,3 +68,6 @@ Example:
>                  vsc8531,led-0-mode	= <LINK_1000_ACTIVITY>;
>                  vsc8531,led-1-mode	= <LINK_100_ACTIVITY>;
>          };
> +        vsc8541_0: ethernet-phy@0 {
> +                compatible = "ethernet-phy-id0007.0771";
> +	};
> -- 
> 2.7.4
> 

  reply	other threads:[~2020-05-12  2:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 11:16 [RFC PATCH 0/4] fix macb phy probe failure if phy-reset is not handled Sagar Shrikant Kadam
2020-04-28 11:16 ` Sagar Shrikant Kadam
2020-04-28 11:16 ` [RFC PATCH 1/4] dts: phy: fix missing mdio device and probe failure of vsc8541-01 device Sagar Shrikant Kadam
2020-04-28 11:16   ` Sagar Shrikant Kadam
2020-04-28 11:16 ` [RFC PATCH 2/4] dts: phy: add GPIO number and active state used for phy reset Sagar Shrikant Kadam
2020-04-28 11:16   ` Sagar Shrikant Kadam
2020-04-28 11:16 ` [RFC PATCH 3/4] riscv: defconfig: enable gpio support for HiFive Unleashed Sagar Shrikant Kadam
2020-04-28 11:16   ` Sagar Shrikant Kadam
2020-04-28 11:16 ` [RFC PATCH 4/4] dt-bindings: net: phy: extend dt binding for VSC8541 ethernet-phy Sagar Shrikant Kadam
2020-04-28 11:16   ` Sagar Shrikant Kadam
2020-05-12  2:12   ` Rob Herring [this message]
2020-05-12  2:12     ` Rob Herring
2020-05-12  7:14     ` Sagar Kadam
2020-05-12  7:14       ` Sagar Kadam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512021204.GA12999@bogus \
    --to=robh@kernel.org \
    --cc=atish.patra@wdc.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=sagar.kadam@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.