* [PATCH][next] ath11k: remove redundant initialization of pointer info
@ 2020-05-07 16:43 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2020-05-07 16:43 UTC (permalink / raw)
To: Kalle Valo, David S . Miller, ath11k, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer info is being assigned twice, once at the start of the function
and secondly when it is just about to be accessed. Remove the redundant
initialization and keep the original assignment to info that is close
to the memcpy that uses it.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ath/ath11k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index d9117ebf2809..1a7e5817e5c8 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3692,7 +3692,7 @@ static int __ath11k_set_antenna(struct ath11k *ar, u32 tx_ant, u32 rx_ant)
int ath11k_mac_tx_mgmt_pending_free(int buf_id, void *skb, void *ctx)
{
struct sk_buff *msdu = skb;
- struct ieee80211_tx_info *info = IEEE80211_SKB_CB(msdu);
+ struct ieee80211_tx_info *info;
struct ath11k *ar = ctx;
struct ath11k_base *ab = ar->ab;
--
2.25.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][next] ath11k: remove redundant initialization of pointer info
@ 2020-05-07 16:43 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2020-05-07 16:43 UTC (permalink / raw)
To: Kalle Valo, David S . Miller, ath11k, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer info is being assigned twice, once at the start of the function
and secondly when it is just about to be accessed. Remove the redundant
initialization and keep the original assignment to info that is close
to the memcpy that uses it.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ath/ath11k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index d9117ebf2809..1a7e5817e5c8 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3692,7 +3692,7 @@ static int __ath11k_set_antenna(struct ath11k *ar, u32 tx_ant, u32 rx_ant)
int ath11k_mac_tx_mgmt_pending_free(int buf_id, void *skb, void *ctx)
{
struct sk_buff *msdu = skb;
- struct ieee80211_tx_info *info = IEEE80211_SKB_CB(msdu);
+ struct ieee80211_tx_info *info;
struct ath11k *ar = ctx;
struct ath11k_base *ab = ar->ab;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][next] ath11k: remove redundant initialization of pointer info
@ 2020-05-07 16:43 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2020-05-07 16:43 UTC (permalink / raw)
To: Kalle Valo, David S . Miller, ath11k, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer info is being assigned twice, once at the start of the function
and secondly when it is just about to be accessed. Remove the redundant
initialization and keep the original assignment to info that is close
to the memcpy that uses it.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ath/ath11k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index d9117ebf2809..1a7e5817e5c8 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3692,7 +3692,7 @@ static int __ath11k_set_antenna(struct ath11k *ar, u32 tx_ant, u32 rx_ant)
int ath11k_mac_tx_mgmt_pending_free(int buf_id, void *skb, void *ctx)
{
struct sk_buff *msdu = skb;
- struct ieee80211_tx_info *info = IEEE80211_SKB_CB(msdu);
+ struct ieee80211_tx_info *info;
struct ath11k *ar = ctx;
struct ath11k_base *ab = ar->ab;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][next] ath11k: remove redundant initialization of pointer info
2020-05-07 16:43 ` Colin King
(?)
(?)
@ 2020-05-12 7:34 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-05-12 7:34 UTC (permalink / raw)
To: Colin King
Cc: linux-wireless, netdev, kernel-janitors, linux-kernel, ath11k,
David S . Miller
Colin King <colin.king@canonical.com> wrote:
> Pointer info is being assigned twice, once at the start of the function
> and secondly when it is just about to be accessed. Remove the redundant
> initialization and keep the original assignment to info that is close
> to the memcpy that uses it.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
52b776fa5921 ath11k: remove redundant initialization of pointer info
--
https://patchwork.kernel.org/patch/11534415/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][next] ath11k: remove redundant initialization of pointer info
2020-05-07 16:43 ` Colin King
@ 2020-05-12 7:34 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-05-12 7:34 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, ath11k, linux-wireless, netdev, kernel-janitors,
linux-kernel
Colin King <colin.king@canonical.com> wrote:
> Pointer info is being assigned twice, once at the start of the function
> and secondly when it is just about to be accessed. Remove the redundant
> initialization and keep the original assignment to info that is close
> to the memcpy that uses it.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
52b776fa5921 ath11k: remove redundant initialization of pointer info
--
https://patchwork.kernel.org/patch/11534415/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][next] ath11k: remove redundant initialization of pointer info
@ 2020-05-12 7:34 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-05-12 7:34 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, ath11k, linux-wireless, netdev, kernel-janitors,
linux-kernel
Colin King <colin.king@canonical.com> wrote:
> Pointer info is being assigned twice, once at the start of the function
> and secondly when it is just about to be accessed. Remove the redundant
> initialization and keep the original assignment to info that is close
> to the memcpy that uses it.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
52b776fa5921 ath11k: remove redundant initialization of pointer info
--
https://patchwork.kernel.org/patch/11534415/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-12 7:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 16:43 [PATCH][next] ath11k: remove redundant initialization of pointer info Colin King
2020-05-07 16:43 ` Colin King
2020-05-07 16:43 ` Colin King
2020-05-12 7:34 ` Kalle Valo
2020-05-12 7:34 ` Kalle Valo
2020-05-12 7:34 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.