From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, "Fam Zheng" <fam@euphon.net>,
kvm@vger.kernel.org, qemu-block@nongnu.org,
qemu-trivial@nongnu.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v4 0/6] scripts: More Python fixes
Date: Tue, 12 May 2020 13:16:41 +0200 [thread overview]
Message-ID: <20200512111641.GJ5951@linux.fritz.box> (raw)
In-Reply-To: <20200512103238.7078-1-philmd@redhat.com>
Am 12.05.2020 um 12:32 hat Philippe Mathieu-Daudé geschrieben:
> Trivial Python3 fixes, again...
>
> Since v3:
> - Fixed missing scripts/qemugdb/timers.py (kwolf)
> - Cover more scripts
> - Check for __main__ in few scripts
I'm not sure if the __main__ check actually provides anything useful in
source files of standalone tools that aren't supposed to be imported
from somewhere else. But of course, it's not wrong either.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
kvm@vger.kernel.org, qemu-block@nongnu.org,
qemu-trivial@nongnu.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v4 0/6] scripts: More Python fixes
Date: Tue, 12 May 2020 13:16:41 +0200 [thread overview]
Message-ID: <20200512111641.GJ5951@linux.fritz.box> (raw)
In-Reply-To: <20200512103238.7078-1-philmd@redhat.com>
Am 12.05.2020 um 12:32 hat Philippe Mathieu-Daudé geschrieben:
> Trivial Python3 fixes, again...
>
> Since v3:
> - Fixed missing scripts/qemugdb/timers.py (kwolf)
> - Cover more scripts
> - Check for __main__ in few scripts
I'm not sure if the __main__ check actually provides anything useful in
source files of standalone tools that aren't supposed to be imported
from somewhere else. But of course, it's not wrong either.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2020-05-12 11:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 10:32 [PATCH v4 0/6] scripts: More Python fixes Philippe Mathieu-Daudé
2020-05-12 10:32 ` Philippe Mathieu-Daudé
2020-05-12 10:32 ` [PATCH v4 1/6] scripts/qemugdb: Remove shebang header Philippe Mathieu-Daudé
2020-05-12 10:32 ` Philippe Mathieu-Daudé
2020-05-13 20:58 ` John Snow
2020-05-13 20:58 ` John Snow
2020-05-12 10:32 ` [PATCH v4 2/6] scripts/qemu-gdb: Use Python 3 interpreter Philippe Mathieu-Daudé
2020-05-12 10:32 ` Philippe Mathieu-Daudé
2020-05-13 20:58 ` John Snow
2020-05-13 20:58 ` John Snow
2020-05-12 10:32 ` [PATCH v4 3/6] scripts/qmp: " Philippe Mathieu-Daudé
2020-05-12 10:32 ` Philippe Mathieu-Daudé
2020-05-13 20:59 ` John Snow
2020-05-13 20:59 ` John Snow
2020-05-12 10:32 ` [PATCH v4 4/6] scripts/kvm/vmxcap: Use Python 3 interpreter and add pseudo-main() Philippe Mathieu-Daudé
2020-05-12 10:32 ` Philippe Mathieu-Daudé
2020-05-12 11:35 ` Paolo Bonzini
2020-05-12 11:35 ` Paolo Bonzini
2020-05-13 21:00 ` John Snow
2020-05-13 21:00 ` John Snow
2020-05-12 10:32 ` [PATCH v4 5/6] scripts/modules/module_block: Use Python 3 interpreter & add pseudo-main Philippe Mathieu-Daudé
2020-05-12 10:32 ` Philippe Mathieu-Daudé
2020-05-13 21:04 ` John Snow
2020-05-13 21:04 ` John Snow
2020-05-12 10:32 ` [PATCH v4 6/6] tests/migration/guestperf: Use Python 3 interpreter Philippe Mathieu-Daudé
2020-05-12 10:32 ` Philippe Mathieu-Daudé
2020-05-13 21:08 ` John Snow
2020-05-13 21:08 ` John Snow
2020-05-12 11:16 ` Kevin Wolf [this message]
2020-05-12 11:16 ` [PATCH v4 0/6] scripts: More Python fixes Kevin Wolf
2020-05-29 9:40 ` Philippe Mathieu-Daudé
2020-05-29 9:40 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512111641.GJ5951@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.