From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/4] arm64: dts: qcom: msm8916: Add blsp_i2c5
Date: Tue, 12 May 2020 11:16:07 -0700 [thread overview]
Message-ID: <20200512181607.GI57962@builder.lan> (raw)
In-Reply-To: <20200426140642.204395-3-stephan@gerhold.net>
On Sun 26 Apr 07:06 PDT 2020, Stephan Gerhold wrote:
> MSM8916 has another I2C QUP controller that can be enabled on
> GPIO 18 and 19.
>
> Add blsp_i2c5 to msm8916.dtsi and disable it by default.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> Most MSM8916 smartphones/tablets have a touchscreen
> connected to blsp_i2c5.
> ---
> arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 24 ++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 15 ++++++++++++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> index b45fd12856ea..31886860766a 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> @@ -334,6 +334,30 @@ pinconf {
> };
> };
>
> + i2c5_default: i2c5_default {
> + pinmux {
> + function = "blsp_i2c5";
> + pins = "gpio18", "gpio19";
> + };
> + pinconf {
> + pins = "gpio18", "gpio19";
> + drive-strength = <2>;
> + bias-disable;
> + };
> + };
> +
> + i2c5_sleep: i2c5_sleep {
> + pinmux {
> + function = "gpio";
> + pins = "gpio18", "gpio19";
> + };
> + pinconf {
> + pins = "gpio18", "gpio19";
> + drive-strength = <2>;
> + bias-disable;
> + };
> + };
> +
> i2c6_default: i2c6_default {
> pinmux {
> function = "blsp_i2c6";
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 6ab7cabde370..57ab5573a2d2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -657,6 +657,21 @@ blsp_i2c4: i2c@78b8000 {
> status = "disabled";
> };
>
> + blsp_i2c5: i2c@78b9000 {
> + compatible = "qcom,i2c-qup-v2.2.1";
> + reg = <0x078b9000 0x500>;
> + interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc GCC_BLSP1_AHB_CLK>,
> + <&gcc GCC_BLSP1_QUP5_I2C_APPS_CLK>;
> + clock-names = "iface", "core";
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&i2c5_default>;
> + pinctrl-1 = <&i2c5_sleep>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> blsp_i2c6: i2c@78ba000 {
> compatible = "qcom,i2c-qup-v2.2.1";
> reg = <0x078ba000 0x500>;
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-12 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 14:06 [PATCH 0/4] Add touchscreen for msm8916-samsung-a5u Stephan Gerhold
2020-04-26 14:06 ` [PATCH 1/4] arm64: dts: qcom: msm8916: Add blsp_i2c1 Stephan Gerhold
2020-05-12 18:15 ` Bjorn Andersson
2020-04-26 14:06 ` [PATCH 2/4] arm64: dts: qcom: msm8916: Add blsp_i2c5 Stephan Gerhold
2020-05-12 18:16 ` Bjorn Andersson [this message]
2020-04-26 14:06 ` [PATCH 3/4] arm64: dts: qcom: msm8916-samsung-a2015: Add touchscreen regulator Stephan Gerhold
2020-05-12 18:29 ` Bjorn Andersson
2020-04-26 14:06 ` [PATCH 4/4] arm64: dts: qcom: msm8916-samsung-a5u: Add touchscreen Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512181607.GI57962@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.