Re: [PATCH 3/4] arm64: dts: qcom: msm8916-samsung-a2015: Add touchscreen regulator

[Bjorn Andersson <bjorn.andersson@linaro.org>]

On Sun 26 Apr 07:06 PDT 2020, Stephan Gerhold wrote:

> A3U and A5U both use an extra touchscreen LDO regulator
> that provides 3.3V for the touch screen controller.
> 
> Add it as fixed regulator to the common include.
> 
> Cc: Michael Srba <Michael.Srba@seznam.cz>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>  .../qcom/msm8916-samsung-a2015-common.dtsi    | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> index 43c5e0f882f1..67a286422a13 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> @@ -138,6 +138,19 @@ hall-sensor {
>  		};
>  	};
>  
> +	reg_vdd_tsp: regulator-vdd-tsp {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vdd_tsp";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +
> +		gpio = <&msmgpio 73 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&tsp_en_default>;
> +	};
> +
>  	i2c-muic {
>  		compatible = "i2c-gpio";
>  		sda-gpios = <&msmgpio 105 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> @@ -195,6 +208,18 @@ pinconf {
>  			bias-disable;
>  		};
>  	};
> +
> +	tsp_en_default: tsp_en_default {

Node names should not include '_', so this line should be
	tsp_en_default: tsp-en-default {

I fixed this up in both patch 3 and 4 and applied the series.

Thanks,
Bjorn

> +		pinmux {
> +			function = "gpio";
> +			pins = "gpio73";
> +		};
> +		pinconf {
> +			pins = "gpio73";
> +			drive-strength = <2>;
> +			bias-disable;
> +		};
> +	};
>  };
>  
>  &smd_rpm_regulators {
> -- 
> 2.26.2
>