From: Shawn Guo <shawnguo@kernel.org>
To: fugang.duan@nxp.com
Cc: aisheng.dong@nxp.com, devicetree@vger.kernel.org,
Anson.Huang@nxp.com, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
Date: Wed, 13 May 2020 16:49:34 +0800 [thread overview]
Message-ID: <20200513084933.GF26997@dragon> (raw)
In-Reply-To: <1588154654-13684-1-git-send-email-fugang.duan@nxp.com>
On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
> };
>
> fec: ethernet@30be0000 {
> - compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> + compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";
In this case, "fsl,imx8mq-fec" can be dropped?
Shawn
> reg = <0x30be0000 0x10000>;
> interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: fugang.duan@nxp.com
Cc: robh+dt@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, Anson.Huang@nxp.com,
devicetree@vger.kernel.org, aisheng.dong@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string
Date: Wed, 13 May 2020 16:49:34 +0800 [thread overview]
Message-ID: <20200513084933.GF26997@dragon> (raw)
In-Reply-To: <1588154654-13684-1-git-send-email-fugang.duan@nxp.com>
On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
> };
>
> fec: ethernet@30be0000 {
> - compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> + compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";
In this case, "fsl,imx8mq-fec" can be dropped?
Shawn
> reg = <0x30be0000 0x10000>;
> interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-13 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 10:04 [PATCH 1/1] arm64: dts: imx8mp: add "fsl, imx6sx-fec" compatible string fugang.duan
2020-04-29 10:04 ` [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" " fugang.duan
2020-04-29 10:13 ` Aisheng Dong
2020-04-29 10:13 ` Aisheng Dong
2020-05-13 8:49 ` Shawn Guo [this message]
2020-05-13 8:49 ` Shawn Guo
2020-05-13 8:58 ` [EXT] " Andy Duan
2020-05-13 8:58 ` Andy Duan
2020-05-17 14:14 ` Shawn Guo
2020-05-17 14:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513084933.GF26997@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.