From: Mark Brown <broonie@kernel.org>
To: Steve Lee <steves.lee.maxim@gmail.com>
Cc: jack.yu@realtek.com, alsa-devel@alsa-project.org,
ryan.lee.maxim@gmail.com, ckeepax@opensource.cirrus.com,
ryans.lee@maximintegrated.com, steves.lee@maximintegrated.com,
linux-kernel@vger.kernel.org, tiwai@suse.com, krzk@kernel.org,
lgirdwood@gmail.com, nuno.sa@analog.com, geert@linux-m68k.org,
dmurphy@ti.com, shumingf@realtek.com,
srinivas.kandagatla@linaro.org, rf@opensource.wolfsonmicro.com
Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver
Date: Wed, 13 May 2020 11:51:44 +0100 [thread overview]
Message-ID: <20200513105144.GC4803@sirena.org.uk> (raw)
In-Reply-To: <20200513074523.21086-1-steves.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
> Changes since V2:
> * Removed warn massage in max98390_dsm_calib_get func
> and add comment.
The problem isn't the warning, the problem is that you have an empty
operation. You should either implement the function (eg, by caching the
value written) or remove it and fix whatever problems you were running
into further up the stack when it's missing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Steve Lee <steves.lee.maxim@gmail.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
ckeepax@opensource.cirrus.com, geert@linux-m68k.org,
rf@opensource.wolfsonmicro.com, shumingf@realtek.com,
srinivas.kandagatla@linaro.org, krzk@kernel.org, dmurphy@ti.com,
jack.yu@realtek.com, nuno.sa@analog.com,
steves.lee@maximintegrated.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, ryan.lee.maxim@gmail.com,
ryans.lee@maximintegrated.com
Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver
Date: Wed, 13 May 2020 11:51:44 +0100 [thread overview]
Message-ID: <20200513105144.GC4803@sirena.org.uk> (raw)
In-Reply-To: <20200513074523.21086-1-steves.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
> Changes since V2:
> * Removed warn massage in max98390_dsm_calib_get func
> and add comment.
The problem isn't the warning, the problem is that you have an empty
operation. You should either implement the function (eg, by caching the
value written) or remove it and fix whatever problems you were running
into further up the stack when it's missing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-13 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 7:45 [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver Steve Lee
2020-05-13 10:51 ` Mark Brown [this message]
2020-05-13 10:51 ` Mark Brown
2020-05-13 11:58 ` Tzung-Bi Shih
2020-05-13 11:58 ` Tzung-Bi Shih
2020-05-14 10:17 ` Mark Brown
2020-05-14 10:17 ` Mark Brown
2020-05-14 12:14 ` Steve Lee
2020-05-14 12:14 ` Steve Lee
2020-05-14 7:31 ` Tzung-Bi Shih
2020-05-14 7:31 ` Tzung-Bi Shih
2020-05-14 10:16 ` Mark Brown
2020-05-14 10:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513105144.GC4803@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dmurphy@ti.com \
--cc=geert@linux-m68k.org \
--cc=jack.yu@realtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steves.lee.maxim@gmail.com \
--cc=steves.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.