From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: devicetree@vger.kernel.org, geert+renesas@glider.be,
xuwei5@hisilicon.com, robh+dt@kernel.org, kernel@collabora.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 DT binding
Date: Thu, 14 May 2020 04:37:23 +0300 [thread overview]
Message-ID: <20200514013723.GD7425@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200511110611.3142-5-ricardo.canuelo@collabora.com>
Hi Ricardo,
Thank you for the patch.
On Mon, May 11, 2020 at 01:06:09PM +0200, Ricardo Cañuelo wrote:
> hi3660-hikey960.dts:
> Define a 'ports' node for 'adv7533: adv7533@39' and the
> 'adi,dsi-lanes' property to make it compliant with the adi,adv7533 DT
> binding.
>
> This fills the requirements to meet the binding requirements,
> remote endpoints are not defined.
>
> hi6220-hikey.dts:
> Change property name s/pd-gpio/pd-gpios, gpio properties should be
> plural. This is just a cosmetic change.
>
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 11 +++++++++++
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 2 +-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> index e035cf195b19..8c4bfbaf3a80 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -530,6 +530,17 @@
> status = "ok";
> compatible = "adi,adv7533";
> reg = <0x39>;
> + adi,dsi-lanes = <4>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + };
> + port@1 {
> + reg = <1>;
> + };
> + };
> };
> };
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index c14205cd6bf5..3e47150c05ec 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -516,7 +516,7 @@
> reg = <0x39>;
> interrupt-parent = <&gpio1>;
> interrupts = <1 2>;
> - pd-gpio = <&gpio0 4 0>;
> + pd-gpios = <&gpio0 4 0>;
> adi,dsi-lanes = <4>;
> #sound-dai-cells = <0>;
>
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, geert+renesas@glider.be,
robh+dt@kernel.org, xuwei5@hisilicon.com
Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 DT binding
Date: Thu, 14 May 2020 04:37:23 +0300 [thread overview]
Message-ID: <20200514013723.GD7425@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200511110611.3142-5-ricardo.canuelo@collabora.com>
Hi Ricardo,
Thank you for the patch.
On Mon, May 11, 2020 at 01:06:09PM +0200, Ricardo Cañuelo wrote:
> hi3660-hikey960.dts:
> Define a 'ports' node for 'adv7533: adv7533@39' and the
> 'adi,dsi-lanes' property to make it compliant with the adi,adv7533 DT
> binding.
>
> This fills the requirements to meet the binding requirements,
> remote endpoints are not defined.
>
> hi6220-hikey.dts:
> Change property name s/pd-gpio/pd-gpios, gpio properties should be
> plural. This is just a cosmetic change.
>
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 11 +++++++++++
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 2 +-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> index e035cf195b19..8c4bfbaf3a80 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -530,6 +530,17 @@
> status = "ok";
> compatible = "adi,adv7533";
> reg = <0x39>;
> + adi,dsi-lanes = <4>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + };
> + port@1 {
> + reg = <1>;
> + };
> + };
> };
> };
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index c14205cd6bf5..3e47150c05ec 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -516,7 +516,7 @@
> reg = <0x39>;
> interrupt-parent = <&gpio1>;
> interrupts = <1 2>;
> - pd-gpio = <&gpio0 4 0>;
> + pd-gpios = <&gpio0 4 0>;
> adi,dsi-lanes = <4>;
> #sound-dai-cells = <0>;
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-05-14 1:37 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 11:06 [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings to yaml Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 11:06 ` [PATCH v2 1/6] arm64: dts: renesas: make hdmi encoder nodes compliant with DT bindings Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 11:51 ` Geert Uytterhoeven
2020-05-11 11:51 ` Geert Uytterhoeven
2020-05-14 1:33 ` Laurent Pinchart
2020-05-14 1:33 ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 2/6] ARM: " Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 11:51 ` Geert Uytterhoeven
2020-05-11 11:51 ` Geert Uytterhoeven
2020-05-14 1:34 ` Laurent Pinchart
2020-05-14 1:34 ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39 Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 12:24 ` Ezequiel Garcia
2020-05-11 12:24 ` Ezequiel Garcia
2020-05-11 12:52 ` Michal Simek
2020-05-11 12:52 ` Michal Simek
2020-05-14 1:36 ` Laurent Pinchart
2020-05-14 1:36 ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding Ricardo Cañuelo
2020-05-11 11:06 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 " Ricardo Cañuelo
2020-05-14 1:37 ` Laurent Pinchart [this message]
2020-05-14 1:37 ` Laurent Pinchart
2020-08-04 20:57 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " John Stultz
2020-08-04 20:57 ` John Stultz
2020-08-04 21:24 ` John Stultz
2020-08-04 21:24 ` John Stultz
2020-05-11 11:06 ` [PATCH v2 5/6] ARM: dts: iwg20d-q7-dbcm-ca: remove unneeded properties in hdmi@39 Ricardo Cañuelo
2020-05-11 11:06 ` Ricardo Cañuelo
2020-05-11 11:52 ` Geert Uytterhoeven
2020-05-11 11:52 ` Geert Uytterhoeven
2020-05-14 1:37 ` Laurent Pinchart
2020-05-14 1:37 ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: convert to yaml Ricardo Cañuelo
2020-05-11 11:06 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Ricardo Cañuelo
2020-05-14 1:54 ` Laurent Pinchart
2020-05-14 1:54 ` Laurent Pinchart
2020-05-14 9:36 ` Ricardo Cañuelo
2020-05-14 9:36 ` Ricardo Cañuelo
2020-05-14 15:22 ` Laurent Pinchart
2020-05-14 15:22 ` Laurent Pinchart
2020-05-18 21:27 ` Rob Herring
2020-05-18 21:27 ` Rob Herring
2020-05-25 7:43 ` Ricardo Cañuelo
2020-05-25 7:43 ` Ricardo Cañuelo
2020-05-26 1:44 ` Laurent Pinchart
2020-05-26 1:44 ` Laurent Pinchart
2020-05-26 7:03 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 7:03 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Geert Uytterhoeven
2020-05-26 10:11 ` Laurent Pinchart
2020-05-26 10:11 ` Laurent Pinchart
2020-05-26 10:39 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-26 10:39 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Geert Uytterhoeven
2020-05-26 19:45 ` Ezequiel Garcia
2020-05-26 19:45 ` Ezequiel Garcia
2020-05-27 17:29 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Rob Herring
2020-05-27 17:29 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Rob Herring
2020-05-27 18:18 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2020-05-27 18:18 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: " Geert Uytterhoeven
2020-05-28 6:36 ` Ricardo Cañuelo
2020-05-28 6:36 ` Ricardo Cañuelo
2020-05-11 11:55 ` [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings " Geert Uytterhoeven
2020-05-11 11:55 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514013723.GD7425@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ricardo.canuelo@collabora.com \
--cc=robh+dt@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.