From: Mark Brown <broonie@kernel.org>
To: Ajit Pandey <ajitp@codeaurora.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, plai@codeaurora.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org
Subject: Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
Date: Thu, 14 May 2020 17:48:28 +0100 [thread overview]
Message-ID: <20200514164828.GL5127@sirena.org.uk> (raw)
In-Reply-To: <1589474298-29437-6-git-send-email-ajitp@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote:
> +#define MI2S_PRIMARY 0
> +#define MI2S_SECONDARY 1
> +
> +#define LPASS_MCLK0 0
These look like they could use namespacing. Is primary/secondary
perhaps something that could be a boolean property?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-14 16:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <“1586592171-31644-1-git-send-email-ajitp@codeaurora.org”>
2020-05-14 16:38 ` [PATCH v2 0/7] ASoC: QCOM: Add support for SC7180 lpass variant Ajit Pandey
2020-05-14 16:38 ` [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding Ajit Pandey
2020-05-14 16:44 ` Mark Brown
2020-05-14 16:38 ` [PATCH v2 2/7] ASoC: qcom: Add common array to initialize soc based core clocks Ajit Pandey
2020-05-14 16:38 ` Ajit Pandey
2020-05-14 16:45 ` Mark Brown
2020-05-14 16:38 ` [PATCH v2 4/7] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers Ajit Pandey
2020-05-14 16:38 ` [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header Ajit Pandey
2020-05-14 16:48 ` Mark Brown [this message]
2020-05-14 16:38 ` [PATCH v2 6/7] device-tree: bindings: sound: lpass-cpu: Add new compatible soc Ajit Pandey
2020-05-14 16:38 ` [PATCH v2 7/7] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Ajit Pandey
2020-05-16 18:14 [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header Ajit Pandey
2020-05-16 18:14 ` Ajit Pandey
-- strict thread matches above, loose matches on Subject: below --
2020-05-18 9:22 Srinivas Kandagatla
2020-05-18 9:22 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514164828.GL5127@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.