All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Brent Lu <brent.lu@intel.com>
Cc: alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>,
	Baolin Wang <baolin.wang@linaro.org>,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	Richard Fontana <rfontana@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	paulhsia <paulhsia@chromium.org>
Subject: Re: [PATCH] ALSA: pcm: fix incorrect hw_base increase
Date: Fri, 15 May 2020 09:04:46 +0200	[thread overview]
Message-ID: <20200515070446.GA1226131@kroah.com> (raw)
In-Reply-To: <1589515779-20987-1-git-send-email-brent.lu@intel.com>

On Fri, May 15, 2020 at 12:09:39PM +0800, Brent Lu wrote:
> The hw_base will be increased by runtime->buffer_size frames
> unconditionally if the runtime->status->hw_ptr is not updated for over
> half of buffer time. As the hw_base increases, so does the
> runtime->status->hw_ptr which could lead to invalid return value when
> user space program calls snd_pcm_avail() function.
> 
> By updating runtime->hw_ptr_jiffies each time the HWSYNC is called,
> the hw_base will keep the same when buffer stall happens, so does the
> hw_ptr.
> 
> Signed-off-by: Brent Lu <brent.lu@intel.com>
> ---
>  sound/core/pcm_lib.c | 1 +
>  1 file changed, 1 insertion(+)

Is this a bugfix needed for older kernels as well?  When did this issue
show up?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Brent Lu <brent.lu@intel.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Richard Fontana <rfontana@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	paulhsia <paulhsia@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: fix incorrect hw_base increase
Date: Fri, 15 May 2020 09:04:46 +0200	[thread overview]
Message-ID: <20200515070446.GA1226131@kroah.com> (raw)
In-Reply-To: <1589515779-20987-1-git-send-email-brent.lu@intel.com>

On Fri, May 15, 2020 at 12:09:39PM +0800, Brent Lu wrote:
> The hw_base will be increased by runtime->buffer_size frames
> unconditionally if the runtime->status->hw_ptr is not updated for over
> half of buffer time. As the hw_base increases, so does the
> runtime->status->hw_ptr which could lead to invalid return value when
> user space program calls snd_pcm_avail() function.
> 
> By updating runtime->hw_ptr_jiffies each time the HWSYNC is called,
> the hw_base will keep the same when buffer stall happens, so does the
> hw_ptr.
> 
> Signed-off-by: Brent Lu <brent.lu@intel.com>
> ---
>  sound/core/pcm_lib.c | 1 +
>  1 file changed, 1 insertion(+)

Is this a bugfix needed for older kernels as well?  When did this issue
show up?

thanks,

greg k-h

  reply	other threads:[~2020-05-15  7:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15  4:09 [PATCH] ALSA: pcm: fix incorrect hw_base increase Brent Lu
2020-05-15  4:09 ` Brent Lu
2020-05-15  7:04 ` Greg Kroah-Hartman [this message]
2020-05-15  7:04   ` Greg Kroah-Hartman
2020-05-15  9:04   ` Lu, Brent
2020-05-15  9:04     ` Lu, Brent
2020-05-15  9:30     ` Jaroslav Kysela
2020-05-15  9:30       ` Jaroslav Kysela
2020-05-15 10:39       ` Takashi Iwai
2020-05-15 10:39         ` Takashi Iwai
2020-05-15 12:01         ` Jaroslav Kysela
2020-05-15 12:01           ` Jaroslav Kysela
2020-05-18  4:38           ` Lu, Brent
2020-05-18  4:38             ` Lu, Brent
2020-05-15  7:21 ` Takashi Iwai
2020-05-15  7:21   ` Takashi Iwai
2020-05-15  9:36   ` Lu, Brent
2020-05-15  9:36     ` Lu, Brent
2020-05-15 10:40     ` Takashi Iwai
2020-05-15 10:40       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515070446.GA1226131@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=baolin.wang@linaro.org \
    --cc=brent.lu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulhsia@chromium.org \
    --cc=rfontana@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.