* [LTP] [PATCH 1/1] rpc-tirpc: Fix deprecated glibc detection
@ 2020-05-14 19:30 Petr Vorel
2020-05-15 10:53 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2020-05-14 19:30 UTC (permalink / raw)
To: ltp
It's not enough to check for RPC headers. These can belong to libtirpc 64bit, which
is not enough when compiling 32bit LTP without 32bit libtirpc.
Fixes: 60b20c428 ("rpc: Enable and fix build basic RPC tests with glibc SunRPC")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
m4/ltp-tirpc.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ltp-tirpc.m4 b/m4/ltp-tirpc.m4
index 639e1e886..4d9701469 100644
--- a/m4/ltp-tirpc.m4
+++ b/m4/ltp-tirpc.m4
@@ -17,9 +17,9 @@ AC_DEFUN([LTP_CHECK_TIRPC], [
dnl rpc_broadcast() instead of clnt_broadcast()), but glibc implementation
dnl does not have the new ones. We could either provide the deprecated
dnl functions (copy from libtirpc src/rpc_soc.c) or drop glibc tests.
- AC_CHECK_HEADERS([rpc/rpc.h], [have_rpc_headers=yes])
+ AC_CHECK_FUNCS([xdr_char clnttcp_create], [have_rpc_glibc=yes])
- if test "x$have_libtirpc" = "xyes" -o "x$have_rpc_headers" = "xyes"; then
+ if test "x$have_libtirpc" = "xyes" -o "x$have_rpc_glibc" = "xyes"; then
AC_SUBST(HAVE_RPC, 1)
fi
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [LTP] [PATCH 1/1] rpc-tirpc: Fix deprecated glibc detection
2020-05-14 19:30 [LTP] [PATCH 1/1] rpc-tirpc: Fix deprecated glibc detection Petr Vorel
@ 2020-05-15 10:53 ` Cyril Hrubis
2020-05-15 11:00 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2020-05-15 10:53 UTC (permalink / raw)
To: ltp
Hi!
> It's not enough to check for RPC headers. These can belong to libtirpc 64bit, which
> is not enough when compiling 32bit LTP without 32bit libtirpc.
>
> Fixes: 60b20c428 ("rpc: Enable and fix build basic RPC tests with glibc SunRPC")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> m4/ltp-tirpc.m4 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/m4/ltp-tirpc.m4 b/m4/ltp-tirpc.m4
> index 639e1e886..4d9701469 100644
> --- a/m4/ltp-tirpc.m4
> +++ b/m4/ltp-tirpc.m4
> @@ -17,9 +17,9 @@ AC_DEFUN([LTP_CHECK_TIRPC], [
> dnl rpc_broadcast() instead of clnt_broadcast()), but glibc implementation
> dnl does not have the new ones. We could either provide the deprecated
> dnl functions (copy from libtirpc src/rpc_soc.c) or drop glibc tests.
> - AC_CHECK_HEADERS([rpc/rpc.h], [have_rpc_headers=yes])
> + AC_CHECK_FUNCS([xdr_char clnttcp_create], [have_rpc_glibc=yes])
>
> - if test "x$have_libtirpc" = "xyes" -o "x$have_rpc_headers" = "xyes"; then
> + if test "x$have_libtirpc" = "xyes" -o "x$have_rpc_glibc" = "xyes"; then
> AC_SUBST(HAVE_RPC, 1)
> fi
Looks good to me, if you have tested this throughly I would like to have
it in the release.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-14 19:30 [LTP] [PATCH 1/1] rpc-tirpc: Fix deprecated glibc detection Petr Vorel
2020-05-15 10:53 ` Cyril Hrubis
2020-05-15 11:00 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.