From: Joerg Roedel <joro@8bytes.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: alex.williamson@redhat.com, ashok.raj@intel.com,
linux-pci@vger.kernel.org, robin.murphy@arm.com,
iommu@lists.linux-foundation.org, bhelgaas@google.com,
will@kernel.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] iommu/amd: Use pci_ats_supported()
Date: Fri, 15 May 2020 14:21:04 +0200 [thread overview]
Message-ID: <20200515122104.GV18353@8bytes.org> (raw)
In-Reply-To: <20200515121124.GA784024@myrica>
On Fri, May 15, 2020 at 02:11:24PM +0200, Jean-Philippe Brucker wrote:
> On Fri, May 15, 2020 at 02:01:50PM +0200, Joerg Roedel wrote:
> > Hmm, but per patch 1, pci_ats_supported() does not check
> > pci_ats_disabled(), or do I miss something?
>
> The commit message isn't clear. pci_ats_init() sets dev->ats_cap only if
> !pci_ats_disabled(), so checking dev->ats_cap in pci_ats_supported()
> takes pci_ats_disabled() into account.
Right, so the patch is fine:
Reviewed-by: Joerg Roedel <jroedel@suse.de>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, bhelgaas@google.com,
will@kernel.org, robin.murphy@arm.com, dwmw2@infradead.org,
baolu.lu@linux.intel.com, ashok.raj@intel.com,
alex.williamson@redhat.com
Subject: Re: [PATCH 2/4] iommu/amd: Use pci_ats_supported()
Date: Fri, 15 May 2020 14:21:04 +0200 [thread overview]
Message-ID: <20200515122104.GV18353@8bytes.org> (raw)
In-Reply-To: <20200515121124.GA784024@myrica>
On Fri, May 15, 2020 at 02:11:24PM +0200, Jean-Philippe Brucker wrote:
> On Fri, May 15, 2020 at 02:01:50PM +0200, Joerg Roedel wrote:
> > Hmm, but per patch 1, pci_ats_supported() does not check
> > pci_ats_disabled(), or do I miss something?
>
> The commit message isn't clear. pci_ats_init() sets dev->ats_cap only if
> !pci_ats_disabled(), so checking dev->ats_cap in pci_ats_supported()
> takes pci_ats_disabled() into account.
Right, so the patch is fine:
Reviewed-by: Joerg Roedel <jroedel@suse.de>
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: alex.williamson@redhat.com, ashok.raj@intel.com,
linux-pci@vger.kernel.org, robin.murphy@arm.com,
iommu@lists.linux-foundation.org, bhelgaas@google.com,
will@kernel.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com
Subject: Re: [PATCH 2/4] iommu/amd: Use pci_ats_supported()
Date: Fri, 15 May 2020 14:21:04 +0200 [thread overview]
Message-ID: <20200515122104.GV18353@8bytes.org> (raw)
In-Reply-To: <20200515121124.GA784024@myrica>
On Fri, May 15, 2020 at 02:11:24PM +0200, Jean-Philippe Brucker wrote:
> On Fri, May 15, 2020 at 02:01:50PM +0200, Joerg Roedel wrote:
> > Hmm, but per patch 1, pci_ats_supported() does not check
> > pci_ats_disabled(), or do I miss something?
>
> The commit message isn't clear. pci_ats_init() sets dev->ats_cap only if
> !pci_ats_disabled(), so checking dev->ats_cap in pci_ats_supported()
> takes pci_ats_disabled() into account.
Right, so the patch is fine:
Reviewed-by: Joerg Roedel <jroedel@suse.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-15 12:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 10:43 [PATCH 0/4] PCI, iommu: Factor 'untrusted' check for ATS enablement Jean-Philippe Brucker
2020-05-15 10:43 ` Jean-Philippe Brucker
2020-05-15 10:43 ` Jean-Philippe Brucker
2020-05-15 10:43 ` [PATCH 1/4] PCI/ATS: Only enable ATS for trusted devices Jean-Philippe Brucker
2020-05-15 10:43 ` Jean-Philippe Brucker
2020-05-15 10:43 ` Jean-Philippe Brucker
2020-05-15 11:57 ` Joerg Roedel
2020-05-15 11:57 ` Joerg Roedel
2020-05-15 11:57 ` Joerg Roedel
2020-05-15 21:18 ` Bjorn Helgaas
2020-05-15 21:18 ` Bjorn Helgaas
2020-05-15 21:18 ` Bjorn Helgaas
2020-05-15 10:44 ` [PATCH 2/4] iommu/amd: Use pci_ats_supported() Jean-Philippe Brucker
2020-05-15 10:44 ` Jean-Philippe Brucker
2020-05-15 10:44 ` Jean-Philippe Brucker
2020-05-15 12:01 ` Joerg Roedel
2020-05-15 12:01 ` Joerg Roedel
2020-05-15 12:01 ` Joerg Roedel
2020-05-15 12:11 ` Jean-Philippe Brucker
2020-05-15 12:11 ` Jean-Philippe Brucker
2020-05-15 12:11 ` Jean-Philippe Brucker
2020-05-15 12:21 ` Joerg Roedel [this message]
2020-05-15 12:21 ` Joerg Roedel
2020-05-15 12:21 ` Joerg Roedel
2020-05-15 10:44 ` [PATCH 3/4] iommu/arm-smmu-v3: " Jean-Philippe Brucker
2020-05-15 10:44 ` Jean-Philippe Brucker
2020-05-15 10:44 ` Jean-Philippe Brucker
2020-05-18 15:37 ` Will Deacon
2020-05-18 15:37 ` Will Deacon
2020-05-18 15:37 ` Will Deacon
2020-05-15 10:44 ` [PATCH 4/4] iommu/vt-d: " Jean-Philippe Brucker
2020-05-15 10:44 ` Jean-Philippe Brucker
2020-05-15 10:44 ` Jean-Philippe Brucker
2020-05-15 15:43 ` [PATCH 0/4] PCI, iommu: Factor 'untrusted' check for ATS enablement Christoph Hellwig
2020-05-15 15:43 ` Christoph Hellwig
2020-05-15 15:43 ` Christoph Hellwig
2020-05-15 17:19 ` Raj, Ashok
2020-05-15 17:19 ` Raj, Ashok
2020-05-15 17:19 ` Raj, Ashok
2020-05-15 17:21 ` Will Deacon
2020-05-15 17:21 ` Will Deacon
2020-05-15 17:21 ` Will Deacon
2020-05-18 15:47 ` David Woodhouse
2020-05-18 15:47 ` David Woodhouse
2020-05-18 15:47 ` David Woodhouse
2020-05-18 16:29 ` Raj, Ashok
2020-05-18 16:29 ` Raj, Ashok
2020-05-18 16:29 ` Raj, Ashok
2020-05-18 16:36 ` Jean-Philippe Brucker
2020-05-18 16:36 ` Jean-Philippe Brucker
2020-05-18 16:36 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515122104.GV18353@8bytes.org \
--to=joro@8bytes.org \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.