Re: [PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete
Date: Mon, 18 May 2020 07:11:04 +0800	[thread overview]
Message-ID: <202005180732.zAXeRPjV%lkp@intel.com> (raw)
In-Reply-To: <20200517220524.4036334-1-emil.l.velikov@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4748 bytes --]

Hi Emil,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on tegra-drm/drm/tegra/for-next linus/master v5.7-rc5 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Emil-Velikov/fbdev-annotate-rivafb-nvidiafb-as-obsolete/20200518-060957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/video/fbdev/riva/fbdev.c:2167:8: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^
1 warning generated.
--
>> drivers/video/fbdev/nvidia/nvidia.c:1519:8: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^
1 warning generated.

vim +2167 drivers/video/fbdev/riva/fbdev.c

^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2152  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2153  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2154  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2155  /* ------------------------------------------------------------------------- *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2156   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2157   * modularization
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2158   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2159   * ------------------------------------------------------------------------- */
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2160  
48c68c4f1b5424 drivers/video/riva/fbdev.c       Greg Kroah-Hartman 2012-12-21  2161  static int rivafb_init(void)
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2162  {
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2163  	pr_warn("Legacy rivafb framebuffer driver will be removed in 2022\n"
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2164  		"Please switch to nouveau DRM driver\n");
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2165  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2166  #ifndef MODULE
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16 @2167  	char *option = NULL;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2168  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2169  	if (fb_get_options("rivafb", &option))
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2170  		return -ENODEV;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2171  	rivafb_setup(option);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2172  #endif
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2173  	return pci_register_driver(&rivafb_driver);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2174  }
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2175  

:::::: The code at line 2167 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73535 bytes --]