From: Jesper Dangaard Brouer <brouer@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [jkirsher-next-queue:dev-queue 7/115] drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2271:15: error: redefinition of 'truesize'
Date: Mon, 18 May 2020 10:05:02 +0200 [thread overview]
Message-ID: <20200518100502.71f0a692@carbon> (raw)
In-Reply-To: <202005160901.jprqRj3x%lkp@intel.com>
Hi Jeff,
This bug is not in net-next. I do remember the issue, but I think it
was fixed up before the patch got applied. Maybe you applied an old
version of the patch to your tree?
--Jesper
On Sat, 16 May 2020 09:52:03 +0800
kbuild test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
> head: 1ae51690bc317eb011c6fcc8f5549b151b347167
> commit: cc703d543a3b97138318bfe7d3c86cbf78136395 [7/115] ixgbe: fix XDP redirect on archs with PAGE_SIZE above 4K
> config: powerpc-defconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout cc703d543a3b97138318bfe7d3c86cbf78136395
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_rx_buffer_flip':
> >> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2271:15: error: redefinition of 'truesize'
> 2271 | unsigned int truesize = ring_uses_build_skb(rx_ring) ?
> | ^~~~~~~~
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2267:15: note: previous definition of 'truesize' was here
> 2267 | unsigned int truesize = ixgbe_rx_frame_truesize(rx_ring, size);
> | ^~~~~~~~
>
> vim +/truesize +2271 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>
> 2262
> 2263 static void ixgbe_rx_buffer_flip(struct ixgbe_ring *rx_ring,
> 2264 struct ixgbe_rx_buffer *rx_buffer,
> 2265 unsigned int size)
> 2266 {
> 2267 unsigned int truesize = ixgbe_rx_frame_truesize(rx_ring, size);
> 2268 #if (PAGE_SIZE < 8192)
> 2269 rx_buffer->page_offset ^= truesize;
> 2270 #else
> > 2271 unsigned int truesize = ring_uses_build_skb(rx_ring) ?
> 2272 SKB_DATA_ALIGN(IXGBE_SKB_PAD + size) +
> 2273 SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) :
> 2274 SKB_DATA_ALIGN(size);
> 2275
> 2276 rx_buffer->page_offset += truesize;
> 2277 #endif
> 2278 }
> 2279
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all at lists.01.org
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [jkirsher-next-queue:dev-queue 7/115] drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2271:15: error: redefinition of 'truesize'
Date: Mon, 18 May 2020 10:05:02 +0200 [thread overview]
Message-ID: <20200518100502.71f0a692@carbon> (raw)
In-Reply-To: <202005160901.jprqRj3x%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2714 bytes --]
Hi Jeff,
This bug is not in net-next. I do remember the issue, but I think it
was fixed up before the patch got applied. Maybe you applied an old
version of the patch to your tree?
--Jesper
On Sat, 16 May 2020 09:52:03 +0800
kbuild test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
> head: 1ae51690bc317eb011c6fcc8f5549b151b347167
> commit: cc703d543a3b97138318bfe7d3c86cbf78136395 [7/115] ixgbe: fix XDP redirect on archs with PAGE_SIZE above 4K
> config: powerpc-defconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout cc703d543a3b97138318bfe7d3c86cbf78136395
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_rx_buffer_flip':
> >> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2271:15: error: redefinition of 'truesize'
> 2271 | unsigned int truesize = ring_uses_build_skb(rx_ring) ?
> | ^~~~~~~~
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2267:15: note: previous definition of 'truesize' was here
> 2267 | unsigned int truesize = ixgbe_rx_frame_truesize(rx_ring, size);
> | ^~~~~~~~
>
> vim +/truesize +2271 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>
> 2262
> 2263 static void ixgbe_rx_buffer_flip(struct ixgbe_ring *rx_ring,
> 2264 struct ixgbe_rx_buffer *rx_buffer,
> 2265 unsigned int size)
> 2266 {
> 2267 unsigned int truesize = ixgbe_rx_frame_truesize(rx_ring, size);
> 2268 #if (PAGE_SIZE < 8192)
> 2269 rx_buffer->page_offset ^= truesize;
> 2270 #else
> > 2271 unsigned int truesize = ring_uses_build_skb(rx_ring) ?
> 2272 SKB_DATA_ALIGN(IXGBE_SKB_PAD + size) +
> 2273 SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) :
> 2274 SKB_DATA_ALIGN(size);
> 2275
> 2276 rx_buffer->page_offset += truesize;
> 2277 #endif
> 2278 }
> 2279
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-05-18 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 1:52 [Intel-wired-lan] [jkirsher-next-queue:dev-queue 7/115] drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2271:15: error: redefinition of 'truesize' kbuild test robot
2020-05-16 1:52 ` kbuild test robot
2020-05-18 8:05 ` Jesper Dangaard Brouer [this message]
2020-05-18 8:05 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518100502.71f0a692@carbon \
--to=brouer@redhat.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.