* [PATCH] drm/etnaviv: Fix a leak in submit_pin_objects()
@ 2020-05-18 11:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-05-18 11:29 UTC (permalink / raw)
To: Lucas Stach
Cc: David Airlie, Guido Günther, kernel-janitors, etnaviv,
dri-devel, Russell King
If the mapping address is wrong then we have to release the reference to
it before returning -EINVAL.
Fixes: 088880ddc0b2 ("drm/etnaviv: implement softpin")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
From static analysis. Untested.
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
index 3b0afa156d92..54def341c1db 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
@@ -238,8 +238,10 @@ static int submit_pin_objects(struct etnaviv_gem_submit *submit)
}
if ((submit->flags & ETNA_SUBMIT_SOFTPIN) &&
- submit->bos[i].va != mapping->iova)
+ submit->bos[i].va != mapping->iova) {
+ etnaviv_gem_mapping_unreference(mapping);
return -EINVAL;
+ }
atomic_inc(&etnaviv_obj->gpu_active);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] drm/etnaviv: Fix a leak in submit_pin_objects()
@ 2020-05-18 11:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-05-18 11:29 UTC (permalink / raw)
To: Lucas Stach
Cc: David Airlie, Guido Günther, kernel-janitors, etnaviv,
dri-devel, Russell King
If the mapping address is wrong then we have to release the reference to
it before returning -EINVAL.
Fixes: 088880ddc0b2 ("drm/etnaviv: implement softpin")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
From static analysis. Untested.
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
index 3b0afa156d92..54def341c1db 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
@@ -238,8 +238,10 @@ static int submit_pin_objects(struct etnaviv_gem_submit *submit)
}
if ((submit->flags & ETNA_SUBMIT_SOFTPIN) &&
- submit->bos[i].va != mapping->iova)
+ submit->bos[i].va != mapping->iova) {
+ etnaviv_gem_mapping_unreference(mapping);
return -EINVAL;
+ }
atomic_inc(&etnaviv_obj->gpu_active);
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/etnaviv: Fix a leak in submit_pin_objects()
2020-05-18 11:29 ` Dan Carpenter
@ 2020-05-19 10:49 ` Lucas Stach
-1 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2020-05-19 10:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Guido Günther, kernel-janitors, etnaviv,
dri-devel, Russell King
Am Montag, den 18.05.2020, 14:29 +0300 schrieb Dan Carpenter:
> If the mapping address is wrong then we have to release the reference to
> it before returning -EINVAL.
>
> Fixes: 088880ddc0b2 ("drm/etnaviv: implement softpin")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to etnaviv/fixes.
Regards,
Lucas
> ---
> From static analysis. Untested.
>
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> index 3b0afa156d92..54def341c1db 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> @@ -238,8 +238,10 @@ static int submit_pin_objects(struct etnaviv_gem_submit *submit)
> }
>
> if ((submit->flags & ETNA_SUBMIT_SOFTPIN) &&
> - submit->bos[i].va != mapping->iova)
> + submit->bos[i].va != mapping->iova) {
> + etnaviv_gem_mapping_unreference(mapping);
> return -EINVAL;
> + }
>
> atomic_inc(&etnaviv_obj->gpu_active);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/etnaviv: Fix a leak in submit_pin_objects()
@ 2020-05-19 10:49 ` Lucas Stach
0 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2020-05-19 10:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Guido Günther, kernel-janitors, etnaviv,
dri-devel, Russell King
Am Montag, den 18.05.2020, 14:29 +0300 schrieb Dan Carpenter:
> If the mapping address is wrong then we have to release the reference to
> it before returning -EINVAL.
>
> Fixes: 088880ddc0b2 ("drm/etnaviv: implement softpin")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to etnaviv/fixes.
Regards,
Lucas
> ---
> From static analysis. Untested.
>
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> index 3b0afa156d92..54def341c1db 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> @@ -238,8 +238,10 @@ static int submit_pin_objects(struct etnaviv_gem_submit *submit)
> }
>
> if ((submit->flags & ETNA_SUBMIT_SOFTPIN) &&
> - submit->bos[i].va != mapping->iova)
> + submit->bos[i].va != mapping->iova) {
> + etnaviv_gem_mapping_unreference(mapping);
> return -EINVAL;
> + }
>
> atomic_inc(&etnaviv_obj->gpu_active);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-19 10:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-18 11:29 [PATCH] drm/etnaviv: Fix a leak in submit_pin_objects() Dan Carpenter
2020-05-18 11:29 ` Dan Carpenter
2020-05-19 10:49 ` Lucas Stach
2020-05-19 10:49 ` Lucas Stach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.