From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, Palmer Dabbelt <palmer@dabbelt.com>,
Cornelia Huck <cohuck@redhat.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,
Richard Henderson <rth@twiddle.net>,
Paolo Bonzini <pbonzini@redhat.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled
Date: Mon, 18 May 2020 13:14:34 +0100 [thread overview]
Message-ID: <20200518121434.GA2787@work-vm> (raw)
In-Reply-To: <20200504152922.21365-2-philmd@redhat.com>
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Do not build the virtiofsd helper when configured with
> --disable-system.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Yeh that seems reasonable; although virtiofsd is self-contained enough
that perhaps it should be unrelated to whether you're building that.
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 34275f57c9..e46b6ef5d4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -345,7 +345,7 @@ HELPERS-y += vhost-user-gpu$(EXESUF)
> vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
> endif
>
> -ifeq ($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyy)
> +ifeq ($(CONFIG_SOFTMMU)$(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyyy)
> HELPERS-y += virtiofsd$(EXESUF)
> vhost-user-json-y += tools/virtiofsd/50-qemu-virtiofsd.json
> endif
> --
> 2.21.3
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Alistair Francis <Alistair.Francis@wdc.com>,
qemu-riscv@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
David Hildenbrand <david@redhat.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Palmer Dabbelt <palmer@dabbelt.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled
Date: Mon, 18 May 2020 13:14:34 +0100 [thread overview]
Message-ID: <20200518121434.GA2787@work-vm> (raw)
In-Reply-To: <20200504152922.21365-2-philmd@redhat.com>
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Do not build the virtiofsd helper when configured with
> --disable-system.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Yeh that seems reasonable; although virtiofsd is self-contained enough
that perhaps it should be unrelated to whether you're building that.
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 34275f57c9..e46b6ef5d4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -345,7 +345,7 @@ HELPERS-y += vhost-user-gpu$(EXESUF)
> vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
> endif
>
> -ifeq ($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyy)
> +ifeq ($(CONFIG_SOFTMMU)$(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyyy)
> HELPERS-y += virtiofsd$(EXESUF)
> vhost-user-json-y += tools/virtiofsd/50-qemu-virtiofsd.json
> endif
> --
> 2.21.3
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-05-18 12:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:29 [PATCH v3 00/12] user-mode: Prune build dependencies (part 1) Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-18 12:14 ` Dr. David Alan Gilbert [this message]
2020-05-18 12:14 ` Dr. David Alan Gilbert
2020-05-04 15:29 ` [PATCH v3 02/12] configure: Avoid building TCG when not needed Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:40 ` Alistair Francis
2020-05-04 15:40 ` Alistair Francis
2020-05-04 15:29 ` [PATCH v3 03/12] tests/Makefile: Only display TCG-related tests when TCG is available Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 04/12] tests/Makefile: Restrict some softmmu-only tests Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 05/12] util/Makefile: Reduce the user-mode object list Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 06/12] stubs/Makefile: " Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 07/12] target/riscv/cpu: Restrict CPU migration to system-mode Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 08/12] exec: Assert CPU migration is not used on user-only build Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:41 ` Alistair Francis
2020-05-04 15:41 ` Alistair Francis
2020-05-04 15:29 ` [PATCH v3 09/12] arch_init: Remove unused 'qapi-commands-misc.h' include Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 10/12] target/i386: Restrict CpuClass::get_crash_info() to system-mode Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 11/12] target/s390x: " Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-05 12:05 ` Cornelia Huck
2020-05-05 12:05 ` Cornelia Huck
2020-05-04 15:29 ` [PATCH v3 12/12] hw/core: " Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-05 8:32 ` [PATCH v3 00/12] user-mode: Prune build dependencies (part 1) no-reply
2020-05-05 8:32 ` no-reply
2020-05-05 8:33 ` Laurent Vivier
2020-05-05 8:33 ` Laurent Vivier
2020-05-08 16:24 ` Philippe Mathieu-Daudé
2020-05-08 16:24 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518121434.GA2787@work-vm \
--to=dgilbert@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=marcel.apfelbaum@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.