From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8192ee: remove redundant for-loop
Date: Mon, 18 May 2020 12:19:32 +0000 [thread overview]
Message-ID: <20200518121932.CBE53C433D2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200515102226.29819-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The for-loop seems to be redundant, the assignments for indexes
> 0..2 are being over-written by the last index 3 in the loop. Remove
> the loop and use index 3 instead.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
b0a4bb7693be rtlwifi: rtl8192ee: remove redundant for-loop
--
https://patchwork.kernel.org/patch/11551059/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8192ee: remove redundant for-loop
Date: Mon, 18 May 2020 12:19:32 +0000 (UTC) [thread overview]
Message-ID: <20200518121932.CBE53C433D2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200515102226.29819-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The for-loop seems to be redundant, the assignments for indexes
> 0..2 are being over-written by the last index 3 in the loop. Remove
> the loop and use index 3 instead.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
b0a4bb7693be rtlwifi: rtl8192ee: remove redundant for-loop
--
https://patchwork.kernel.org/patch/11551059/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-18 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 10:22 [PATCH] rtlwifi: rtl8192ee: remove redundant for-loop Colin King
2020-05-15 10:22 ` Colin King
2020-05-15 12:38 ` AW: " Walter Harms
2020-05-18 12:19 ` Kalle Valo [this message]
2020-05-18 12:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518121932.CBE53C433D2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.