From: Joerg Roedel <joro@8bytes.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: kernel-janitors@vger.kernel.org,
iommu@lists.linux-foundation.org,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>,
Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime@cerno.tech>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] iommu/sun50i: Fix return value check in sun50i_iommu_probe()
Date: Tue, 19 May 2020 12:06:38 +0000 [thread overview]
Message-ID: <20200519120638.GG18353@8bytes.org> (raw)
In-Reply-To: <20200519091857.134170-1-weiyongjun1@huawei.com>
On Tue, May 19, 2020 at 09:18:57AM +0000, Wei Yongjun wrote:
> In case of error, the function devm_platform_ioremap_resource() returns
> ERR_PTR() not NULL. The NULL test in the return value check must be
> replaced with IS_ERR().
>
> Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/iommu/sun50i-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: kernel-janitors@vger.kernel.org,
iommu@lists.linux-foundation.org,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>,
Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime@cerno.tech>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] iommu/sun50i: Fix return value check in sun50i_iommu_probe()
Date: Tue, 19 May 2020 14:06:38 +0200 [thread overview]
Message-ID: <20200519120638.GG18353@8bytes.org> (raw)
In-Reply-To: <20200519091857.134170-1-weiyongjun1@huawei.com>
On Tue, May 19, 2020 at 09:18:57AM +0000, Wei Yongjun wrote:
> In case of error, the function devm_platform_ioremap_resource() returns
> ERR_PTR() not NULL. The NULL test in the return value check must be
> replaced with IS_ERR().
>
> Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/iommu/sun50i-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: kernel-janitors@vger.kernel.org,
iommu@lists.linux-foundation.org,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>,
Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime@cerno.tech>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] iommu/sun50i: Fix return value check in sun50i_iommu_probe()
Date: Tue, 19 May 2020 14:06:38 +0200 [thread overview]
Message-ID: <20200519120638.GG18353@8bytes.org> (raw)
In-Reply-To: <20200519091857.134170-1-weiyongjun1@huawei.com>
On Tue, May 19, 2020 at 09:18:57AM +0000, Wei Yongjun wrote:
> In case of error, the function devm_platform_ioremap_resource() returns
> ERR_PTR() not NULL. The NULL test in the return value check must be
> replaced with IS_ERR().
>
> Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/iommu/sun50i-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maxime Ripard <maxime@cerno.tech>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] iommu/sun50i: Fix return value check in sun50i_iommu_probe()
Date: Tue, 19 May 2020 14:06:38 +0200 [thread overview]
Message-ID: <20200519120638.GG18353@8bytes.org> (raw)
In-Reply-To: <20200519091857.134170-1-weiyongjun1@huawei.com>
On Tue, May 19, 2020 at 09:18:57AM +0000, Wei Yongjun wrote:
> In case of error, the function devm_platform_ioremap_resource() returns
> ERR_PTR() not NULL. The NULL test in the return value check must be
> replaced with IS_ERR().
>
> Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/iommu/sun50i-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
next prev parent reply other threads:[~2020-05-19 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 9:18 [PATCH -next] iommu/sun50i: Fix return value check in sun50i_iommu_probe() Wei Yongjun
2020-05-19 9:18 ` Wei Yongjun
2020-05-19 9:18 ` Wei Yongjun
2020-05-19 9:18 ` Wei Yongjun
2020-05-19 9:19 ` Maxime Ripard
2020-05-19 9:19 ` Maxime Ripard
2020-05-19 9:19 ` Maxime Ripard
2020-05-19 9:19 ` Maxime Ripard
2020-05-19 12:06 ` Joerg Roedel [this message]
2020-05-19 12:06 ` Joerg Roedel
2020-05-19 12:06 ` Joerg Roedel
2020-05-19 12:06 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519120638.GG18353@8bytes.org \
--to=joro@8bytes.org \
--cc=hulkci@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=weiyongjun1@huawei.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.