From: Joerg Roedel <joro@8bytes.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Konrad Dybcio <konradybcio@gmail.com>,
linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH v2] iommu/qcom: add optional 'tbu' clock for TLB invalidate
Date: Tue, 19 May 2020 14:24:58 +0200 [thread overview]
Message-ID: <20200519122458.GJ18353@8bytes.org> (raw)
In-Reply-To: <20200518141656.26284-1-shawn.guo@linaro.org>
On Mon, May 18, 2020 at 10:16:56PM +0800, Shawn Guo wrote:
> On some SoCs like MSM8939 with A405 adreno, there is a gfx_tbu clock
> needs to be on while doing TLB invalidate. Otherwise, TLBSYNC status
> will not be correctly reflected, causing the system to go into a bad
> state. Add it as an optional clock, so that platforms that have this
> clock can pass it over DT.
>
> While adding the third clock, let's switch to bulk clk API to simplify
> the enable/disable calls. clk_bulk_get() cannot used because the
> existing two clocks are required while the new one is optional.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> Changes for v2:
> - Use devm_clk_get_optional() to simplify code and improve readability.
> - Rename the new clock from 'tlb' to 'tbu'.
> - qcom_iommu: use bulk clk API to simplfy enable/disable.
>
> drivers/iommu/qcom_iommu.c | 62 ++++++++++++++++----------------------
> 1 file changed, 26 insertions(+), 36 deletions(-)
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konradybcio@gmail.com>,
iommu@lists.linux-foundation.org,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2] iommu/qcom: add optional 'tbu' clock for TLB invalidate
Date: Tue, 19 May 2020 14:24:58 +0200 [thread overview]
Message-ID: <20200519122458.GJ18353@8bytes.org> (raw)
In-Reply-To: <20200518141656.26284-1-shawn.guo@linaro.org>
On Mon, May 18, 2020 at 10:16:56PM +0800, Shawn Guo wrote:
> On some SoCs like MSM8939 with A405 adreno, there is a gfx_tbu clock
> needs to be on while doing TLB invalidate. Otherwise, TLBSYNC status
> will not be correctly reflected, causing the system to go into a bad
> state. Add it as an optional clock, so that platforms that have this
> clock can pass it over DT.
>
> While adding the third clock, let's switch to bulk clk API to simplify
> the enable/disable calls. clk_bulk_get() cannot used because the
> existing two clocks are required while the new one is optional.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> Changes for v2:
> - Use devm_clk_get_optional() to simplify code and improve readability.
> - Rename the new clock from 'tlb' to 'tbu'.
> - qcom_iommu: use bulk clk API to simplfy enable/disable.
>
> drivers/iommu/qcom_iommu.c | 62 ++++++++++++++++----------------------
> 1 file changed, 26 insertions(+), 36 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-05-19 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 14:16 [PATCH v2] iommu/qcom: add optional 'tbu' clock for TLB invalidate Shawn Guo
2020-05-18 14:16 ` Shawn Guo
2020-05-19 1:41 ` Bjorn Andersson
2020-05-19 1:41 ` Bjorn Andersson
2020-05-19 12:24 ` Joerg Roedel [this message]
2020-05-19 12:24 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519122458.GJ18353@8bytes.org \
--to=joro@8bytes.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.