From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/rtrs: Fix some signedness bugs in error handling
Date: Tue, 19 May 2020 23:46:35 +0000 [thread overview]
Message-ID: <20200519234635.GC30609@ziepe.ca> (raw)
In-Reply-To: <20200519133223.GN2078@kadam>
On Tue, May 19, 2020 at 04:32:23PM +0300, Dan Carpenter wrote:
> The problem is that "req->sg_cnt" is an unsigned int so if "nr" is
> negative, it gets type promoted to a high positive value and the
> condition is false. This patch fixes it by handling negatives separately.
>
> Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> v2: propagate the correct error code instead of returning -EINVAL
>
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 7 +++----
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +-
> 2 files changed, 4 insertions(+), 5 deletions(-)
Applied to for-next, thanks
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/rtrs: Fix some signedness bugs in error handling
Date: Tue, 19 May 2020 20:46:35 -0300 [thread overview]
Message-ID: <20200519234635.GC30609@ziepe.ca> (raw)
In-Reply-To: <20200519133223.GN2078@kadam>
On Tue, May 19, 2020 at 04:32:23PM +0300, Dan Carpenter wrote:
> The problem is that "req->sg_cnt" is an unsigned int so if "nr" is
> negative, it gets type promoted to a high positive value and the
> condition is false. This patch fixes it by handling negatives separately.
>
> Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> v2: propagate the correct error code instead of returning -EINVAL
>
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 7 +++----
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +-
> 2 files changed, 4 insertions(+), 5 deletions(-)
Applied to for-next, thanks
Jason
next prev parent reply other threads:[~2020-05-19 23:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 12:02 [PATCH] RDMA/rtrs: Fix some signedness bugs in error handling Dan Carpenter
2020-05-19 12:02 ` Dan Carpenter
2020-05-19 12:40 ` Jinpu Wang
2020-05-19 12:40 ` Jinpu Wang
2020-05-19 13:25 ` Dan Carpenter
2020-05-19 13:25 ` Dan Carpenter
2020-05-19 13:32 ` [PATCH v2] " Dan Carpenter
2020-05-19 13:32 ` Dan Carpenter
2020-05-19 13:35 ` Jinpu Wang
2020-05-19 13:35 ` Jinpu Wang
2020-05-19 23:46 ` Jason Gunthorpe [this message]
2020-05-19 23:46 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519234635.GC30609@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dan.carpenter@oracle.com \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.