All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Chenyi Qiang <chenyi.qiang@intel.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	qemu-devel@nongnu.org, Robert Hoo <robert.hu@linux.intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v4 5/5] target/i386: remove Icelake-Client CPU model
Date: Wed, 20 May 2020 10:17:34 +0100	[thread overview]
Message-ID: <20200520091734.GD2194189@redhat.com> (raw)
In-Reply-To: <20200520021007.30649-6-chenyi.qiang@intel.com>

On Wed, May 20, 2020 at 10:10:07AM +0800, Chenyi Qiang wrote:
> There are no Icelake Desktop products in the market. Remove the
> Icelake-Client CPU model.

QEMU has been shipping this CPU model for 2 years now. Regardless
of what CPUs Intel are selling, it is possible for users to be
running VMs with Icelake-Client CPU if their host satisfies the
listed features. So I don't think it is valid to remove this.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2020-05-20  9:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  2:10 [PATCH v4 0/5] modify CPU model info Chenyi Qiang
2020-05-20  2:10 ` [PATCH v4 1/5] target/i386: add missing vmx features for several CPU models Chenyi Qiang
2020-05-20  2:10 ` [PATCH v4 2/5] target/i386: add fast short REP MOV support Chenyi Qiang
2020-05-20  2:10 ` [PATCH v4 3/5] target/i386: add the missing features for Icelake-Server CPU model Chenyi Qiang
2020-05-20  2:10 ` [PATCH v4 4/5] target/i386: modify Icelake-Server CPU model number Chenyi Qiang
2020-05-20  2:10 ` [PATCH v4 5/5] target/i386: remove Icelake-Client CPU model Chenyi Qiang
2020-05-20  9:17   ` Daniel P. Berrangé [this message]
2020-05-21  1:40     ` Robert Hoo
2020-05-21  9:44       ` Daniel P. Berrangé
2020-06-11  3:22 ` [PATCH v4 0/5] modify CPU model info Chenyi Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520091734.GD2194189@redhat.com \
    --to=berrange@redhat.com \
    --cc=chenyi.qiang@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=robert.hu@linux.intel.com \
    --cc=rth@twiddle.net \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.