From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Robert Hoo <robert.hu@linux.intel.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
qemu-devel@nongnu.org, Chenyi Qiang <chenyi.qiang@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v4 5/5] target/i386: remove Icelake-Client CPU model
Date: Thu, 21 May 2020 10:44:48 +0100 [thread overview]
Message-ID: <20200521094448.GA2211791@redhat.com> (raw)
In-Reply-To: <40954b28075efac72948a9fd43b59ff4e2e9f42a.camel@linux.intel.com>
On Thu, May 21, 2020 at 09:40:55AM +0800, Robert Hoo wrote:
> On Wed, 2020-05-20 at 10:17 +0100, Daniel P. Berrangé wrote:
> > On Wed, May 20, 2020 at 10:10:07AM +0800, Chenyi Qiang wrote:
> > > There are no Icelake Desktop products in the market. Remove the
> > > Icelake-Client CPU model.
> >
> > QEMU has been shipping this CPU model for 2 years now. Regardless
> > of what CPUs Intel are selling, it is possible for users to be
> > running VMs with Icelake-Client CPU if their host satisfies the
> > listed features. So I don't think it is valid to remove this.
> >
> This 'Icelake-Client' actually doesn't exist. How do we define its
> feature list? and who will be using it? If any special feature tailor
> requirement, it can be simply achieved by '-cpu Icelake,+/-' features,
> this is the correct way.
Well its feature list is defined by what exists in QEMU code right
now. Presumably was based off some silicon that did exist in Intel
at some point, or it would not have been added to QEMU in the first
place ?
Changing guests to use "-cpu Icelake-Server,+/-" would be a guest
ABI change because of the different model number IIUC
> I think we should remove it. When we realize something's not correct,
> we should fix it ASAP. Leaving it there will only cause more serious
> issue in the future.
We have versioned CPU models so that we can fix mistakes in previously
defined CPU model features, without causing breakage for anything that
is using the previous incorrectly defined model. We can't version the
deletion of a CPU model though. I'm not seeing the serious harm that's
caused by the Icelake-Client CPU model existing though, and deleting
it will definitely cause harm to the config of anything that currently
happens to use it.
Maybe Icelake-Client could be turned into a deprecated alias for a
version of Icelake-Server that has the cutdown feature list ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-05-21 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 2:10 [PATCH v4 0/5] modify CPU model info Chenyi Qiang
2020-05-20 2:10 ` [PATCH v4 1/5] target/i386: add missing vmx features for several CPU models Chenyi Qiang
2020-05-20 2:10 ` [PATCH v4 2/5] target/i386: add fast short REP MOV support Chenyi Qiang
2020-05-20 2:10 ` [PATCH v4 3/5] target/i386: add the missing features for Icelake-Server CPU model Chenyi Qiang
2020-05-20 2:10 ` [PATCH v4 4/5] target/i386: modify Icelake-Server CPU model number Chenyi Qiang
2020-05-20 2:10 ` [PATCH v4 5/5] target/i386: remove Icelake-Client CPU model Chenyi Qiang
2020-05-20 9:17 ` Daniel P. Berrangé
2020-05-21 1:40 ` Robert Hoo
2020-05-21 9:44 ` Daniel P. Berrangé [this message]
2020-06-11 3:22 ` [PATCH v4 0/5] modify CPU model info Chenyi Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521094448.GA2211791@redhat.com \
--to=berrange@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.hu@linux.intel.com \
--cc=rth@twiddle.net \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.