From: kbuild test robot <lkp@intel.com>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>, manivannan.sadhasivam@linaro.org
Cc: kbuild-all@lists.01.org, linux-arm-msm@vger.kernel.org,
hemantk@codeaurora.org, jhugo@codeaurora.org,
linux-kernel@vger.kernel.org,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: Re: [PATCH v1 2/6] bus: mhi: core: Mark device inactive soon after host issues a shutdown
Date: Wed, 20 May 2020 13:16:11 +0800 [thread overview]
Message-ID: <202005201320.eeuomN8V%lkp@intel.com> (raw)
In-Reply-To: <1589934631-22752-3-git-send-email-bbhatt@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 4083 bytes --]
Hi Bhaumik,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20200519]
[cannot apply to linus/master v5.7-rc6 v5.7-rc5 v5.7-rc4 v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Bhaumik-Bhatt/Bug-fixes-and-bootup-and-shutdown-improvements/20200520-083400
base: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/bus/mhi/core/main.c: In function 'mhi_intvec_threaded_handler':
>> drivers/bus/mhi/core/main.c:397:8: error: implicit declaration of function 'mhi_is_active' [-Werror=implicit-function-declaration]
397 | if (!mhi_is_active(mhi_cntrl)) {
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/mhi_is_active +397 drivers/bus/mhi/core/main.c
371
372 irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv)
373 {
374 struct mhi_controller *mhi_cntrl = priv;
375 struct device *dev = &mhi_cntrl->mhi_dev->dev;
376 enum mhi_state state = MHI_STATE_MAX;
377 enum mhi_pm_state pm_state = 0;
378 enum mhi_ee_type ee = 0;
379 bool handle_rddm = false;
380
381 write_lock_irq(&mhi_cntrl->pm_lock);
382 if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {
383 write_unlock_irq(&mhi_cntrl->pm_lock);
384 goto exit_intvec;
385 }
386
387 state = mhi_get_mhi_state(mhi_cntrl);
388 ee = mhi_cntrl->ee;
389 mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl);
390 dev_dbg(dev, "local ee:%s device ee:%s dev_state:%s\n",
391 TO_MHI_EXEC_STR(mhi_cntrl->ee), TO_MHI_EXEC_STR(ee),
392 TO_MHI_STATE_STR(state));
393
394 /* If device supports RDDM don't bother processing SYS error */
395 if (mhi_cntrl->rddm_image) {
396 /* host may be performing a device power down already */
> 397 if (!mhi_is_active(mhi_cntrl)) {
398 write_unlock_irq(&mhi_cntrl->pm_lock);
399 goto exit_intvec;
400 }
401
402 if (mhi_cntrl->ee == MHI_EE_RDDM && mhi_cntrl->ee != ee) {
403 /* prevent clients from queueing any more packets */
404 pm_state = mhi_tryset_pm_state(mhi_cntrl,
405 MHI_PM_SYS_ERR_DETECT);
406 if (pm_state == MHI_PM_SYS_ERR_DETECT)
407 handle_rddm = true;
408 }
409
410 write_unlock_irq(&mhi_cntrl->pm_lock);
411
412 if (handle_rddm) {
413 dev_err(dev, "RDDM event occurred!\n");
414 mhi_cntrl->status_cb(mhi_cntrl, MHI_CB_EE_RDDM);
415 wake_up_all(&mhi_cntrl->state_event);
416 }
417 goto exit_intvec;
418 }
419
420 if (state == MHI_STATE_SYS_ERR) {
421 dev_dbg(dev, "System error detected\n");
422 pm_state = mhi_tryset_pm_state(mhi_cntrl,
423 MHI_PM_SYS_ERR_DETECT);
424 }
425
426 write_unlock_irq(&mhi_cntrl->pm_lock);
427
428 if (pm_state == MHI_PM_SYS_ERR_DETECT) {
429 wake_up_all(&mhi_cntrl->state_event);
430
431 /* For fatal errors, we let controller decide next step */
432 if (MHI_IN_PBL(ee))
433 mhi_cntrl->status_cb(mhi_cntrl, MHI_CB_FATAL_ERROR);
434 else
435 mhi_pm_sys_err_handler(mhi_cntrl);
436 }
437
438 exit_intvec:
439
440 return IRQ_HANDLED;
441 }
442
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64275 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 2/6] bus: mhi: core: Mark device inactive soon after host issues a shutdown
Date: Wed, 20 May 2020 13:16:11 +0800 [thread overview]
Message-ID: <202005201320.eeuomN8V%lkp@intel.com> (raw)
In-Reply-To: <1589934631-22752-3-git-send-email-bbhatt@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 4194 bytes --]
Hi Bhaumik,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20200519]
[cannot apply to linus/master v5.7-rc6 v5.7-rc5 v5.7-rc4 v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Bhaumik-Bhatt/Bug-fixes-and-bootup-and-shutdown-improvements/20200520-083400
base: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/bus/mhi/core/main.c: In function 'mhi_intvec_threaded_handler':
>> drivers/bus/mhi/core/main.c:397:8: error: implicit declaration of function 'mhi_is_active' [-Werror=implicit-function-declaration]
397 | if (!mhi_is_active(mhi_cntrl)) {
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/mhi_is_active +397 drivers/bus/mhi/core/main.c
371
372 irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv)
373 {
374 struct mhi_controller *mhi_cntrl = priv;
375 struct device *dev = &mhi_cntrl->mhi_dev->dev;
376 enum mhi_state state = MHI_STATE_MAX;
377 enum mhi_pm_state pm_state = 0;
378 enum mhi_ee_type ee = 0;
379 bool handle_rddm = false;
380
381 write_lock_irq(&mhi_cntrl->pm_lock);
382 if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {
383 write_unlock_irq(&mhi_cntrl->pm_lock);
384 goto exit_intvec;
385 }
386
387 state = mhi_get_mhi_state(mhi_cntrl);
388 ee = mhi_cntrl->ee;
389 mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl);
390 dev_dbg(dev, "local ee:%s device ee:%s dev_state:%s\n",
391 TO_MHI_EXEC_STR(mhi_cntrl->ee), TO_MHI_EXEC_STR(ee),
392 TO_MHI_STATE_STR(state));
393
394 /* If device supports RDDM don't bother processing SYS error */
395 if (mhi_cntrl->rddm_image) {
396 /* host may be performing a device power down already */
> 397 if (!mhi_is_active(mhi_cntrl)) {
398 write_unlock_irq(&mhi_cntrl->pm_lock);
399 goto exit_intvec;
400 }
401
402 if (mhi_cntrl->ee == MHI_EE_RDDM && mhi_cntrl->ee != ee) {
403 /* prevent clients from queueing any more packets */
404 pm_state = mhi_tryset_pm_state(mhi_cntrl,
405 MHI_PM_SYS_ERR_DETECT);
406 if (pm_state == MHI_PM_SYS_ERR_DETECT)
407 handle_rddm = true;
408 }
409
410 write_unlock_irq(&mhi_cntrl->pm_lock);
411
412 if (handle_rddm) {
413 dev_err(dev, "RDDM event occurred!\n");
414 mhi_cntrl->status_cb(mhi_cntrl, MHI_CB_EE_RDDM);
415 wake_up_all(&mhi_cntrl->state_event);
416 }
417 goto exit_intvec;
418 }
419
420 if (state == MHI_STATE_SYS_ERR) {
421 dev_dbg(dev, "System error detected\n");
422 pm_state = mhi_tryset_pm_state(mhi_cntrl,
423 MHI_PM_SYS_ERR_DETECT);
424 }
425
426 write_unlock_irq(&mhi_cntrl->pm_lock);
427
428 if (pm_state == MHI_PM_SYS_ERR_DETECT) {
429 wake_up_all(&mhi_cntrl->state_event);
430
431 /* For fatal errors, we let controller decide next step */
432 if (MHI_IN_PBL(ee))
433 mhi_cntrl->status_cb(mhi_cntrl, MHI_CB_FATAL_ERROR);
434 else
435 mhi_pm_sys_err_handler(mhi_cntrl);
436 }
437
438 exit_intvec:
439
440 return IRQ_HANDLED;
441 }
442
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 64275 bytes --]
next prev parent reply other threads:[~2020-05-20 5:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 0:30 [PATCH v1 0/6] Bug fixes and bootup and shutdown improvements Bhaumik Bhatt
2020-05-20 0:30 ` [PATCH v1 1/6] bus: mhi: core: Improve shutdown handling after link down detection Bhaumik Bhatt
2020-05-20 0:30 ` [PATCH v1 2/6] bus: mhi: core: Mark device inactive soon after host issues a shutdown Bhaumik Bhatt
2020-05-20 5:16 ` kbuild test robot [this message]
2020-05-20 5:16 ` kbuild test robot
2020-05-21 5:50 ` kbuild test robot
2020-05-21 5:50 ` kbuild test robot
2020-05-21 10:26 ` kbuild test robot
2020-05-21 10:26 ` kbuild test robot
2020-05-20 0:30 ` [PATCH v1 3/6] bus: mhi: core: Check for RDDM support before forcing a device crash Bhaumik Bhatt
2020-05-20 0:30 ` [PATCH v1 4/6] bus: mhi: core: Use common name for BHI firmware load function Bhaumik Bhatt
2020-05-20 0:30 ` [PATCH v1 5/6] bus: mhi: core: Introduce support for manual AMSS loading Bhaumik Bhatt
2020-05-20 0:30 ` [PATCH v1 6/6] bus: mhi: core: Process execution environment changes serially Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005201320.eeuomN8V%lkp@intel.com \
--to=lkp@intel.com \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.