From: Ivan Vecera <ivecera@redhat.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: andrew@lunn.ch, jiri@resnulli.us, nikolay@cumulusnetworks.com,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, kuba@kernel.org,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH 2/3] switchdev: mrp: Remove the variable mrp_ring_state
Date: Wed, 20 May 2020 17:56:47 +0200 [thread overview]
Message-ID: <20200520175647.32e6f5eb@ceranb> (raw)
In-Reply-To: <20200520130923.3196432-3-horatiu.vultur@microchip.com>
On Wed, 20 May 2020 13:09:22 +0000
Horatiu Vultur <horatiu.vultur@microchip.com> wrote:
> Remove the variable mrp_ring_state from switchdev_attr because is not
> used anywhere.
> The ring state is set using SWITCHDEV_OBJ_ID_RING_STATE_MRP.
>
> Fixes: c284b5459008 ("switchdev: mrp: Extend switchdev API to offload MRP")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> include/net/switchdev.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index ae7aeb0d1f9ca..db519957e134b 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -62,7 +62,6 @@ struct switchdev_attr {
> #if IS_ENABLED(CONFIG_BRIDGE_MRP)
> u8 mrp_port_state; /* MRP_PORT_STATE */
> u8 mrp_port_role; /* MRP_PORT_ROLE */
> - u8 mrp_ring_state; /* MRP_RING_STATE */
> #endif
> } u;
> };
Acked-by: Ivan Vecera <ivecera@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ivan Vecera <ivecera@redhat.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <jiri@resnulli.us>, <davem@davemloft.net>, <kuba@kernel.org>,
<roopa@cumulusnetworks.com>, <nikolay@cumulusnetworks.com>,
<andrew@lunn.ch>, <UNGLinuxDriver@microchip.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bridge@lists.linux-foundation.org>
Subject: Re: [PATCH 2/3] switchdev: mrp: Remove the variable mrp_ring_state
Date: Wed, 20 May 2020 17:56:47 +0200 [thread overview]
Message-ID: <20200520175647.32e6f5eb@ceranb> (raw)
In-Reply-To: <20200520130923.3196432-3-horatiu.vultur@microchip.com>
On Wed, 20 May 2020 13:09:22 +0000
Horatiu Vultur <horatiu.vultur@microchip.com> wrote:
> Remove the variable mrp_ring_state from switchdev_attr because is not
> used anywhere.
> The ring state is set using SWITCHDEV_OBJ_ID_RING_STATE_MRP.
>
> Fixes: c284b5459008 ("switchdev: mrp: Extend switchdev API to offload MRP")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> include/net/switchdev.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index ae7aeb0d1f9ca..db519957e134b 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -62,7 +62,6 @@ struct switchdev_attr {
> #if IS_ENABLED(CONFIG_BRIDGE_MRP)
> u8 mrp_port_state; /* MRP_PORT_STATE */
> u8 mrp_port_role; /* MRP_PORT_ROLE */
> - u8 mrp_ring_state; /* MRP_RING_STATE */
> #endif
> } u;
> };
Acked-by: Ivan Vecera <ivecera@redhat.com>
next prev parent reply other threads:[~2020-05-20 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:09 [Bridge] [PATCH 0/3] net: bridge: mrp: Add small fixes to MRP Horatiu Vultur
2020-05-20 13:09 ` Horatiu Vultur
2020-05-20 13:09 ` [Bridge] [PATCH 1/3] bridge: mrp: Add br_mrp_unique_ifindex function Horatiu Vultur
2020-05-20 13:09 ` Horatiu Vultur
2020-05-21 8:16 ` [Bridge] " Nikolay Aleksandrov
2020-05-21 8:16 ` Nikolay Aleksandrov
2020-05-21 18:49 ` [Bridge] " Horatiu Vultur
2020-05-21 18:49 ` Horatiu Vultur
2020-05-21 16:58 ` [Bridge] " Nikolay Aleksandrov
2020-05-21 16:58 ` Nikolay Aleksandrov
2020-05-21 19:30 ` [Bridge] " Horatiu Vultur
2020-05-21 19:30 ` Horatiu Vultur
2020-05-20 13:09 ` [Bridge] [PATCH 2/3] switchdev: mrp: Remove the variable mrp_ring_state Horatiu Vultur
2020-05-20 13:09 ` Horatiu Vultur
2020-05-20 15:56 ` Ivan Vecera [this message]
2020-05-20 15:56 ` Ivan Vecera
2020-05-20 13:09 ` [Bridge] [PATCH 3/3] bridge: mrp: Restore port state when deleting MRP instance Horatiu Vultur
2020-05-20 13:09 ` Horatiu Vultur
2020-05-21 8:18 ` [Bridge] " Nikolay Aleksandrov
2020-05-21 8:18 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520175647.32e6f5eb@ceranb \
--to=ivecera@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.