[linux-nvme:nvme-5.8 26/33] io-cmd-bdev.c:undefined reference to `t10_pi_type1_crc'

[linux-nvme:nvme-5.8 26/33] io-cmd-bdev.c:undefined reference to `t10_pi_type1_crc'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2207 bytes --]

tree:   git://git.infradead.org/nvme.git nvme-5.8
head:   08b17299f88361a4ad49bf1c7ff9338bbe99ce85
commit: 79250d19e14f25bbd23a5cb0b4c309c4c994d93e [26/33] nvmet: add metadata characteristics for a namespace
config: arm64-randconfig-r005-20200520 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        git checkout 79250d19e14f25bbd23a5cb0b4c309c4c994d93e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

aarch64-linux-gnu-ld: drivers/nvme/target/io-cmd-bdev.o: in function `nvmet_bdev_ns_enable':
>> io-cmd-bdev.c:(.text+0x16c): undefined reference to `t10_pi_type1_crc'
aarch64-linux-gnu-ld: drivers/nvme/target/io-cmd-bdev.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `t10_pi_type1_crc' which may bind externally can not be used when making a shared object; recompile with -fPIC
io-cmd-bdev.c:(.text+0x16c): dangerous relocation: unsupported relocation
>> aarch64-linux-gnu-ld: io-cmd-bdev.c:(.text+0x170): undefined reference to `t10_pi_type1_crc'
>> aarch64-linux-gnu-ld: io-cmd-bdev.c:(.text+0x17c): undefined reference to `t10_pi_type3_crc'
aarch64-linux-gnu-ld: drivers/nvme/target/io-cmd-bdev.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `t10_pi_type3_crc' which may bind externally can not be used when making a shared object; recompile with -fPIC
io-cmd-bdev.c:(.text+0x17c): dangerous relocation: unsupported relocation
aarch64-linux-gnu-ld: io-cmd-bdev.c:(.text+0x180): undefined reference to `t10_pi_type3_crc'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 47549 bytes --]

Re: [linux-nvme:nvme-5.8 26/33] io-cmd-bdev.c:undefined reference to `t10_pi_type1_crc'

[Christoph Hellwig]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Ok, looks like the previous fix wasn't enough.  It seems like we
need to fold this in, similar to sd and the nvme host driver:

diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
index d7f48c0fb311f..4474952d64c6b 100644
--- a/drivers/nvme/target/Kconfig
+++ b/drivers/nvme/target/Kconfig
@@ -4,6 +4,7 @@ config NVME_TARGET
 	tristate "NVMe Target support"
 	depends on BLOCK
 	depends on CONFIGFS_FS
+	select BLK_DEV_INTEGRITY_T10 if BLK_DEV_INTEGRITY
 	select SGL_ALLOC
 	help
 	  This enabled target side support for the NVMe protocol, that is

Re: [linux-nvme:nvme-5.8 26/33] io-cmd-bdev.c:undefined reference to `t10_pi_type1_crc'

[Martin K. Petersen]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]


Christoph,

> Ok, looks like the previous fix wasn't enough.  It seems like we
> need to fold this in, similar to sd and the nvme host driver:

Looks good.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering