From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] firmware: tegra: Defer BPMP probe if shared memory not available
Date: Fri, 22 May 2020 14:58:52 +0200 [thread overview]
Message-ID: <20200522125852.GJ2163848@ulmo> (raw)
In-Reply-To: <20200520151206.15253-1-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Wed, May 20, 2020 at 04:12:06PM +0100, Jon Hunter wrote:
> Since commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when
> adding all top level devices") was added, the probing of the Tegra
> SRAM device has occurred later in the boot sequence, after the BPMP
> has been probed. The BPMP uses sections of the SRAM for shared memory
> and if the BPMP is probed before the SRAM then it fails to probe and
> never tries again. This is causing a boot failure on Tegra186 and
> Tegra194. Fix this by allowing the probe of the BPMP to be deferred if
> the SRAM is not available yet.
>
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/firmware/tegra/bpmp-tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: tegra: Defer BPMP probe if shared memory not available
Date: Fri, 22 May 2020 14:58:52 +0200 [thread overview]
Message-ID: <20200522125852.GJ2163848@ulmo> (raw)
In-Reply-To: <20200520151206.15253-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On Wed, May 20, 2020 at 04:12:06PM +0100, Jon Hunter wrote:
> Since commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when
> adding all top level devices") was added, the probing of the Tegra
> SRAM device has occurred later in the boot sequence, after the BPMP
> has been probed. The BPMP uses sections of the SRAM for shared memory
> and if the BPMP is probed before the SRAM then it fails to probe and
> never tries again. This is causing a boot failure on Tegra186 and
> Tegra194. Fix this by allowing the probe of the BPMP to be deferred if
> the SRAM is not available yet.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/firmware/tegra/bpmp-tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-22 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 15:12 [PATCH] firmware: tegra: Defer BPMP probe if shared memory not available Jon Hunter
2020-05-20 15:12 ` Jon Hunter
[not found] ` <20200520151206.15253-1-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-05-22 12:58 ` Thierry Reding [this message]
2020-05-22 12:58 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522125852.GJ2163848@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.