From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order
Date: Fri, 22 May 2020 16:13:02 +0300 [thread overview]
Message-ID: <20200522131302.GA20068@intel.com> (raw)
In-Reply-To: <159015272616.32320.7673829907075394808@build.alporthouse.com>
On Fri, May 22, 2020 at 02:05:26PM +0100, Chris Wilson wrote:
> Quoting Stanislav Lisovskiy (2020-05-22 13:55:34)
> > Removed duplicate include and fixed comment > 80 chars.
> >
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bw.c | 43 ++++++++++++----------
> > drivers/gpu/drm/i915/display/intel_bw.h | 2 +-
> > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_cdclk.h | 1 +
> > drivers/gpu/drm/i915/intel_pm.c | 3 +-
> > drivers/gpu/drm/i915/intel_pm.h | 2 +-
> > 6 files changed, 29 insertions(+), 24 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 8d2f58e39595..db9ba8f922bd 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -5,13 +5,12 @@
> >
> > #include <drm/drm_atomic_state_helper.h>
> >
> > +#include "intel_atomic.h"
> > #include "intel_bw.h"
> > -#include "intel_pm.h"
> > +#include "intel_cdclk.h"
> > #include "intel_display_types.h"
> > -#include "intel_sideband.h"
> > -#include "intel_atomic.h"
> > #include "intel_pm.h"
> > -#include "intel_cdclk.h"
> > +#include "intel_sideband.h"
>
> There was also the accidental remove of a '\n' before
> intel_bw_crtc_update()
Weird..how didn't I spot this.
>
> > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > index dda9bae02a86..643701cca6ba 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > @@ -23,10 +23,10 @@
> >
> > #include <linux/time.h>
>
> \n between system and local includes
>
> > #include "intel_atomic.h"
> > +#include "intel_bw.h"
> > #include "intel_cdclk.h"
> > #include "intel_display_types.h"
> > #include "intel_sideband.h"
> > -#include "intel_bw.h"
>
> 2 more nits then
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> s/Reviewed/Critiqued/
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-22 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 12:55 [Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order Stanislav Lisovskiy
2020-05-22 13:05 ` Chris Wilson
2020-05-22 13:13 ` Lisovskiy, Stanislav [this message]
2020-05-22 13:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522131302.GA20068@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.