From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Alex Deucher <alexander.deucher@amd.com>,
Evan Quan <evan.quan@amd.com>
Subject: Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper
Date: Fri, 22 May 2020 12:51:42 -0500 [thread overview]
Message-ID: <20200522175142.GF29907@embeddedor> (raw)
In-Reply-To: <1065d63e-7959-e4b4-af4e-70607ba92296@amd.com>
On Wed, May 20, 2020 at 09:42:27AM +0200, Christian König wrote:
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Acked-by: Christian König <christian.koenig@amd.com>
>
> May I suggest that we add a section how to correctly do this to
> Documentation/process/coding-style.rst or similar document?
>
That's already on my list. :)
> I've seen a bunch of different approaches and some even doesn't work with
> some gcc versions and result in a broken binary.
>
Do you have an example of that one that doesn't work with some GCC
versions? It'd be interesting to take a look...
Thanks
--
Gustavo
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Evan Quan <evan.quan@amd.com>
Subject: Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper
Date: Fri, 22 May 2020 12:51:42 -0500 [thread overview]
Message-ID: <20200522175142.GF29907@embeddedor> (raw)
In-Reply-To: <1065d63e-7959-e4b4-af4e-70607ba92296@amd.com>
On Wed, May 20, 2020 at 09:42:27AM +0200, Christian König wrote:
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Acked-by: Christian König <christian.koenig@amd.com>
>
> May I suggest that we add a section how to correctly do this to
> Documentation/process/coding-style.rst or similar document?
>
That's already on my list. :)
> I've seen a bunch of different approaches and some even doesn't work with
> some gcc versions and result in a broken binary.
>
Do you have an example of that one that doesn't work with some GCC
versions? It'd be interesting to take a look...
Thanks
--
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: Evan Quan <evan.quan@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper
Date: Fri, 22 May 2020 12:51:42 -0500 [thread overview]
Message-ID: <20200522175142.GF29907@embeddedor> (raw)
In-Reply-To: <1065d63e-7959-e4b4-af4e-70607ba92296@amd.com>
On Wed, May 20, 2020 at 09:42:27AM +0200, Christian König wrote:
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Acked-by: Christian König <christian.koenig@amd.com>
>
> May I suggest that we add a section how to correctly do this to
> Documentation/process/coding-style.rst or similar document?
>
That's already on my list. :)
> I've seen a bunch of different approaches and some even doesn't work with
> some gcc versions and result in a broken binary.
>
Do you have an example of that one that doesn't work with some GCC
versions? It'd be interesting to take a look...
Thanks
--
Gustavo
next prev parent reply other threads:[~2020-05-22 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 22:55 [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper Gustavo A. R. Silva
2020-05-19 22:55 ` Gustavo A. R. Silva
2020-05-19 22:55 ` Gustavo A. R. Silva
2020-05-20 7:42 ` Christian König
2020-05-20 7:42 ` Christian König
2020-05-20 7:42 ` Christian König
2020-05-20 18:17 ` Alex Deucher
2020-05-20 18:17 ` Alex Deucher
2020-05-20 18:17 ` Alex Deucher
2020-05-22 17:51 ` Gustavo A. R. Silva [this message]
2020-05-22 17:51 ` Gustavo A. R. Silva
2020-05-22 17:51 ` Gustavo A. R. Silva
2020-05-22 17:54 ` Alex Deucher
2020-05-22 17:54 ` Alex Deucher
2020-05-22 17:54 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522175142.GF29907@embeddedor \
--to=gustavoars@kernel.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.