From: "wsa@kernel.org" <wsa@kernel.org>
To: Rob Herring <robh@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Pierre Yves MORDRET <pierre-yves.mordret@st.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fabrice GASNIER <fabrice.gasnier@st.com>
Subject: Re: [PATCH 3/4] dt-bindings: i2c-stm32: add SMBus Alert bindings
Date: Sat, 23 May 2020 12:36:01 +0200 [thread overview]
Message-ID: <20200523103601.GA3459@ninjato> (raw)
In-Reply-To: <20200513054231.GA16558@gnbcxd0016.gnb.st.com>
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
> > > + st,smbus-alert:
> > > + description: Enable the SMBus Alert feature
> > > + $ref: /schemas/types.yaml#/definitions/flag
> > > +
> >
> > We already have smbus_alert interrupt. Can't you just check for this in
> > the slave nodes and enable if found?
>
> My understanding reading the code (smbalert_probe within i2c-smbus.c, of_i2c_setup_smbus_alert called when
> registering an adapter within i2c-core-smbus.c) is that smbus_alert refers to an interrupt on the
> adapter side. That is an interrupt that would be triggered when the adapter is receiving an smbus_alert
> message.
> In our case (stm32f7), we do not have specific interrupt for that purpose. The interrupt triggered when
> an SMBUS Alert is received (by the adapter) is the same interrupt as for other reasons and we check
> within the irq handler within stm32f7 the reason before calling i2c_handle_smbus_alert if the status
> register indicated an SMBUS Alert.
> So my understanding is that we cannot rely on the mechanism of naming an interrupt smbus_alert.
> Did I misunderstood something ?
I just wonder what is bad about specifying the same interrupt twice in
the interrupt properties? You could then check in probe if "smbus_alert"
is populated and if it matches the main irq.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "wsa@kernel.org" <wsa@kernel.org>
To: Rob Herring <robh@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Pierre Yves MORDRET <pierre-yves.mordret@st.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fabrice GASNIER <fabrice.gasnier@st.com>
Subject: Re: [PATCH 3/4] dt-bindings: i2c-stm32: add SMBus Alert bindings
Date: Sat, 23 May 2020 12:36:01 +0200 [thread overview]
Message-ID: <20200523103601.GA3459@ninjato> (raw)
In-Reply-To: <20200513054231.GA16558@gnbcxd0016.gnb.st.com>
[-- Attachment #1.1: Type: text/plain, Size: 1309 bytes --]
> > > + st,smbus-alert:
> > > + description: Enable the SMBus Alert feature
> > > + $ref: /schemas/types.yaml#/definitions/flag
> > > +
> >
> > We already have smbus_alert interrupt. Can't you just check for this in
> > the slave nodes and enable if found?
>
> My understanding reading the code (smbalert_probe within i2c-smbus.c, of_i2c_setup_smbus_alert called when
> registering an adapter within i2c-core-smbus.c) is that smbus_alert refers to an interrupt on the
> adapter side. That is an interrupt that would be triggered when the adapter is receiving an smbus_alert
> message.
> In our case (stm32f7), we do not have specific interrupt for that purpose. The interrupt triggered when
> an SMBUS Alert is received (by the adapter) is the same interrupt as for other reasons and we check
> within the irq handler within stm32f7 the reason before calling i2c_handle_smbus_alert if the status
> register indicated an SMBUS Alert.
> So my understanding is that we cannot rely on the mechanism of naming an interrupt smbus_alert.
> Did I misunderstood something ?
I just wonder what is bad about specifying the same interrupt twice in
the interrupt properties? You could then check in probe if "smbus_alert"
is populated and if it matches the main irq.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-23 10:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 5:51 [PATCH 0/4] stm32-f7: Addition of SMBus Alert / Host-notify features Alain Volmat
2020-05-05 5:51 ` Alain Volmat
2020-05-05 5:51 ` [PATCH 1/4] i2c: smbus: add core function handling SMBus host-notify Alain Volmat
2020-05-05 5:51 ` Alain Volmat
2020-05-11 8:26 ` Pierre Yves MORDRET
2020-05-11 8:26 ` Pierre Yves MORDRET
2020-05-23 10:46 ` Wolfram Sang
2020-05-23 10:46 ` Wolfram Sang
2020-05-26 10:23 ` Alain Volmat
2020-05-26 10:23 ` Alain Volmat
2020-05-05 5:51 ` [PATCH 2/4] i2c: addition of client reg/unreg callbacks Alain Volmat
2020-05-05 5:51 ` Alain Volmat
2020-05-11 8:28 ` Pierre Yves MORDRET
2020-05-11 8:28 ` Pierre Yves MORDRET
2020-05-23 10:49 ` Wolfram Sang
2020-05-23 10:49 ` Wolfram Sang
2020-05-05 5:51 ` [PATCH 3/4] dt-bindings: i2c-stm32: add SMBus Alert bindings Alain Volmat
2020-05-05 5:51 ` Alain Volmat
2020-05-13 2:19 ` Rob Herring
2020-05-13 2:19 ` Rob Herring
2020-05-13 5:42 ` Alain Volmat
2020-05-13 5:42 ` Alain Volmat
2020-05-18 10:53 ` Alain Volmat
2020-05-18 10:53 ` Alain Volmat
2020-05-23 10:36 ` wsa [this message]
2020-05-23 10:36 ` wsa
2020-05-26 10:31 ` Alain Volmat
2020-05-26 10:31 ` Alain Volmat
2020-05-05 5:51 ` [PATCH 4/4] i2c: stm32f7: Add SMBus-specific protocols support Alain Volmat
2020-05-05 5:51 ` Alain Volmat
2020-05-11 8:27 ` Pierre Yves MORDRET
2020-05-11 8:27 ` Pierre Yves MORDRET
2020-05-23 11:01 ` Wolfram Sang
2020-05-23 11:01 ` Wolfram Sang
2020-05-26 10:39 ` Alain Volmat
2020-05-26 10:39 ` Alain Volmat
2020-06-30 6:40 ` Wolfram Sang
2020-06-30 6:40 ` Wolfram Sang
2020-06-30 9:31 ` Alain Volmat
2020-06-30 9:31 ` Alain Volmat
2020-06-30 15:11 ` Wolfram Sang
2020-06-30 15:11 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523103601.GA3459@ninjato \
--to=wsa@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.