From: Greg KH <gregkh@linuxfoundation.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
hemantk@codeaurora.org, jhugo@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI
Date: Mon, 25 May 2020 08:35:13 +0200 [thread overview]
Message-ID: <20200525063513.GA59195@kroah.com> (raw)
In-Reply-To: <1589832241-13867-6-git-send-email-bbhatt@codeaurora.org>
On Mon, May 18, 2020 at 01:03:59PM -0700, Bhaumik Bhatt wrote:
> +void mhi_create_debugfs(struct mhi_controller *mhi_cntrl)
> +{
> + if (IS_ERR_OR_NULL(mhi_debugfs_root))
> + return;
Why? Should not matter.
> + mhi_cntrl->debugfs_dentry =
> + debugfs_create_dir(dev_name(mhi_cntrl->cntrl_dev),
> + mhi_debugfs_root);
> + if (IS_ERR_OR_NULL(mhi_cntrl->debugfs_dentry))
> + return;
No need for this check either, just call debugfs and keep on moving :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-25 6:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 20:03 [PATCH v3 0/7] Introduce features and debugfs/sysfs entries for MHI Bhaumik Bhatt
2020-05-18 20:03 ` [PATCH v3 1/7] bus: mhi: core: Abort suspends due to outgoing pending packets Bhaumik Bhatt
2020-05-20 16:48 ` Jeffrey Hugo
2020-05-18 20:03 ` [PATCH v3 2/7] bus: mhi: core: Introduce independent voting mechanism Bhaumik Bhatt
2020-05-20 16:54 ` Jeffrey Hugo
2020-05-20 18:43 ` bbhatt
2020-05-20 19:06 ` Jeffrey Hugo
2020-05-20 19:44 ` bbhatt
2020-05-20 20:41 ` Jeffrey Hugo
2020-05-18 20:03 ` [PATCH v3 3/7] bus: mhi: core: Use generic name field for an MHI device Bhaumik Bhatt
2020-05-18 20:03 ` [PATCH v3 4/7] bus: mhi: core: Introduce helper function to check device state Bhaumik Bhatt
2020-05-18 20:03 ` [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI Bhaumik Bhatt
2020-05-25 6:35 ` Greg KH [this message]
2020-05-18 20:04 ` [PATCH v3 6/7] bus: mhi: core: Read and save device hardware information from BHI Bhaumik Bhatt
2020-05-18 20:04 ` [PATCH v3 7/7] bus: mhi: core: Introduce sysfs entries for MHI Bhaumik Bhatt
2020-05-21 13:23 ` [PATCH v3 0/7] Introduce features and debugfs/sysfs " Manivannan Sadhasivam
2020-05-21 15:32 ` Manivannan Sadhasivam
2020-05-21 19:33 ` bbhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525063513.GA59195@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.