From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Revert CDCLK changes to unbreak geminilake
Date: Mon, 25 May 2020 11:15:31 +0300 [thread overview]
Message-ID: <20200525081530.GA32239@intel.com> (raw)
In-Reply-To: <159039461424.30979.17871163129232770512@build.alporthouse.com>
On Mon, May 25, 2020 at 09:16:54AM +0100, Chris Wilson wrote:
> Quoting Lisovskiy, Stanislav (2020-05-25 09:07:54)
> > On Mon, May 25, 2020 at 09:07:31AM +0100, Chris Wilson wrote:
> > > This reverts
> > > cac91e671ad5 ("drm/i915: Fix includes and local vars order")
> > > 82ea174dc542 ("drm/i915: Remove unneeded hack now for CDCLK")
> > > cd1915460861 ("drm/i915: Adjust CDCLK accordingly to our DBuf bw needs")
> > >
> > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> >
> >
> > I guess we still need to check more precisely if this patch caused
> > this - or have you already bisected that?
>
> This was found by unwinding the patches on CI.
>
> > It is rather strange that it breaks only a GLK and only single test.
>
> Bug detection is purely serendipitous.
> -Chris
Ok then lets rewind those - then it will become clear at least.
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-25 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 8:07 [Intel-gfx] [PATCH] drm/i915: Revert CDCLK changes to unbreak geminilake Chris Wilson
2020-05-25 8:07 ` Lisovskiy, Stanislav
2020-05-25 8:16 ` Chris Wilson
2020-05-25 8:15 ` Lisovskiy, Stanislav [this message]
2020-05-25 8:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-05-25 8:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-25 9:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525081530.GA32239@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.