All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] nl80211: FILS discovery/bcast probe resp support
@ 2020-05-25  5:05 kbuild test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2020-05-25  5:05 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 6173 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200522221921.19347-2-alokad@codeaurora.org>
References: <20200522221921.19347-2-alokad@codeaurora.org>
TO: Aloka Dixit <alokad@codeaurora.org>
TO: johannes(a)sipsolutions.net
CC: linux-wireless(a)vger.kernel.org
CC: Aloka Dixit <alokad@codeaurora.org>

Hi Aloka,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mac80211-next/master]
[also build test WARNING on next-20200522]
[cannot apply to mac80211/master v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Aloka-Dixit/FILS-discovery-and-bcast-probe-resp-support/20200523-062228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
net/wireless/nl80211.c:4771 nl80211_parse_fd_bcastpresp() error: we previously assumed 'tmpl' could be null (see line 4766)

Old smatch warnings:
net/wireless/nl80211.c:225 validate_beacon_head() warn: potential spectre issue 'elem->data' [r]
net/wireless/nl80211.c:244 validate_ie_attr() warn: potential spectre issue 'elem->data' [r]
net/wireless/nl80211.c:1262 nl80211_parse_connkeys() warn: ignoring unreachable code.
net/wireless/nl80211.c:4482 nl80211_parse_tx_bitrate_mask() warn: potential spectre issue 'rdev->wiphy.bands' [r] (local cap)
net/wireless/nl80211.c:4483 nl80211_parse_tx_bitrate_mask() warn: possible spectre second half.  'sband'
net/wireless/nl80211.c:4492 nl80211_parse_tx_bitrate_mask() warn: potential spectre issue 'mask->control' [w] (local cap)
net/wireless/nl80211.c:7984 nl80211_trigger_scan() warn: potential spectre issue 'wiphy->bands' [r] (local cap)
net/wireless/nl80211.c:7987 nl80211_trigger_scan() warn: potential spectre issue 'request->rates' [r] (local cap)
net/wireless/nl80211.c:8186 nl80211_parse_sched_scan_per_band_rssi() warn: potential spectre issue 'match_sets->per_band_rssi_thold' [w] (local cap)

# https://github.com/0day-ci/linux/commit/d7497e63c41decf82e86f11b0691e47e24b11122
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout d7497e63c41decf82e86f11b0691e47e24b11122
vim +/tmpl +4771 net/wireless/nl80211.c

5c5e52d1bb9625 John Crispin 2019-12-17  4737  
d7497e63c41dec Aloka Dixit  2020-05-22  4738  static int nl80211_parse_fd_bcastpresp(struct genl_info *info,
d7497e63c41dec Aloka Dixit  2020-05-22  4739  				       struct cfg80211_ap_settings *params)
d7497e63c41dec Aloka Dixit  2020-05-22  4740  {
d7497e63c41dec Aloka Dixit  2020-05-22  4741  	struct nlattr *tmpl;
d7497e63c41dec Aloka Dixit  2020-05-22  4742  	struct nlattr *tb[NL80211_FD_BCASTPRESP_ATTR_MAX + 1];
d7497e63c41dec Aloka Dixit  2020-05-22  4743  	int ret;
d7497e63c41dec Aloka Dixit  2020-05-22  4744  	struct cfg80211_beacon_data *beacon = &params->beacon;
d7497e63c41dec Aloka Dixit  2020-05-22  4745  	struct cfg80211_fd_bcastpresp *cfg;
d7497e63c41dec Aloka Dixit  2020-05-22  4746  
d7497e63c41dec Aloka Dixit  2020-05-22  4747  	if (params->chandef.center_freq1 <= 5940 &&
d7497e63c41dec Aloka Dixit  2020-05-22  4748  	    params->chandef.center_freq1 >= 7105)
d7497e63c41dec Aloka Dixit  2020-05-22  4749  		return -EOPNOTSUPP;
d7497e63c41dec Aloka Dixit  2020-05-22  4750  
d7497e63c41dec Aloka Dixit  2020-05-22  4751  	ret = nla_parse_nested(tb, NL80211_FD_BCASTPRESP_ATTR_MAX,
d7497e63c41dec Aloka Dixit  2020-05-22  4752  			       info->attrs[NL80211_ATTR_FD_BCASTPRESP_CFG],
d7497e63c41dec Aloka Dixit  2020-05-22  4753  			       fd_bcastpresp_policy, NULL);
d7497e63c41dec Aloka Dixit  2020-05-22  4754  	if (ret)
d7497e63c41dec Aloka Dixit  2020-05-22  4755  		return ret;
d7497e63c41dec Aloka Dixit  2020-05-22  4756  
d7497e63c41dec Aloka Dixit  2020-05-22  4757  	if (!tb[NL80211_FD_BCASTPRESP_ATTR_TYPE] ||
d7497e63c41dec Aloka Dixit  2020-05-22  4758  	    !tb[NL80211_FD_BCASTPRESP_ATTR_INT])
d7497e63c41dec Aloka Dixit  2020-05-22  4759  		return -EINVAL;
d7497e63c41dec Aloka Dixit  2020-05-22  4760  
d7497e63c41dec Aloka Dixit  2020-05-22  4761  	cfg = &params->fd_bcastpresp;
d7497e63c41dec Aloka Dixit  2020-05-22  4762  	cfg->type = nla_get_u8(tb[NL80211_FD_BCASTPRESP_ATTR_TYPE]);
d7497e63c41dec Aloka Dixit  2020-05-22  4763  	cfg->interval = nla_get_u32(tb[NL80211_FD_BCASTPRESP_ATTR_INT]);
d7497e63c41dec Aloka Dixit  2020-05-22  4764  
d7497e63c41dec Aloka Dixit  2020-05-22  4765  	tmpl = tb[NL80211_FD_BCASTPRESP_ATTR_TMPL];
d7497e63c41dec Aloka Dixit  2020-05-22 @4766  	if (!tmpl && !beacon->fils_disc_len && !beacon->bcast_presp_len)
d7497e63c41dec Aloka Dixit  2020-05-22  4767  		return -EINVAL;
d7497e63c41dec Aloka Dixit  2020-05-22  4768  
d7497e63c41dec Aloka Dixit  2020-05-22  4769  	if (cfg->type == CFG80211_TYPE_FILS_DISCOVERY) {
d7497e63c41dec Aloka Dixit  2020-05-22  4770  		beacon->fils_disc = nla_data(tmpl);
d7497e63c41dec Aloka Dixit  2020-05-22 @4771  		beacon->fils_disc_len = nla_len(tmpl);
d7497e63c41dec Aloka Dixit  2020-05-22  4772  	} else if (cfg->type == CFG80211_TYPE_BCAST_PROBE_RESP) {
d7497e63c41dec Aloka Dixit  2020-05-22  4773  		beacon->bcast_presp = nla_data(tmpl);
d7497e63c41dec Aloka Dixit  2020-05-22  4774  		beacon->bcast_presp_len = nla_len(tmpl);
d7497e63c41dec Aloka Dixit  2020-05-22  4775  	}
d7497e63c41dec Aloka Dixit  2020-05-22  4776  
d7497e63c41dec Aloka Dixit  2020-05-22  4777  	return 0;
d7497e63c41dec Aloka Dixit  2020-05-22  4778  }
d7497e63c41dec Aloka Dixit  2020-05-22  4779  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29124 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 0/2] FILS discovery and bcast probe resp support
@ 2020-05-22 22:19 Aloka Dixit
  2020-05-22 22:19 ` [PATCH 1/2] nl80211: FILS discovery/bcast " Aloka Dixit
  0 siblings, 1 reply; 7+ messages in thread
From: Aloka Dixit @ 2020-05-22 22:19 UTC (permalink / raw)
  To: johannes; +Cc: linux-wireless, Aloka Dixit

This patchset adds support for FILS discovery and broadcast
unsolicited probe response transmission in 6GHz for in-band
discovery.

Aloka Dixit (2):
  nl80211: FILS discovery/bcast probe resp support
  mac80211: FILS disc/bcast probe resp config

 include/net/cfg80211.h       | 26 ++++++++++++++++
 include/net/mac80211.h       | 17 +++++++++++
 include/uapi/linux/nl80211.h | 27 +++++++++++++++++
 net/mac80211/cfg.c           | 57 +++++++++++++++++++++++++++++++++++
 net/mac80211/ieee80211_i.h   |  8 +++++
 net/mac80211/tx.c            | 30 +++++++++++++++++++
 net/wireless/nl80211.c       | 58 ++++++++++++++++++++++++++++++++++++
 7 files changed, 223 insertions(+)

-- 
2.25.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-05-26 14:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-25  5:05 [PATCH 1/2] nl80211: FILS discovery/bcast probe resp support kbuild test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-05-22 22:19 [PATCH 0/2] FILS discovery and bcast " Aloka Dixit
2020-05-22 22:19 ` [PATCH 1/2] nl80211: FILS discovery/bcast " Aloka Dixit
2020-05-25  7:52   ` kbuild test robot
2020-05-25  7:52     ` kbuild test robot
2020-05-26 14:45   ` Dan Carpenter
2020-05-26 14:45     ` Dan Carpenter
2020-05-26 14:45     ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.