* [PATCH] stmmac: platform: add "snps, dwmac-5.10a" IP compatible string
@ 2020-05-25 8:22 ` Fugang Duan
0 siblings, 0 replies; 10+ messages in thread
From: Fugang Duan @ 2020-05-25 8:22 UTC (permalink / raw)
To: peppe.cavallaro, alexandre.torgue, joabreu, kuba, davem
Cc: fugang.duan, mcoquelin.stm32, netdev, p.zabel, linux-stm32,
linux-arm-kernel
Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
avoid to define some plat data in glue layer.
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index bcda49d..f32317f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -507,7 +507,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
if (of_device_is_compatible(np, "snps,dwmac-4.00") ||
of_device_is_compatible(np, "snps,dwmac-4.10a") ||
- of_device_is_compatible(np, "snps,dwmac-4.20a")) {
+ of_device_is_compatible(np, "snps,dwmac-4.20a") ||
+ of_device_is_compatible(np, "snps,dwmac-5.10a")) {
plat->has_gmac4 = 1;
plat->has_gmac = 0;
plat->pmt = 1;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
@ 2020-05-25 8:22 ` Fugang Duan
0 siblings, 0 replies; 10+ messages in thread
From: Fugang Duan @ 2020-05-25 8:22 UTC (permalink / raw)
To: peppe.cavallaro, alexandre.torgue, joabreu, kuba, davem
Cc: netdev, mcoquelin.stm32, p.zabel, linux-stm32, linux-arm-kernel,
fugang.duan
Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
avoid to define some plat data in glue layer.
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index bcda49d..f32317f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -507,7 +507,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
if (of_device_is_compatible(np, "snps,dwmac-4.00") ||
of_device_is_compatible(np, "snps,dwmac-4.10a") ||
- of_device_is_compatible(np, "snps,dwmac-4.20a")) {
+ of_device_is_compatible(np, "snps,dwmac-4.20a") ||
+ of_device_is_compatible(np, "snps,dwmac-5.10a")) {
plat->has_gmac4 = 1;
plat->has_gmac = 0;
plat->pmt = 1;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
2020-05-25 8:22 ` [PATCH] stmmac: platform: add "snps,dwmac-5.10a" " Fugang Duan
@ 2020-05-25 14:10 ` Andrew Lunn
-1 siblings, 0 replies; 10+ messages in thread
From: Andrew Lunn @ 2020-05-25 14:10 UTC (permalink / raw)
To: Fugang Duan
Cc: p.zabel, alexandre.torgue, netdev, linux-stm32, joabreu,
mcoquelin.stm32, kuba, peppe.cavallaro, davem, linux-arm-kernel
On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
> avoid to define some plat data in glue layer.
Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
@ 2020-05-25 14:10 ` Andrew Lunn
0 siblings, 0 replies; 10+ messages in thread
From: Andrew Lunn @ 2020-05-25 14:10 UTC (permalink / raw)
To: Fugang Duan
Cc: peppe.cavallaro, alexandre.torgue, joabreu, kuba, davem, netdev,
mcoquelin.stm32, p.zabel, linux-stm32, linux-arm-kernel
On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
> avoid to define some plat data in glue layer.
Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
2020-05-25 14:10 ` Andrew Lunn
@ 2020-05-25 16:00 ` Andy Duan
-1 siblings, 0 replies; 10+ messages in thread
From: Andy Duan @ 2020-05-25 16:00 UTC (permalink / raw)
To: Andrew Lunn
Cc: p.zabel@pengutronix.de, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com, kuba@kernel.org,
peppe.cavallaro@st.com, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
From: Andrew Lunn <andrew@lunn.ch> Sent: Monday, May 25, 2020 10:11 PM
> On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> > Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
> > avoid to define some plat data in glue layer.
>
> Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
>
> Andrew
Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a version
since it requires platform specific code to be functional, like the we implement
glue layer driver "dwmac-imx.c" to support 5.10a on i.MX platform.
So I think it doesn't require to add the compatible string into dwmac.yaml.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
@ 2020-05-25 16:00 ` Andy Duan
0 siblings, 0 replies; 10+ messages in thread
From: Andy Duan @ 2020-05-25 16:00 UTC (permalink / raw)
To: Andrew Lunn
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, mcoquelin.stm32@gmail.com,
p.zabel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
From: Andrew Lunn <andrew@lunn.ch> Sent: Monday, May 25, 2020 10:11 PM
> On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> > Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
> > avoid to define some plat data in glue layer.
>
> Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
>
> Andrew
Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a version
since it requires platform specific code to be functional, like the we implement
glue layer driver "dwmac-imx.c" to support 5.10a on i.MX platform.
So I think it doesn't require to add the compatible string into dwmac.yaml.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
2020-05-25 16:00 ` Andy Duan
@ 2020-05-25 16:05 ` Andrew Lunn
-1 siblings, 0 replies; 10+ messages in thread
From: Andrew Lunn @ 2020-05-25 16:05 UTC (permalink / raw)
To: Andy Duan
Cc: p.zabel@pengutronix.de, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com, kuba@kernel.org,
peppe.cavallaro@st.com, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
On Mon, May 25, 2020 at 04:00:29PM +0000, Andy Duan wrote:
> From: Andrew Lunn <andrew@lunn.ch> Sent: Monday, May 25, 2020 10:11 PM
> > On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> > > Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
> > > avoid to define some plat data in glue layer.
> >
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
> >
> > Andrew
>
> Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a version
> since it requires platform specific code to be functional, like the we implement
> glue layer driver "dwmac-imx.c" to support 5.10a on i.MX platform.
>
> So I think it doesn't require to add the compatible string into dwmac.yaml.
Hi Andy
It needs to be documented somewhere. If not
Documentation/devicetree/bindings/net/snps,dwmac.yaml it needs to be
in an NXP specific document.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
@ 2020-05-25 16:05 ` Andrew Lunn
0 siblings, 0 replies; 10+ messages in thread
From: Andrew Lunn @ 2020-05-25 16:05 UTC (permalink / raw)
To: Andy Duan
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, mcoquelin.stm32@gmail.com,
p.zabel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
On Mon, May 25, 2020 at 04:00:29PM +0000, Andy Duan wrote:
> From: Andrew Lunn <andrew@lunn.ch> Sent: Monday, May 25, 2020 10:11 PM
> > On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> > > Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
> > > avoid to define some plat data in glue layer.
> >
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
> >
> > Andrew
>
> Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a version
> since it requires platform specific code to be functional, like the we implement
> glue layer driver "dwmac-imx.c" to support 5.10a on i.MX platform.
>
> So I think it doesn't require to add the compatible string into dwmac.yaml.
Hi Andy
It needs to be documented somewhere. If not
Documentation/devicetree/bindings/net/snps,dwmac.yaml it needs to be
in an NXP specific document.
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
2020-05-25 16:05 ` Andrew Lunn
@ 2020-05-25 16:13 ` Andy Duan
-1 siblings, 0 replies; 10+ messages in thread
From: Andy Duan @ 2020-05-25 16:13 UTC (permalink / raw)
To: Andrew Lunn
Cc: p.zabel@pengutronix.de, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com, kuba@kernel.org,
peppe.cavallaro@st.com, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
From: Andrew Lunn <andrew@lunn.ch> Sent: Tuesday, May 26, 2020 12:06 AM
> On Mon, May 25, 2020 at 04:00:29PM +0000, Andy Duan wrote:
> > From: Andrew Lunn <andrew@lunn.ch> Sent: Monday, May 25, 2020 10:11
> PM
> > > On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> > > > Add "snps,dwmac-5.10a" compatible string for 5.10a version that
> > > > can avoid to define some plat data in glue layer.
> > >
> > > Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
> > >
> > > Andrew
> >
> > Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a
> > version since it requires platform specific code to be functional,
> > like the we implement glue layer driver "dwmac-imx.c" to support 5.10a on
> i.MX platform.
> >
> > So I think it doesn't require to add the compatible string into dwmac.yaml.
>
> Hi Andy
>
> It needs to be documented somewhere. If not
> Documentation/devicetree/bindings/net/snps,dwmac.yaml it needs to be in
> an NXP specific document.
>
> Andrew
Yes, it can be added into NXP binding document.
I wait other's comment for dwmac-imx.c driver review, then will add it together
in next version.
Thanks for your comments.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string
@ 2020-05-25 16:13 ` Andy Duan
0 siblings, 0 replies; 10+ messages in thread
From: Andy Duan @ 2020-05-25 16:13 UTC (permalink / raw)
To: Andrew Lunn
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, mcoquelin.stm32@gmail.com,
p.zabel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
From: Andrew Lunn <andrew@lunn.ch> Sent: Tuesday, May 26, 2020 12:06 AM
> On Mon, May 25, 2020 at 04:00:29PM +0000, Andy Duan wrote:
> > From: Andrew Lunn <andrew@lunn.ch> Sent: Monday, May 25, 2020 10:11
> PM
> > > On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> > > > Add "snps,dwmac-5.10a" compatible string for 5.10a version that
> > > > can avoid to define some plat data in glue layer.
> > >
> > > Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
> > >
> > > Andrew
> >
> > Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a
> > version since it requires platform specific code to be functional,
> > like the we implement glue layer driver "dwmac-imx.c" to support 5.10a on
> i.MX platform.
> >
> > So I think it doesn't require to add the compatible string into dwmac.yaml.
>
> Hi Andy
>
> It needs to be documented somewhere. If not
> Documentation/devicetree/bindings/net/snps,dwmac.yaml it needs to be in
> an NXP specific document.
>
> Andrew
Yes, it can be added into NXP binding document.
I wait other's comment for dwmac-imx.c driver review, then will add it together
in next version.
Thanks for your comments.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-05-25 16:13 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-25 8:22 [PATCH] stmmac: platform: add "snps, dwmac-5.10a" IP compatible string Fugang Duan
2020-05-25 8:22 ` [PATCH] stmmac: platform: add "snps,dwmac-5.10a" " Fugang Duan
2020-05-25 14:10 ` Andrew Lunn
2020-05-25 14:10 ` Andrew Lunn
2020-05-25 16:00 ` [EXT] " Andy Duan
2020-05-25 16:00 ` Andy Duan
2020-05-25 16:05 ` Andrew Lunn
2020-05-25 16:05 ` Andrew Lunn
2020-05-25 16:13 ` Andy Duan
2020-05-25 16:13 ` Andy Duan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.