From: Leon Romanovsky <leonro@mellanox.com>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@mellanox.com>
Cc: rds-devel@oss.oracle.com, Bart Van Assche <bvanassche@acm.org>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
target-devel@vger.kernel.org,
Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Jakub Kicinski <kuba@kernel.org>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"David S. Miller" <davem@davemloft.net>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH rdma-next v3 6/6] RDMA/cma: Provide ECE reject reason
Date: Tue, 26 May 2020 14:36:28 +0300 [thread overview]
Message-ID: <20200526113628.GC100179@unreal> (raw)
In-Reply-To: <20200526103304.196371-7-leon@kernel.org>
On Tue, May 26, 2020 at 01:33:04PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> IBTA declares "vendor option not supported" reject reason in REJ
> messages if passive side doesn't want to accept proposed ECE options.
>
> Due to the fact that ECE is managed by userspace, there is a need to let
> users to provide such rejected reason.
>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/core/cma.c | 9 ++++-----
> drivers/infiniband/core/ucma.c | 15 ++++++++++++++-
> drivers/infiniband/ulp/isert/ib_isert.c | 4 ++--
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +-
> drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ++-
> drivers/nvme/target/rdma.c | 3 ++-
> include/rdma/rdma_cm.h | 2 +-
> include/uapi/rdma/rdma_user_cm.h | 3 ++-
> net/rds/ib_cm.c | 4 +++-
> 9 files changed, 31 insertions(+), 14 deletions(-)
For some reason didn't get the failure in CI, this small fixup is
needed.
commit af02a4a50ec0d18fe9bfb86b96411dfb42054f97 (HEAD -> rdma-next)
Author: Leon Romanovsky <leon@kernel.org>
Date: Tue May 26 14:34:34 2020 +0300
fixup! RDMA/cma: Provide ECE reject reason
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 30a0a9adaddd..d84765f66d49 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -18,6 +18,7 @@
#include <asm/unaligned.h>
#include <rdma/ib_verbs.h>
+#include <rdma/ib_cm.h>
#include <rdma/rdma_cm.h>
#include <rdma/rw.h>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leonro@mellanox.com>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@mellanox.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Christoph Hellwig <hch@lst.de>,
Danil Kipnis <danil.kipnis@cloud.ionos.com>,
"David S. Miller" <davem@davemloft.net>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
Sagi Grimberg <sagi@grimberg.me>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
target-devel@vger.kernel.org
Subject: Re: [PATCH rdma-next v3 6/6] RDMA/cma: Provide ECE reject reason
Date: Tue, 26 May 2020 14:36:28 +0300 [thread overview]
Message-ID: <20200526113628.GC100179@unreal> (raw)
In-Reply-To: <20200526103304.196371-7-leon@kernel.org>
On Tue, May 26, 2020 at 01:33:04PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> IBTA declares "vendor option not supported" reject reason in REJ
> messages if passive side doesn't want to accept proposed ECE options.
>
> Due to the fact that ECE is managed by userspace, there is a need to let
> users to provide such rejected reason.
>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/core/cma.c | 9 ++++-----
> drivers/infiniband/core/ucma.c | 15 ++++++++++++++-
> drivers/infiniband/ulp/isert/ib_isert.c | 4 ++--
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +-
> drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ++-
> drivers/nvme/target/rdma.c | 3 ++-
> include/rdma/rdma_cm.h | 2 +-
> include/uapi/rdma/rdma_user_cm.h | 3 ++-
> net/rds/ib_cm.c | 4 +++-
> 9 files changed, 31 insertions(+), 14 deletions(-)
For some reason didn't get the failure in CI, this small fixup is
needed.
commit af02a4a50ec0d18fe9bfb86b96411dfb42054f97 (HEAD -> rdma-next)
Author: Leon Romanovsky <leon@kernel.org>
Date: Tue May 26 14:34:34 2020 +0300
fixup! RDMA/cma: Provide ECE reject reason
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 30a0a9adaddd..d84765f66d49 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -18,6 +18,7 @@
#include <asm/unaligned.h>
#include <rdma/ib_verbs.h>
+#include <rdma/ib_cm.h>
#include <rdma/rdma_cm.h>
#include <rdma/rw.h>
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leonro@mellanox.com>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@mellanox.com>
Cc: rds-devel@oss.oracle.com, Bart Van Assche <bvanassche@acm.org>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
target-devel@vger.kernel.org,
Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Jakub Kicinski <kuba@kernel.org>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"David S. Miller" <davem@davemloft.net>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH rdma-next v3 6/6] RDMA/cma: Provide ECE reject reason
Date: Tue, 26 May 2020 11:36:28 +0000 [thread overview]
Message-ID: <20200526113628.GC100179@unreal> (raw)
In-Reply-To: <20200526103304.196371-7-leon@kernel.org>
On Tue, May 26, 2020 at 01:33:04PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> IBTA declares "vendor option not supported" reject reason in REJ
> messages if passive side doesn't want to accept proposed ECE options.
>
> Due to the fact that ECE is managed by userspace, there is a need to let
> users to provide such rejected reason.
>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/core/cma.c | 9 ++++-----
> drivers/infiniband/core/ucma.c | 15 ++++++++++++++-
> drivers/infiniband/ulp/isert/ib_isert.c | 4 ++--
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +-
> drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ++-
> drivers/nvme/target/rdma.c | 3 ++-
> include/rdma/rdma_cm.h | 2 +-
> include/uapi/rdma/rdma_user_cm.h | 3 ++-
> net/rds/ib_cm.c | 4 +++-
> 9 files changed, 31 insertions(+), 14 deletions(-)
For some reason didn't get the failure in CI, this small fixup is
needed.
commit af02a4a50ec0d18fe9bfb86b96411dfb42054f97 (HEAD -> rdma-next)
Author: Leon Romanovsky <leon@kernel.org>
Date: Tue May 26 14:34:34 2020 +0300
fixup! RDMA/cma: Provide ECE reject reason
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 30a0a9adaddd..d84765f66d49 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -18,6 +18,7 @@
#include <asm/unaligned.h>
#include <rdma/ib_verbs.h>
+#include <rdma/ib_cm.h>
#include <rdma/rdma_cm.h>
#include <rdma/rw.h>
next prev parent reply other threads:[~2020-05-26 11:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 10:32 [PATCH rdma-next v3 0/6] Add Enhanced Connection Established (ECE) Leon Romanovsky
2020-05-26 10:32 ` Leon Romanovsky
2020-05-26 10:32 ` Leon Romanovsky
2020-05-26 10:32 ` [PATCH rdma-next v3 1/6] RDMA/cm: Add Enhanced Connection Establishment (ECE) bits Leon Romanovsky
2020-05-26 10:33 ` [PATCH rdma-next v3 2/6] RDMA/ucma: Extend ucma_connect to receive ECE parameters Leon Romanovsky
2020-05-26 10:33 ` [PATCH rdma-next v3 3/6] RDMA/ucma: Deliver ECE parameters through UCMA events Leon Romanovsky
2020-05-26 10:33 ` [PATCH rdma-next v3 4/6] RDMA/cm: Send and receive ECE parameter over the wire Leon Romanovsky
2020-05-26 10:33 ` [PATCH rdma-next v3 5/6] RDMA/cma: Connect ECE to rdma_accept Leon Romanovsky
2020-05-26 10:33 ` [PATCH rdma-next v3 6/6] RDMA/cma: Provide ECE reject reason Leon Romanovsky
2020-05-26 10:33 ` Leon Romanovsky
2020-05-26 10:33 ` Leon Romanovsky
2020-05-26 11:36 ` Leon Romanovsky [this message]
2020-05-26 11:36 ` Leon Romanovsky
2020-05-26 11:36 ` Leon Romanovsky
2020-05-26 12:07 ` Leon Romanovsky
2020-05-26 12:07 ` Leon Romanovsky
2020-05-26 12:07 ` Leon Romanovsky
2020-05-27 12:25 ` kbuild test robot
2020-05-27 19:14 ` [PATCH rdma-next v3 0/6] Add Enhanced Connection Established (ECE) Jason Gunthorpe
2020-05-27 19:14 ` Jason Gunthorpe
2020-05-27 19:14 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526113628.GC100179@unreal \
--to=leonro@mellanox.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=danil.kipnis@cloud.ionos.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sagi@grimberg.me \
--cc=santosh.shilimkar@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.