From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH mm v5 RESEND 3/4] mm: move cgroup high memory limit setting into struct page_counter
Date: Tue, 26 May 2020 10:42:20 -0400 [thread overview]
Message-ID: <20200526144220.GC848026@cmpxchg.org> (raw)
In-Reply-To: <20200521002411.3963032-4-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Wed, May 20, 2020 at 05:24:10PM -0700, Jakub Kicinski wrote:
> High memory limit is currently recorded directly in
> struct mem_cgroup. We are about to add a high limit
> for swap, move the field to struct page_counter and
> add some helpers.
>
> Signed-off-by: Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Reviewed-by: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
This move is overdue and should make it easier to integrate high
reclaim better into the existing max reclaim flow as well. Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
kernel-team@fb.com, tj@kernel.org, chris@chrisdown.name,
cgroups@vger.kernel.org, shakeelb@google.com, mhocko@kernel.org
Subject: Re: [PATCH mm v5 RESEND 3/4] mm: move cgroup high memory limit setting into struct page_counter
Date: Tue, 26 May 2020 10:42:20 -0400 [thread overview]
Message-ID: <20200526144220.GC848026@cmpxchg.org> (raw)
In-Reply-To: <20200521002411.3963032-4-kuba@kernel.org>
On Wed, May 20, 2020 at 05:24:10PM -0700, Jakub Kicinski wrote:
> High memory limit is currently recorded directly in
> struct mem_cgroup. We are about to add a high limit
> for swap, move the field to struct page_counter and
> add some helpers.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
This move is overdue and should make it easier to integrate high
reclaim better into the existing max reclaim flow as well. Thanks!
next prev parent reply other threads:[~2020-05-26 14:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 0:24 [PATCH mm v5 RESEND 0/4] memcg: Slow down swap allocation as the available space gets depleted Jakub Kicinski
2020-05-21 0:24 ` Jakub Kicinski
[not found] ` <20200521002411.3963032-1-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-05-21 0:24 ` [PATCH mm v5 RESEND 1/4] mm: prepare for swap over-high accounting and penalty calculation Jakub Kicinski
2020-05-21 0:24 ` Jakub Kicinski
[not found] ` <20200521002411.3963032-2-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-05-26 14:35 ` Johannes Weiner
2020-05-26 14:35 ` Johannes Weiner
2020-05-21 0:24 ` [PATCH mm v5 RESEND 2/4] mm: move penalty delay clamping out of calculate_high_delay() Jakub Kicinski
2020-05-21 0:24 ` Jakub Kicinski
[not found] ` <20200521002411.3963032-3-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-05-26 14:36 ` Johannes Weiner
2020-05-26 14:36 ` Johannes Weiner
2020-05-21 0:24 ` [PATCH mm v5 RESEND 3/4] mm: move cgroup high memory limit setting into struct page_counter Jakub Kicinski
2020-05-21 0:24 ` Jakub Kicinski
[not found] ` <20200521002411.3963032-4-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-05-26 14:42 ` Johannes Weiner [this message]
2020-05-26 14:42 ` Johannes Weiner
2020-05-21 0:24 ` [PATCH mm v5 RESEND 4/4] mm: automatically penalize tasks with high swap use Jakub Kicinski
2020-05-21 0:24 ` Jakub Kicinski
[not found] ` <20200521002411.3963032-5-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-05-26 15:33 ` Johannes Weiner
2020-05-26 15:33 ` Johannes Weiner
[not found] ` <20200526153309.GD848026-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2020-05-26 20:11 ` Jakub Kicinski
2020-05-26 20:11 ` Jakub Kicinski
[not found] ` <20200526131157.79c17940-CbGlpYbfshD2+ikPA6JUzBDio8TIggjEF6tAq0aKN46Iz3nRy94yXOTW4wlIGRCZ@public.gmane.org>
2020-05-27 15:51 ` Johannes Weiner
2020-05-27 15:51 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526144220.GC848026@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.