Re: [net-next RFC v3 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)

[Vadym Kochan <vadym.kochan@plvision.eu>]

Thanks Jakub!

I fixed these locally, should I wait a bit for other comments
before sending next version ?

On Tue, May 26, 2020 at 11:35:12AM -0700, Jakub Kicinski wrote:
> On Tue, 26 May 2020 20:12:56 +0300 Vadym Kochan wrote:
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
> > wireless SMB deployment.
> 
> This series adds lots of warnings when built with W=1, please make sure
> every individual patch builds cleanly.
> 
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:38:24: warning: symbol 'prestera_devlink_alloc' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:47:6: warning: symbol 'prestera_devlink_free' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:54:5: warning: symbol 'prestera_devlink_register' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:68:6: warning: symbol 'prestera_devlink_unregister' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:75:5: warning: symbol 'prestera_devlink_port_register' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:95:6: warning: symbol 'prestera_devlink_port_unregister' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:100:6: warning: symbol 'prestera_devlink_port_type_set' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:105:21: warning: symbol 'prestera_devlink_get_port' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:656:5: warning: symbol 'prestera_sdma_switch_init' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:716:6: warning: symbol 'prestera_sdma_switch_fini' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:755:13: warning: symbol 'prestera_sdma_xmit' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:812:5: warning: symbol 'prestera_rxtx_switch_init' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:825:6: warning: symbol 'prestera_rxtx_switch_fini' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:831:5: warning: symbol 'prestera_rxtx_port_init' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:843:13: warning: symbol 'prestera_rxtx_xmit' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:38:25: warning: no previous prototype for ‘prestera_devlink_alloc’ [-Wmissing-prototypes]
>    38 | struct prestera_switch *prestera_devlink_alloc(void)
>       |                         ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:47:6: warning: no previous prototype for ‘prestera_devlink_free’ [-Wmissing-prototypes]
>    47 | void prestera_devlink_free(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:54:5: warning: no previous prototype for ‘prestera_devlink_register’ [-Wmissing-prototypes]
>    54 | int prestera_devlink_register(struct prestera_switch *sw)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:68:6: warning: no previous prototype for ‘prestera_devlink_unregister’ [-Wmissing-prototypes]
>    68 | void prestera_devlink_unregister(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:75:5: warning: no previous prototype for ‘prestera_devlink_port_register’ [-Wmissing-prototypes]
>    75 | int prestera_devlink_port_register(struct prestera_port *port)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:95:6: warning: no previous prototype for ‘prestera_devlink_port_unregister’ [-Wmissing-prototypes]
>    95 | void prestera_devlink_port_unregister(struct prestera_port *port)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:100:6: warning: no previous prototype for ‘prestera_devlink_port_type_set’ [-Wmissing-prototypes]
>   100 | void prestera_devlink_port_type_set(struct prestera_port *port)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:105:22: warning: no previous prototype for ‘prestera_devlink_get_port’ [-Wmissing-prototypes]
>   105 | struct devlink_port *prestera_devlink_get_port(struct net_device *dev)
>       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c: In function ‘prestera_sdma_tx_recycle_work_fn’:
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:535:17: warning: variable ‘dma_dev’ set but not used [-Wunused-but-set-variable]
>   535 |  struct device *dma_dev;
>       |                 ^~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c: At top level:
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:656:5: warning: no previous prototype for ‘prestera_sdma_switch_init’ [-Wmissing-prototypes]
>   656 | int prestera_sdma_switch_init(struct prestera_switch *sw)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:716:6: warning: no previous prototype for ‘prestera_sdma_switch_fini’ [-Wmissing-prototypes]
>   716 | void prestera_sdma_switch_fini(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:755:13: warning: no previous prototype for ‘prestera_sdma_xmit’ [-Wmissing-prototypes]
>   755 | netdev_tx_t prestera_sdma_xmit(struct prestera_sdma *sdma, struct sk_buff *skb)
>       |             ^~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:812:5: warning: no previous prototype for ‘prestera_rxtx_switch_init’ [-Wmissing-prototypes]
>   812 | int prestera_rxtx_switch_init(struct prestera_switch *sw)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:825:6: warning: no previous prototype for ‘prestera_rxtx_switch_fini’ [-Wmissing-prototypes]
>   825 | void prestera_rxtx_switch_fini(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:831:5: warning: no previous prototype for ‘prestera_rxtx_port_init’ [-Wmissing-prototypes]
>   831 | int prestera_rxtx_port_init(struct prestera_port *port)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:843:13: warning: no previous prototype for ‘prestera_rxtx_xmit’ [-Wmissing-prototypes]
>   843 | netdev_tx_t prestera_rxtx_xmit(struct prestera_port *port, struct sk_buff *skb)
>       |             ^~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:296:6: warning: symbol 'prestera_ethtool_get_drvinfo' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:473:5: warning: symbol 'prestera_ethtool_get_link_ksettings' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:598:5: warning: symbol 'prestera_ethtool_set_link_ksettings' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:634:5: warning: symbol 'prestera_ethtool_get_fecparam' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:661:5: warning: symbol 'prestera_ethtool_set_fecparam' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:696:5: warning: symbol 'prestera_ethtool_get_sset_count' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:706:6: warning: symbol 'prestera_ethtool_get_strings' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:715:6: warning: symbol 'prestera_ethtool_get_stats' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:726:5: warning: symbol 'prestera_ethtool_nway_reset' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:296:6: warning: no previous prototype for ‘prestera_ethtool_get_drvinfo’ [-Wmissing-prototypes]
>   296 | void prestera_ethtool_get_drvinfo(struct net_device *dev,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:473:5: warning: no previous prototype for ‘prestera_ethtool_get_link_ksettings’ [-Wmissing-prototypes]
>   473 | int prestera_ethtool_get_link_ksettings(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:598:5: warning: no previous prototype for ‘prestera_ethtool_set_link_ksettings’ [-Wmissing-prototypes]
>   598 | int prestera_ethtool_set_link_ksettings(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:634:5: warning: no previous prototype for ‘prestera_ethtool_get_fecparam’ [-Wmissing-prototypes]
>   634 | int prestera_ethtool_get_fecparam(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:661:5: warning: no previous prototype for ‘prestera_ethtool_set_fecparam’ [-Wmissing-prototypes]
>   661 | int prestera_ethtool_set_fecparam(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:696:5: warning: no previous prototype for ‘prestera_ethtool_get_sset_count’ [-Wmissing-prototypes]
>   696 | int prestera_ethtool_get_sset_count(struct net_device *dev, int sset)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:706:6: warning: no previous prototype for ‘prestera_ethtool_get_strings’ [-Wmissing-prototypes]
>   706 | void prestera_ethtool_get_strings(struct net_device *dev,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:715:6: warning: no previous prototype for ‘prestera_ethtool_get_stats’ [-Wmissing-prototypes]
>   715 | void prestera_ethtool_get_stats(struct net_device *dev,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:726:5: warning: no previous prototype for ‘prestera_ethtool_nway_reset’ [-Wmissing-prototypes]
>   726 | int prestera_ethtool_nway_reset(struct net_device *dev)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_pci.c: In function ‘prestera_fw_rev_check’:
> ../drivers/net/ethernet/marvell/prestera/prestera_pci.c:590:15: warning: comparison is always true due to limited range of data type [-Wtype-limits]
>   590 |      rev->min >= PRESTERA_SUPP_FW_MIN_VER) {
>       |               ^~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:656:5: warning: symbol 'prestera_sdma_switch_init' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:716:6: warning: symbol 'prestera_sdma_switch_fini' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:755:13: warning: symbol 'prestera_sdma_xmit' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:812:5: warning: symbol 'prestera_rxtx_switch_init' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:825:6: warning: symbol 'prestera_rxtx_switch_fini' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:831:5: warning: symbol 'prestera_rxtx_port_init' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:843:13: warning: symbol 'prestera_rxtx_xmit' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:296:6: warning: symbol 'prestera_ethtool_get_drvinfo' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:473:5: warning: symbol 'prestera_ethtool_get_link_ksettings' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:598:5: warning: symbol 'prestera_ethtool_set_link_ksettings' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:634:5: warning: symbol 'prestera_ethtool_get_fecparam' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:661:5: warning: symbol 'prestera_ethtool_set_fecparam' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:696:5: warning: symbol 'prestera_ethtool_get_sset_count' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:706:6: warning: symbol 'prestera_ethtool_get_strings' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:715:6: warning: symbol 'prestera_ethtool_get_stats' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:726:5: warning: symbol 'prestera_ethtool_nway_reset' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:38:24: warning: symbol 'prestera_devlink_alloc' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:47:6: warning: symbol 'prestera_devlink_free' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:54:5: warning: symbol 'prestera_devlink_register' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:68:6: warning: symbol 'prestera_devlink_unregister' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:75:5: warning: symbol 'prestera_devlink_port_register' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:95:6: warning: symbol 'prestera_devlink_port_unregister' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:100:6: warning: symbol 'prestera_devlink_port_type_set' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:105:21: warning: symbol 'prestera_devlink_get_port' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:214:6: warning: symbol 'prestera_port_vlan_destroy' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:288:24: warning: symbol 'prestera_bridge_by_dev' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:537:5: warning: symbol 'prestera_bridge_port_event' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1238:5: warning: symbol 'prestera_switchdev_init' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1276:6: warning: symbol 'prestera_switchdev_fini' was not declared. Should it be static?
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:38:25: warning: no previous prototype for ‘prestera_devlink_alloc’ [-Wmissing-prototypes]
>    38 | struct prestera_switch *prestera_devlink_alloc(void)
>       |                         ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:47:6: warning: no previous prototype for ‘prestera_devlink_free’ [-Wmissing-prototypes]
>    47 | void prestera_devlink_free(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:54:5: warning: no previous prototype for ‘prestera_devlink_register’ [-Wmissing-prototypes]
>    54 | int prestera_devlink_register(struct prestera_switch *sw)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:68:6: warning: no previous prototype for ‘prestera_devlink_unregister’ [-Wmissing-prototypes]
>    68 | void prestera_devlink_unregister(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:75:5: warning: no previous prototype for ‘prestera_devlink_port_register’ [-Wmissing-prototypes]
>    75 | int prestera_devlink_port_register(struct prestera_port *port)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:95:6: warning: no previous prototype for ‘prestera_devlink_port_unregister’ [-Wmissing-prototypes]
>    95 | void prestera_devlink_port_unregister(struct prestera_port *port)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:100:6: warning: no previous prototype for ‘prestera_devlink_port_type_set’ [-Wmissing-prototypes]
>   100 | void prestera_devlink_port_type_set(struct prestera_port *port)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_devlink.c:105:22: warning: no previous prototype for ‘prestera_devlink_get_port’ [-Wmissing-prototypes]
>   105 | struct devlink_port *prestera_devlink_get_port(struct net_device *dev)
>       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:296:6: warning: no previous prototype for ‘prestera_ethtool_get_drvinfo’ [-Wmissing-prototypes]
>   296 | void prestera_ethtool_get_drvinfo(struct net_device *dev,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:473:5: warning: no previous prototype for ‘prestera_ethtool_get_link_ksettings’ [-Wmissing-prototypes]
>   473 | int prestera_ethtool_get_link_ksettings(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:598:5: warning: no previous prototype for ‘prestera_ethtool_set_link_ksettings’ [-Wmissing-prototypes]
>   598 | int prestera_ethtool_set_link_ksettings(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:634:5: warning: no previous prototype for ‘prestera_ethtool_get_fecparam’ [-Wmissing-prototypes]
>   634 | int prestera_ethtool_get_fecparam(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:661:5: warning: no previous prototype for ‘prestera_ethtool_set_fecparam’ [-Wmissing-prototypes]
>   661 | int prestera_ethtool_set_fecparam(struct net_device *dev,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:696:5: warning: no previous prototype for ‘prestera_ethtool_get_sset_count’ [-Wmissing-prototypes]
>   696 | int prestera_ethtool_get_sset_count(struct net_device *dev, int sset)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:706:6: warning: no previous prototype for ‘prestera_ethtool_get_strings’ [-Wmissing-prototypes]
>   706 | void prestera_ethtool_get_strings(struct net_device *dev,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:715:6: warning: no previous prototype for ‘prestera_ethtool_get_stats’ [-Wmissing-prototypes]
>   715 | void prestera_ethtool_get_stats(struct net_device *dev,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_ethtool.c:726:5: warning: no previous prototype for ‘prestera_ethtool_nway_reset’ [-Wmissing-prototypes]
>   726 | int prestera_ethtool_nway_reset(struct net_device *dev)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c: In function ‘prestera_sdma_tx_recycle_work_fn’:
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:535:17: warning: variable ‘dma_dev’ set but not used [-Wunused-but-set-variable]
>   535 |  struct device *dma_dev;
>       |                 ^~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c: At top level:
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:656:5: warning: no previous prototype for ‘prestera_sdma_switch_init’ [-Wmissing-prototypes]
>   656 | int prestera_sdma_switch_init(struct prestera_switch *sw)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:716:6: warning: no previous prototype for ‘prestera_sdma_switch_fini’ [-Wmissing-prototypes]
>   716 | void prestera_sdma_switch_fini(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:755:13: warning: no previous prototype for ‘prestera_sdma_xmit’ [-Wmissing-prototypes]
>   755 | netdev_tx_t prestera_sdma_xmit(struct prestera_sdma *sdma, struct sk_buff *skb)
>       |             ^~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:812:5: warning: no previous prototype for ‘prestera_rxtx_switch_init’ [-Wmissing-prototypes]
>   812 | int prestera_rxtx_switch_init(struct prestera_switch *sw)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:825:6: warning: no previous prototype for ‘prestera_rxtx_switch_fini’ [-Wmissing-prototypes]
>   825 | void prestera_rxtx_switch_fini(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:831:5: warning: no previous prototype for ‘prestera_rxtx_port_init’ [-Wmissing-prototypes]
>   831 | int prestera_rxtx_port_init(struct prestera_port *port)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_rxtx.c:843:13: warning: no previous prototype for ‘prestera_rxtx_xmit’ [-Wmissing-prototypes]
>   843 | netdev_tx_t prestera_rxtx_xmit(struct prestera_port *port, struct sk_buff *skb)
>       |             ^~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_pci.c: In function ‘prestera_fw_rev_check’:
> ../drivers/net/ethernet/marvell/prestera/prestera_pci.c:590:15: warning: comparison is always true due to limited range of data type [-Wtype-limits]
>   590 |      rev->min >= PRESTERA_SUPP_FW_MIN_VER) {
>       |               ^~
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:214:6: warning: no previous prototype for ‘prestera_port_vlan_destroy’ [-Wmissing-prototypes]
>   214 | void prestera_port_vlan_destroy(struct prestera_port_vlan *port_vlan)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:288:25: warning: no previous prototype for ‘prestera_bridge_by_dev’ [-Wmissing-prototypes]
>   288 | struct prestera_bridge *prestera_bridge_by_dev(struct prestera_switchdev *swdev,
>       |                         ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:537:5: warning: no previous prototype for ‘prestera_bridge_port_event’ [-Wmissing-prototypes]
>   537 | int prestera_bridge_port_event(struct net_device *dev, unsigned long event,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1238:5: warning: no previous prototype for ‘prestera_switchdev_init’ [-Wmissing-prototypes]
>  1238 | int prestera_switchdev_init(struct prestera_switch *sw)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1276:6: warning: no previous prototype for ‘prestera_switchdev_fini’ [-Wmissing-prototypes]
>  1276 | void prestera_switchdev_fini(struct prestera_switch *sw)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~