Re: [net-next RFC v3 3/6] net: marvell: prestera: Add basic devlink support

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5709 bytes --]

Hi Vadym,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master sparc-next/master linus/master v5.7-rc7 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Vadym-Kochan/net-marvell-prestera-Add-Switchdev-driver-for-Prestera-family-ASIC-device-98DX326x-AC3x/20200527-014008
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d52caf0404e625bcda352ebea53be25e91f9de02
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:38:25: warning: no previous prototype for 'prestera_devlink_alloc' [-Wmissing-prototypes]
38 | struct prestera_switch *prestera_devlink_alloc(void)
|                         ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:47:6: warning: no previous prototype for 'prestera_devlink_free' [-Wmissing-prototypes]
47 | void prestera_devlink_free(struct prestera_switch *sw)
|      ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:54:5: warning: no previous prototype for 'prestera_devlink_register' [-Wmissing-prototypes]
54 | int prestera_devlink_register(struct prestera_switch *sw)
|     ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:68:6: warning: no previous prototype for 'prestera_devlink_unregister' [-Wmissing-prototypes]
68 | void prestera_devlink_unregister(struct prestera_switch *sw)
|      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:75:5: warning: no previous prototype for 'prestera_devlink_port_register' [-Wmissing-prototypes]
75 | int prestera_devlink_port_register(struct prestera_port *port)
|     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:95:6: warning: no previous prototype for 'prestera_devlink_port_unregister' [-Wmissing-prototypes]
95 | void prestera_devlink_port_unregister(struct prestera_port *port)
|      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:100:6: warning: no previous prototype for 'prestera_devlink_port_type_set' [-Wmissing-prototypes]
100 | void prestera_devlink_port_type_set(struct prestera_port *port)
|      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:105:22: warning: no previous prototype for 'prestera_devlink_get_port' [-Wmissing-prototypes]
105 | struct devlink_port *prestera_devlink_get_port(struct net_device *dev)
|                      ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/prestera_devlink_alloc +38 drivers/net/ethernet/marvell/prestera/prestera_devlink.c

    37	
  > 38	struct prestera_switch *prestera_devlink_alloc(void)
    39	{
    40		struct devlink *dl;
    41	
    42		dl = devlink_alloc(&prestera_dl_ops, sizeof(struct prestera_switch));
    43	
    44		return devlink_priv(dl);
    45	}
    46	
  > 47	void prestera_devlink_free(struct prestera_switch *sw)
    48	{
    49		struct devlink *dl = priv_to_devlink(sw);
    50	
    51		devlink_free(dl);
    52	}
    53	
  > 54	int prestera_devlink_register(struct prestera_switch *sw)
    55	{
    56		struct devlink *dl = priv_to_devlink(sw);
    57		int err;
    58	
    59		err = devlink_register(dl, sw->dev->dev);
    60		if (err) {
    61			dev_warn(sw->dev->dev, "devlink_register failed: %d\n", err);
    62			return err;
    63		}
    64	
    65		return 0;
    66	}
    67	
  > 68	void prestera_devlink_unregister(struct prestera_switch *sw)
    69	{
    70		struct devlink *dl = priv_to_devlink(sw);
    71	
    72		devlink_unregister(dl);
    73	}
    74	
  > 75	int prestera_devlink_port_register(struct prestera_port *port)
    76	{
    77		struct devlink *dl = priv_to_devlink(port->sw);
    78		struct prestera_switch *sw;
    79		int err;
    80	
    81		sw = port->sw;
    82		dl = priv_to_devlink(sw);
    83	
    84		devlink_port_attrs_set(&port->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL,
    85				       port->fp_id, false, 0,
    86				       &port->sw->id, sizeof(port->sw->id));
    87	
    88		err = devlink_port_register(dl, &port->dl_port, port->fp_id);
    89		if (err)
    90			dev_err(sw->dev->dev, "devlink_port_register failed: %d\n", err);
    91	
    92		return 0;
    93	}
    94	
  > 95	void prestera_devlink_port_unregister(struct prestera_port *port)
    96	{
    97		devlink_port_unregister(&port->dl_port);
    98	}
    99	
 > 100	void prestera_devlink_port_type_set(struct prestera_port *port)
   101	{
   102		devlink_port_type_eth_set(&port->dl_port, port->dev);
   103	}
   104	
 > 105	struct devlink_port *prestera_devlink_get_port(struct net_device *dev)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 63484 bytes --]