* [Buildroot] [PATCH] board/freescale: increase the vfat size @ 2020-05-26 21:01 Fabio Estevam 2020-05-26 21:18 ` Yann E. MORIN 2020-06-01 20:06 ` Peter Korsgaard 0 siblings, 2 replies; 4+ messages in thread From: Fabio Estevam @ 2020-05-26 21:01 UTC (permalink / raw) To: buildroot i.MX8 targets typically use the standard ARM64 defconfig, which builds lots of ARM64 platforms leading to super large kernels that can easily not fit within the current 32MB size for vfat. Increase the vfat size to better accomodate such large kernels. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- board/freescale/common/imx/genimage.cfg.template_imx8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8 index 84a812f986..5689205083 100644 --- a/board/freescale/common/imx/genimage.cfg.template_imx8 +++ b/board/freescale/common/imx/genimage.cfg.template_imx8 @@ -14,7 +14,7 @@ image boot.vfat { %FILES% } } - size = 32M + size = 64M } image sdcard.img { -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] board/freescale: increase the vfat size 2020-05-26 21:01 [Buildroot] [PATCH] board/freescale: increase the vfat size Fabio Estevam @ 2020-05-26 21:18 ` Yann E. MORIN 2020-05-26 21:26 ` Fabio Estevam 2020-06-01 20:06 ` Peter Korsgaard 1 sibling, 1 reply; 4+ messages in thread From: Yann E. MORIN @ 2020-05-26 21:18 UTC (permalink / raw) To: buildroot Fabio, All, On 2020-05-26 18:01 -0300, Fabio Estevam spake thusly: > i.MX8 targets typically use the standard ARM64 defconfig, which builds > lots of ARM64 platforms leading to super large kernels that can easily > not fit within the current 32MB size for vfat. > > Increase the vfat size to better accomodate such large kernels. The genimage config files we have do accomodate the needs for the defconfigs they are used in. So, if all the in-tree defconfigs still build with the current size,t this is OK. That a user then tweaks it locally for their use-case, is not a reason IMHO to carry such a change. So, question: does this fix an actual build failure of any of the i.MX8 defconfig that we have in-tree in Buildroot? If so, then this should be explcictly stated in the commit log. Otherwise, there is no reason to catter for out-of-tree use-cases, otherwise there will always be someone that come next and state "This package makes sense for my use-case, but it does not fit in the default size, so increase it". This is not tenable. Still, 32M is quite low for today's standards, and we want users to be relatively at ease to experiment on the default image anyway. So: applied to master, with a slightly tweaked commit log. Thanks. Regards, Yann E. MORIN. > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > board/freescale/common/imx/genimage.cfg.template_imx8 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8 > index 84a812f986..5689205083 100644 > --- a/board/freescale/common/imx/genimage.cfg.template_imx8 > +++ b/board/freescale/common/imx/genimage.cfg.template_imx8 > @@ -14,7 +14,7 @@ image boot.vfat { > %FILES% > } > } > - size = 32M > + size = 64M > } > > image sdcard.img { > -- > 2.17.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] board/freescale: increase the vfat size 2020-05-26 21:18 ` Yann E. MORIN @ 2020-05-26 21:26 ` Fabio Estevam 0 siblings, 0 replies; 4+ messages in thread From: Fabio Estevam @ 2020-05-26 21:26 UTC (permalink / raw) To: buildroot Hi Yann, On Tue, May 26, 2020 at 6:18 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > So, question: does this fix an actual build failure of any of the i.MX8 > defconfig that we have in-tree in Buildroot? If so, then this should be > explcictly stated in the commit log. I noticed this problem when trying to flash a kernel generated by the standard 'defconfig' from an NXP internal tree. The kernel size was around 35MB. Soon this kernel will be publicly available and we will need to increase the vfat size to accommodate it. Thanks for applying it! ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] board/freescale: increase the vfat size 2020-05-26 21:01 [Buildroot] [PATCH] board/freescale: increase the vfat size Fabio Estevam 2020-05-26 21:18 ` Yann E. MORIN @ 2020-06-01 20:06 ` Peter Korsgaard 1 sibling, 0 replies; 4+ messages in thread From: Peter Korsgaard @ 2020-06-01 20:06 UTC (permalink / raw) To: buildroot >>>>> "Fabio" == Fabio Estevam <festevam@gmail.com> writes: > i.MX8 targets typically use the standard ARM64 defconfig, which builds > lots of ARM64 platforms leading to super large kernels that can easily > not fit within the current 32MB size for vfat. > Increase the vfat size to better accomodate such large kernels. > Signed-off-by: Fabio Estevam <festevam@gmail.com> Committed to 2020.02.x, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-01 20:06 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-05-26 21:01 [Buildroot] [PATCH] board/freescale: increase the vfat size Fabio Estevam 2020-05-26 21:18 ` Yann E. MORIN 2020-05-26 21:26 ` Fabio Estevam 2020-06-01 20:06 ` Peter Korsgaard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.