From: Wolfram Sang <wsa@the-dreams.de>
To: Laine Jaakko EXT <ext-jaakko.laine@vaisala.com>
Cc: Rob Herring <robh@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] i2c: xiic: Support disabling multi-master in DT
Date: Wed, 27 May 2020 13:07:32 +0200 [thread overview]
Message-ID: <20200527110732.GA4875@ninjato> (raw)
In-Reply-To: <AM0PR06MB51857F4CDC7AE643CE160F9ED4A60@AM0PR06MB5185.eurprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]
Hi Jaako,
> The changes required to this patch at XIIC driver from suggested DT
> changes are pretty minor. Basically only checking a different
> property, reversing logic and some naming changes. I can make these
> changes already for the driver if this solution is what will be
> chosen, or would you prefer to still think about this?
I think we can go forward this way. Although I didn't find an example, I
am quite sure YAML format can have exclusive properties. If not, it
should be added ;) I'll try again to get some information from people
more experienced with YAML. But we don't depend on it.
> Regarding the device tree changes: I am not very familiar with the
> needed documentation changes, YAML bindings or what needs to be done
> for new bindings in general. Would you prefer to still consider them
> and/or get these subsystem level bindings done by someone more
> familiar with them? Another option would be for me to try find time to
> do the suggested bindings changes anyway, but it will likely require
> some effort from me to familiarize with device tree bindings changes
> and schedule the time for it.
No need to. Luckily, the I2C main bindings file is still text, so it is
easy to modify. I will send a patch out in a few minutes, so you can
base your driver code on that. Converting to YAML is a completely
different step, not related to your patch here. (Sidenote: I am looking
for volunteers to do that)
I think this covers it?
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Laine Jaakko EXT <ext-jaakko.laine@vaisala.com>
Cc: Rob Herring <robh@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: xiic: Support disabling multi-master in DT
Date: Wed, 27 May 2020 13:07:32 +0200 [thread overview]
Message-ID: <20200527110732.GA4875@ninjato> (raw)
In-Reply-To: <AM0PR06MB51857F4CDC7AE643CE160F9ED4A60@AM0PR06MB5185.eurprd06.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1490 bytes --]
Hi Jaako,
> The changes required to this patch at XIIC driver from suggested DT
> changes are pretty minor. Basically only checking a different
> property, reversing logic and some naming changes. I can make these
> changes already for the driver if this solution is what will be
> chosen, or would you prefer to still think about this?
I think we can go forward this way. Although I didn't find an example, I
am quite sure YAML format can have exclusive properties. If not, it
should be added ;) I'll try again to get some information from people
more experienced with YAML. But we don't depend on it.
> Regarding the device tree changes: I am not very familiar with the
> needed documentation changes, YAML bindings or what needs to be done
> for new bindings in general. Would you prefer to still consider them
> and/or get these subsystem level bindings done by someone more
> familiar with them? Another option would be for me to try find time to
> do the suggested bindings changes anyway, but it will likely require
> some effort from me to familiarize with device tree bindings changes
> and schedule the time for it.
No need to. Luckily, the I2C main bindings file is still text, so it is
easy to modify. I will send a patch out in a few minutes, so you can
base your driver code on that. Converting to YAML is a completely
different step, not related to your patch here. (Sidenote: I am looking
for volunteers to do that)
I think this covers it?
Happy hacking,
Wolfram
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-27 11:07 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 13:58 [PATCH] i2c: xiic: Support disabling multi-master in DT Laine Jaakko EXT
2020-02-18 13:58 ` Laine Jaakko EXT
2020-02-24 10:13 ` Michal Simek
2020-02-24 10:13 ` Michal Simek
2020-02-25 14:08 ` Laine Jaakko EXT
2020-02-25 14:08 ` Laine Jaakko EXT
2020-02-25 14:13 ` Wolfram Sang
2020-02-25 14:13 ` Wolfram Sang
2020-02-25 14:27 ` Laine Jaakko EXT
2020-02-25 14:27 ` Laine Jaakko EXT
2020-02-25 14:32 ` Wolfram Sang
2020-02-25 14:32 ` Wolfram Sang
2020-02-25 14:37 ` Michal Simek
2020-02-25 14:37 ` Michal Simek
2020-02-25 14:41 ` Wolfram Sang
2020-02-25 14:41 ` Wolfram Sang
2020-02-25 14:44 ` Michal Simek
2020-02-25 14:44 ` Michal Simek
2020-02-25 14:48 ` Wolfram Sang
2020-02-25 14:48 ` Wolfram Sang
2020-02-25 14:49 ` Michal Simek
2020-02-25 14:49 ` Michal Simek
2020-03-18 12:20 ` Shubhrajyoti Datta
2020-03-18 12:20 ` Shubhrajyoti Datta
2020-03-18 16:49 ` Laine Jaakko EXT
2020-03-18 16:49 ` Laine Jaakko EXT
2020-03-19 9:34 ` Shubhrajyoti Datta
2020-03-19 9:34 ` Shubhrajyoti Datta
2020-03-19 10:26 ` Laine Jaakko EXT
2020-03-19 10:26 ` Laine Jaakko EXT
2020-04-16 10:42 ` Laine Jaakko EXT
2020-04-16 10:42 ` Laine Jaakko EXT
2020-04-01 14:41 ` Wolfram Sang
2020-04-01 14:41 ` Wolfram Sang
2020-04-02 6:16 ` Laine Jaakko EXT
2020-04-02 6:16 ` Laine Jaakko EXT
2020-04-02 9:28 ` Wolfram Sang
2020-04-02 9:28 ` Wolfram Sang
2020-05-04 12:58 ` Laine Jaakko EXT
2020-05-04 12:58 ` Laine Jaakko EXT
2020-05-27 11:07 ` Wolfram Sang [this message]
2020-05-27 11:07 ` Wolfram Sang
2020-05-27 11:27 ` Laine Jaakko EXT
2020-05-27 11:27 ` Laine Jaakko EXT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527110732.GA4875@ninjato \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=ext-jaakko.laine@vaisala.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
--cc=shubhrajyoti.datta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.