From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock
Date: Wed, 27 May 2020 14:02:33 -0700 [thread overview]
Message-ID: <20200527210233.GC206249@google.com> (raw)
In-Reply-To: <20200527102753.15743-3-yuchao0@huawei.com>
On 05/27, Chao Yu wrote:
> meta inode page should be flushed under cp_lock, fix it.
It doesn't matter for this case, yes?
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/file.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f7de2a1da528..0fcae4d90074 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2260,7 +2260,9 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg)
> set_sbi_flag(sbi, SBI_IS_SHUTDOWN);
> break;
> case F2FS_GOING_DOWN_METAFLUSH:
> + mutex_lock(&sbi->cp_mutex);
> f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_META_IO);
> + mutex_unlock(&sbi->cp_mutex);
> f2fs_stop_checkpoint(sbi, false);
> set_sbi_flag(sbi, SBI_IS_SHUTDOWN);
> break;
> --
> 2.18.0.rc1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock
Date: Wed, 27 May 2020 14:02:33 -0700 [thread overview]
Message-ID: <20200527210233.GC206249@google.com> (raw)
In-Reply-To: <20200527102753.15743-3-yuchao0@huawei.com>
On 05/27, Chao Yu wrote:
> meta inode page should be flushed under cp_lock, fix it.
It doesn't matter for this case, yes?
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/file.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f7de2a1da528..0fcae4d90074 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2260,7 +2260,9 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg)
> set_sbi_flag(sbi, SBI_IS_SHUTDOWN);
> break;
> case F2FS_GOING_DOWN_METAFLUSH:
> + mutex_lock(&sbi->cp_mutex);
> f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_META_IO);
> + mutex_unlock(&sbi->cp_mutex);
> f2fs_stop_checkpoint(sbi, false);
> set_sbi_flag(sbi, SBI_IS_SHUTDOWN);
> break;
> --
> 2.18.0.rc1
next prev parent reply other threads:[~2020-05-27 21:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:27 [f2fs-dev] [PATCH 1/3] f2fs: fix wrong value of tracepoint parameter Chao Yu
2020-05-27 10:27 ` Chao Yu
2020-05-27 10:27 ` [f2fs-dev] [PATCH 2/3] f2fs: remove unneeded return value of __insert_discard_tree() Chao Yu
2020-05-27 10:27 ` Chao Yu
2020-05-27 10:27 ` [f2fs-dev] [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock Chao Yu
2020-05-27 10:27 ` Chao Yu
2020-05-27 21:02 ` Jaegeuk Kim [this message]
2020-05-27 21:02 ` Jaegeuk Kim
2020-05-28 1:23 ` [f2fs-dev] " Chao Yu
2020-05-28 1:23 ` Chao Yu
2020-05-28 1:26 ` [f2fs-dev] " Jaegeuk Kim
2020-05-28 1:26 ` Jaegeuk Kim
2020-05-28 1:47 ` [f2fs-dev] " Chao Yu
2020-05-28 1:47 ` Chao Yu
2020-05-28 19:00 ` [f2fs-dev] " Jaegeuk Kim
2020-05-28 19:00 ` Jaegeuk Kim
2020-05-29 6:37 ` [f2fs-dev] " Chao Yu
2020-05-29 6:37 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527210233.GC206249@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.