Re: [PATCH v6 5/5] drivers/tty/serial: add LiteUART driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3997 bytes --]

Hi Mateusz,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on tty/tty-testing usb/usb-testing staging/staging-testing driver-core/driver-core-testing linus/master v5.7-rc7 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Mateusz-Holenko/LiteX-SoC-controller-and-LiteUART-serial-driver/20200528-003240
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/tty/serial/liteuart.c:266:9: error: implicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]
uart = kzalloc(sizeof(struct liteuart_port), GFP_KERNEL);
^
drivers/tty/serial/liteuart.c:266:9: note: did you mean 'vzalloc'?
include/linux/vmalloc.h:106:14: note: 'vzalloc' declared here
extern void *vzalloc(unsigned long size);
^
>> drivers/tty/serial/liteuart.c:266:7: warning: incompatible integer to pointer conversion assigning to 'struct liteuart_port *' from 'int' [-Wint-conversion]
uart = kzalloc(sizeof(struct liteuart_port), GFP_KERNEL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.

vim +/kzalloc +266 drivers/tty/serial/liteuart.c

   243	
   244	static int liteuart_probe(struct platform_device *pdev)
   245	{
   246		struct device_node *np = pdev->dev.of_node;
   247		struct liteuart_port *uart;
   248		struct uart_port *port;
   249		struct xa_limit limit;
   250		int dev_id, ret;
   251	
   252		/* no device tree */
   253		if (!np)
   254			return -ENODEV;
   255	
   256		if (!litex_check_accessors())
   257			return -EPROBE_DEFER;
   258	
   259		/* look for aliases; auto-enumerate for free index if not found */
   260		dev_id = of_alias_get_id(np, "serial");
   261		if (dev_id < 0)
   262			limit = XA_LIMIT(0, CONFIG_SERIAL_LITEUART_MAX_PORTS);
   263		else
   264			limit = XA_LIMIT(dev_id, dev_id);
   265	
 > 266		uart = kzalloc(sizeof(struct liteuart_port), GFP_KERNEL);
   267		if (!uart)
   268			return -ENOMEM;
   269	
   270		ret = xa_alloc(&liteuart_array, &dev_id, uart, limit, GFP_KERNEL);
   271		if (ret)
   272			return ret;
   273	
   274		port = &uart->port;
   275	
   276		/* get membase */
   277		port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
   278		if (!port->membase)
   279			return -ENXIO;
   280	
   281		/* values not from device tree */
   282		port->dev = &pdev->dev;
   283		port->iotype = UPIO_MEM;
   284		port->flags = UPF_BOOT_AUTOCONF;
   285		port->ops = &liteuart_ops;
   286		port->regshift = 2;
   287		port->fifosize = 16;
   288		port->iobase = 1;
   289		port->type = PORT_UNKNOWN;
   290		port->line = dev_id;
   291		spin_lock_init(&port->lock);
   292	
   293		return uart_add_one_port(&liteuart_driver, &uart->port);
   294	}
   295	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73561 bytes --]